<p><a href="https://review.coreboot.org/28753">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c">File src/soc/amd/stoneyridge/iommu.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c@30">Patch Set #1, Line 30:</a> <code style="font-family:monospace,monospace">0x44</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Any reason this value was chosen?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c@38">Patch Set #1, Line 38:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">static void iommu_set_resources(struct device *dev)<br>{<br>      pci_dev_set_resources(dev);<br>}<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Get rid of this and call pci_dev_set_resources directly from the ops table?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28753">change 28753</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28753"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I688d867c7bd4949a57b27c1b6a793c6a6e4a717a </div>
<div style="display:none"> Gerrit-Change-Number: 28753 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 01 Oct 2018 15:33:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>