<p>Tristan Hsieh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28845">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mediatek/mt8183: Add DDR driver of memory test part<br><br>BUG=b:80501386<br>BRANCH=none<br>TEST=Boots correctly on Kukui, and inits DRAM successfully with related<br> patches.<br><br>Change-Id: I30d5fbd3db2acf36e3058ba4f34558b981fba78c<br>Signed-off-by: Huayang Duan <huayang.duan@mediatek.com><br>---<br>M src/soc/mediatek/mt8183/Kconfig<br>M src/soc/mediatek/mt8183/Makefile.inc<br>M src/soc/mediatek/mt8183/memory.c<br>3 files changed, 40 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/28845/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/mediatek/mt8183/Kconfig b/src/soc/mediatek/mt8183/Kconfig</span><br><span>index b58be7f..51c6df3 100644</span><br><span>--- a/src/soc/mediatek/mt8183/Kconfig</span><br><span>+++ b/src/soc/mediatek/mt8183/Kconfig</span><br><span>@@ -19,4 +19,14 @@</span><br><span> select VBOOT_STARTS_IN_BOOTBLOCK</span><br><span> select VBOOT_SEPARATE_VERSTAGE</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+config DEBUG_DRAM</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "Output verbose DRAM related debug messages"</span><br><span style="color: hsl(120, 100%, 40%);">+ default n</span><br><span style="color: hsl(120, 100%, 40%);">+ help</span><br><span style="color: hsl(120, 100%, 40%);">+ This option enables additional DRAM related debug messages.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config MEMORY_TEST</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+ default y</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> endif</span><br><span>diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc</span><br><span>index ec2a9c0..2c128f9 100644</span><br><span>--- a/src/soc/mediatek/mt8183/Makefile.inc</span><br><span>+++ b/src/soc/mediatek/mt8183/Makefile.inc</span><br><span>@@ -24,6 +24,7 @@</span><br><span> romstage-y += dramc_pi_basic_api.c</span><br><span> romstage-y += dramc_pi_calibration_api.c</span><br><span> romstage-y += memory.c</span><br><span style="color: hsl(120, 100%, 40%);">+romstage-$(CONFIG_MEMORY_TEST) += ../common/memory_test.c</span><br><span> romstage-y += ../common/gpio.c gpio.c</span><br><span> romstage-y += ../common/mmu_operations.c mmu_operations.c</span><br><span> romstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c</span><br><span>diff --git a/src/soc/mediatek/mt8183/memory.c b/src/soc/mediatek/mt8183/memory.c</span><br><span>index 643ca6b..a0f698c 100644</span><br><span>--- a/src/soc/mediatek/mt8183/memory.c</span><br><span>+++ b/src/soc/mediatek/mt8183/memory.c</span><br><span>@@ -13,10 +13,39 @@</span><br><span> * GNU General Public License for more details.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <assert.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <console/console.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <soc/dramc_pi_api.h></span><br><span> #include <soc/emi.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <symbols.h></span><br><span> </span><br><span> void mt_mem_init(const struct sdram_params *params)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ u64 rank_size[RANK_MAX];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* memory calibration */</span><br><span> mt_set_emi(params);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (IS_ENABLED(CONFIG_MEMORY_TEST)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ size_t r;</span><br><span style="color: hsl(120, 100%, 40%);">+ u8 *addr = _dram;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ dramc_get_rank_size(&rank_size[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (r = RANK_0; r < RANK_MAX; r++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ int i;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rank_size[r] == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ i = complex_mem_test(addr, 0x2000);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_DEBUG, "[MEM] complex R/W mem test %s : %d\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ (i == 0) ? "pass" : "fail", i);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT(i == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ addr += rank_size[r];</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28845">change 28845</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28845"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I30d5fbd3db2acf36e3058ba4f34558b981fba78c </div>
<div style="display:none"> Gerrit-Change-Number: 28845 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tristan Hsieh <tristan.shieh@mediatek.com> </div>