<p>Rizwan Qureshi has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28849">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">arch/x86: Make mb/romstage.c optional<br><br>currently src/mainboard/*/romstage.c is mandatory for<br>compiling, this makes having the file present even though<br>there is nothing to initialize in the romstage on the<br>mainboard side. for e.g., mainboard/intel/cannonlake_rvp/romstage.c<br>Eliminate the need to have empty romstage.c files using the<br>wildcard function.<br><br>BUG=None<br>BRANCH=None<br>TEST= build cannonlake_rvp after removing the romstage.c file.<br><br>Change-Id: Id6335a473d413d1aa89389d3a3d174ed4a1bda90<br>Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com><br>---<br>M src/arch/x86/Makefile.inc<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/28849/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc</span><br><span>index 3e272dd..7f85b6a 100644</span><br><span>--- a/src/arch/x86/Makefile.inc</span><br><span>+++ b/src/arch/x86/Makefile.inc</span><br><span>@@ -224,7 +224,7 @@</span><br><span> romstage-y += postcar_loader.c</span><br><span> romstage-$(CONFIG_COLLECT_TIMESTAMPS_TSC) += timestamp.c</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-romstage-srcs += $(src)/mainboard/$(MAINBOARDDIR)/romstage.c</span><br><span style="color: hsl(120, 100%, 40%);">+romstage-srcs += $(wildcard $(src)/mainboard/$(MAINBOARDDIR)/romstage.c)</span><br><span> romstage-libs ?=</span><br><span> </span><br><span> $(eval $(call early_x86_assembly_entry_rule,romstage))</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28849">change 28849</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28849"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id6335a473d413d1aa89389d3a3d174ed4a1bda90 </div>
<div style="display:none"> Gerrit-Change-Number: 28849 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>