<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/28695">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Furquan Shaikh: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/poppy/variants/rammus: Modify VR setting<br><br>We refer to Intel Doc#594883.<br>The recommended Ac/Dc loadline values are as below:<br># VR Settings Configuration for 4 Domains<br>#+----------------+-------+-------+-------+-------+<br>#| Domain/Setting | SA | IA | GTUS | GTS |<br>#+----------------+-------+-------+-------+-------+<br>#| Psi1Threshold | 20A | 20A | 20A | 20A |<br>#| Psi2Threshold | 2A | 2A | 2A | 2A |<br>#| Psi3Threshold | 1A | 1A | 1A | 1A |<br>#| Psi3Enable | 1 | 1 | 1 | 1 |<br>#| Psi4Enable | 1 | 1 | 1 | 1 |<br>#| ImonSlope | 0 | 0 | 0 | 0 |<br>#| ImonOffset | 0 | 0 | 0 | 0 |<br>#| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |<br>#| AcLoadline | 14.4 | 4.2 | 5.7 | 4.47 |<br>#| DcLoadline | 14.0 | 4.17 | 4.2 | 4.3 |<br>#+----------------+-------+-------+-------+-------+<br><br>BUG=b:112167318<br>BRANCH=master<br>TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage<br>Flash FW to DUT, and make sure system boots up.<br><br>Change-Id: I2d83d835ec841ac4cc811a0a69f74d203d5ea173<br>Signed-off-by: statham_chu <statham_chu@pegatron.corp-partner.google.com><br>Reviewed-on: https://review.coreboot.org/28695<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/poppy/variants/rammus/devicetree.cb<br>1 file changed, 9 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/rammus/devicetree.cb b/src/mainboard/google/poppy/variants/rammus/devicetree.cb</span><br><span>index 7b851ac..b750cb8 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/rammus/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/rammus/devicetree.cb</span><br><span>@@ -83,8 +83,8 @@</span><br><span> #| ImonSlope | 0 | 0 | 0 | 0 |</span><br><span> #| ImonOffset | 0 | 0 | 0 | 0 |</span><br><span> #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |</span><br><span style="color: hsl(0, 100%, 40%);">- #| AcLoadline | 15 | 5.7 | 5.5 | 5.5 |</span><br><span style="color: hsl(0, 100%, 40%);">- #| DcLoadline | 14.3 | 4.83 | 4.2 | 4.2 |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| AcLoadline | 14.4 | 4.2 | 5.7 | 4.47 |</span><br><span style="color: hsl(120, 100%, 40%);">+ #| DcLoadline | 14.0 | 4.17 | 4.2 | 4.3 |</span><br><span> #+----------------+-------+-------+-------+-------+</span><br><span> register "domain_vr_config[VR_SYSTEM_AGENT]" = "{</span><br><span> .vr_config_enable = 1,</span><br><span>@@ -96,8 +96,8 @@</span><br><span> .imon_slope = 0x0,</span><br><span> .imon_offset = 0x0,</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(0, 100%, 40%);">- .ac_loadline = 1500,</span><br><span style="color: hsl(0, 100%, 40%);">- .dc_loadline = 1430,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 1440,</span><br><span style="color: hsl(120, 100%, 40%);">+ .dc_loadline = 1400,</span><br><span> }"</span><br><span> </span><br><span> register "domain_vr_config[VR_IA_CORE]" = "{</span><br><span>@@ -110,8 +110,8 @@</span><br><span> .imon_slope = 0x0,</span><br><span> .imon_offset = 0x0,</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(0, 100%, 40%);">- .ac_loadline = 570,</span><br><span style="color: hsl(0, 100%, 40%);">- .dc_loadline = 483,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 420,</span><br><span style="color: hsl(120, 100%, 40%);">+ .dc_loadline = 417,</span><br><span> }"</span><br><span> </span><br><span> register "domain_vr_config[VR_GT_UNSLICED]" = "{</span><br><span>@@ -124,7 +124,7 @@</span><br><span> .imon_slope = 0x0,</span><br><span> .imon_offset = 0x0,</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(0, 100%, 40%);">- .ac_loadline = 550,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 570,</span><br><span> .dc_loadline = 420,</span><br><span> }"</span><br><span> </span><br><span>@@ -138,8 +138,8 @@</span><br><span> .imon_slope = 0x0,</span><br><span> .imon_offset = 0x0,</span><br><span> .voltage_limit = 1520,</span><br><span style="color: hsl(0, 100%, 40%);">- .ac_loadline = 550,</span><br><span style="color: hsl(0, 100%, 40%);">- .dc_loadline = 420,</span><br><span style="color: hsl(120, 100%, 40%);">+ .ac_loadline = 447,</span><br><span style="color: hsl(120, 100%, 40%);">+ .dc_loadline = 430,</span><br><span> }"</span><br><span> </span><br><span> # Enable Root port 1.</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28695">change 28695</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28695"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I2d83d835ec841ac4cc811a0a69f74d203d5ea173 </div>
<div style="display:none"> Gerrit-Change-Number: 28695 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Statham Chu <statham_chu@pegatron.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Statham Chu <statham_chu@pegatron.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Gaggery Tsai <gaggery.tsai@intel.com> </div>
<div style="display:none"> Gerrit-CC: Jerry Chou <jerry_chou@pegatron.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-CC: Ken Lu <ken_lu@pegatron.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-CC: YanRu Chen <kane_chen@pegatron.corp-partner.google.com> </div>