<p>Sathyanarayana Nujella would like Jairaj Arava and HARSHAPRIYA N to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/28778">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">WIP: generic: Add generic DMIC driver<br><br>DMIC driver in Kernel needs configurations like modeswitch_delay_ms<br>which is used to adust the minimum clock ON time, etc.<br><br>DMIC is not an I2S or I2C slave, so adding as a generic driver.<br><br>BUG=b:112888584<br>TEST=build coreboot and cross check DUT boots<br><br>Change-Id: Ic8c8be1aa04e8d35ad4827d81a37ee54c25dfc63<br>Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com><br>Signed-off-by: Jairaj Arava <jairaj.arava@intel.com><br>Signed-off-by: Harsha Priya <harshapriya.n@intel.com><br>---<br>A src/drivers/generic/dmic/Kconfig<br>A src/drivers/generic/dmic/Makefile.inc<br>A src/drivers/generic/dmic/chip.h<br>A src/drivers/generic/dmic/dmic.c<br>4 files changed, 97 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/28778/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/generic/dmic/Kconfig b/src/drivers/generic/dmic/Kconfig</span><br><span>new file mode 100644</span><br><span>index 0000000..5234eeb</span><br><span>--- /dev/null</span><br><span>+++ b/src/drivers/generic/dmic/Kconfig</span><br><span>@@ -0,0 +1,2 @@</span><br><span style="color: hsl(120, 100%, 40%);">+config DRIVERS_GENERIC_DMIC</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span>diff --git a/src/drivers/generic/dmic/Makefile.inc b/src/drivers/generic/dmic/Makefile.inc</span><br><span>new file mode 100644</span><br><span>index 0000000..52bb984</span><br><span>--- /dev/null</span><br><span>+++ b/src/drivers/generic/dmic/Makefile.inc</span><br><span>@@ -0,0 +1 @@</span><br><span style="color: hsl(120, 100%, 40%);">+ramstage-$(CONFIG_DRIVERS_GENERIC_DMIC) += dmic.c</span><br><span>diff --git a/src/drivers/generic/dmic/chip.h b/src/drivers/generic/dmic/chip.h</span><br><span>new file mode 100644</span><br><span>index 0000000..6cb19bd</span><br><span>--- /dev/null</span><br><span>+++ b/src/drivers/generic/dmic/chip.h</span><br><span>@@ -0,0 +1,11 @@</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef __DRIVERS_GENERIC_DMIC__</span><br><span style="color: hsl(120, 100%, 40%);">+#define __DRIVERS_GENERIC_DMIC__</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <arch/acpi_device.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct drivers_generic_dmic_config {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* SDMODE Delay */</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned modeswitch_delay_ms;</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span>diff --git a/src/drivers/generic/dmic/dmic.c b/src/drivers/generic/dmic/dmic.c</span><br><span>new file mode 100644</span><br><span>index 0000000..e90f475</span><br><span>--- /dev/null</span><br><span>+++ b/src/drivers/generic/dmic/dmic.c</span><br><span>@@ -0,0 +1,83 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2016 Google Inc.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <arch/acpi_device.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <arch/acpigen.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <console/console.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <device/device.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <device/path.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <gpio.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <stdint.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <string.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include "chip.h"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define DMIC_ACPI_NAME "DMIC"</span><br><span style="color: hsl(120, 100%, 40%);">+#define DMIC_ACPI_HID "DMIC"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void dmic_fill_ssdt(struct device *dev)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct drivers_generic_dmic_config *config = dev->chip_info;</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *path;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct acpi_dp *dp;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!config)</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Device */</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_write_scope(acpi_device_scope(dev));</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_write_device(acpi_device_name(dev));</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_write_name_string("_HID", DMIC_ACPI_HID);</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_write_name_integer("_UID", 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_write_name_string("_DDN", dev->chip_ops->name);</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* _DSD for devicetree properties */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* This points to the first pin in the first gpio entry in _CRS */</span><br><span style="color: hsl(120, 100%, 40%);">+ path = acpi_device_path(dev);</span><br><span style="color: hsl(120, 100%, 40%);">+ dp = acpi_dp_new_table("_DSD");</span><br><span style="color: hsl(120, 100%, 40%);">+ acpi_dp_add_integer(dp, "modeswitch_delay_ms", config->modeswitch_delay_ms);</span><br><span style="color: hsl(120, 100%, 40%);">+ acpi_dp_write(dp);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_pop_len(); /* Device */</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_pop_len(); /* Scope */</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static const char *dmic_acpi_name(const struct device *dev)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ return DMIC_ACPI_NAME;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static struct device_operations dmic_ops = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .read_resources = DEVICE_NOOP,</span><br><span style="color: hsl(120, 100%, 40%);">+ .set_resources = DEVICE_NOOP,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enable_resources = DEVICE_NOOP,</span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)</span><br><span style="color: hsl(120, 100%, 40%);">+ .acpi_name = &dmic_acpi_name,</span><br><span style="color: hsl(120, 100%, 40%);">+ .acpi_fill_ssdt_generator = &dmic_fill_ssdt,</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void dmic_enable(struct device *dev)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ dev->ops = &dmic_ops;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct chip_operations drivers_generic_dmic_ops = {</span><br><span style="color: hsl(120, 100%, 40%);">+ CHIP_NAME("DMIC")</span><br><span style="color: hsl(120, 100%, 40%);">+ .enable_dev = &dmic_enable</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28778">change 28778</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28778"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic8c8be1aa04e8d35ad4827d81a37ee54c25dfc63 </div>
<div style="display:none"> Gerrit-Change-Number: 28778 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jairaj Arava <jairaj.arava@intel.com> </div>