<p><a href="https://review.coreboot.org/28771">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28771/1/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl">File src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28771/1/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl@642">Patch Set #1, Line 642:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Not very clear. Apparently this code only executes something (HW wise) if Arg0 is bit5.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I agree.  I'd meant to go back and figure out what AMD was trying to say, and forgot to.  Looks like</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  /*<br>   * Helper...<br>   * Arg0: bit to set or clear<br>   * Arg1: 0: clear bit[Arg0], non-0: set bit[Arg0]<br>   */</pre></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28771">change 28771</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28771"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ief602c4bc42d27b3e236d24db815b990f3a2419c </div>
<div style="display:none"> Gerrit-Change-Number: 28771 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 27 Sep 2018 21:12:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>