<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28759">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/nocturne: Define GPP_D17 as EC_SYNC_IRQ<br><br>Use GPIO GPP_D17 pin as the EC sync interrupt and provide this value<br>to the embedded controller to be exported to the OS.<br><br>This interface was tested on a reworked Nocturne board with modified<br>EC and a modified kernel driver to ensure that the interrupt asserts<br>as expected and can be used by the kernel driver.<br><br>Change-Id: Ie2b33692367b5d9ecc2b128180d8cfe4f6b347b1<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/gpio.c<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h<br>3 files changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/28759/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>index 15a97c3..99b2dcf 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>@@ -196,7 +196,7 @@</span><br><span>      /* D16 : ISH_UART0_CTS# ==> RCAM_RST_L */</span><br><span>         PAD_CFG_GPO(GPP_D16, 0, DEEP),</span><br><span>       /* D17 : DMIC_CLK1 ==> EC_PCH_ARCORE_INT_L */</span><br><span style="color: hsl(0, 100%, 40%);">-        PAD_CFG_NC(GPP_D17),</span><br><span style="color: hsl(120, 100%, 40%);">+  PAD_CFG_GPI_APIC(GPP_D17, NONE, PLTRST),</span><br><span>     /* D18 : DMIC_DATA1 ==> TP131 */</span><br><span>  PAD_CFG_NC(GPP_D18),</span><br><span>         /* D19 : DMIC_CLK0 ==> PCH_DMIC_CLK_OUT */</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h</span><br><span>index 7e16801..ba481e4 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h</span><br><span>@@ -79,4 +79,7 @@</span><br><span> #define EC_ENABLE_MKBP_DEVICE  /* Enable cros_ec_keyb device */</span><br><span> #define EC_ENABLE_CBAS_DEVICE  /* Enable "Base Attached Switch" device */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Enable EC sync interrupt, EC_SYNC_IRQ is defined in variant/gpio.h */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_ENABLE_SYNC_IRQ</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #endif /* __MAINBOARD_EC_H__ */</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h b/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h</span><br><span>index 0853893..fb7ad1a 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h</span><br><span>@@ -34,6 +34,9 @@</span><br><span> /* EC wake is LAN_WAKE# which is a special DeepSX wake pin */</span><br><span> #define GPE_EC_WAKE                GPE0_LAN_WAK</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* EC sync irq is GPP_D12 */</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_SYNC_IRQ             GPP_D17_IRQ</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* eSPI virtual wire reporting */</span><br><span> #define EC_SCI_GPI                GPE0_ESPI</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28759">change 28759</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28759"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie2b33692367b5d9ecc2b128180d8cfe4f6b347b1 </div>
<div style="display:none"> Gerrit-Change-Number: 28759 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>