<p>dhaval v sharma has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28721">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/google/chromeec: set SCI event mask early on s0<br><br>Change helps in avoiding an ACPI switch SMI later<br><br>Change-Id: Ib4d2b3e12d1d63dba29c5365c5a2fbf7b221226b<br>Signed-off-by: Dhaval <dhaval.v.sharma@intel.com><br>---<br>M src/ec/google/chromeec/ec.c<br>1 file changed, 7 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/28721/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c</span><br><span>index 90fcc3d..17ee13a 100644</span><br><span>--- a/src/ec/google/chromeec/ec.c</span><br><span>+++ b/src/ec/google/chromeec/ec.c</span><br><span>@@ -474,9 +474,6 @@</span><br><span>                 while (google_chromeec_get_event() != 0)</span><br><span>                     ;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           /* Restore SCI event mask. */</span><br><span style="color: hsl(0, 100%, 40%);">-           google_chromeec_set_sci_mask(info->sci_events);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>   } else {</span><br><span>             google_chromeec_set_smi_mask(info->smi_events);</span><br><span> </span><br><span>@@ -489,6 +486,13 @@</span><br><span>                                        info->s3_wake_events,</span><br><span>                                     info->s0ix_wake_events);</span><br><span>  }</span><br><span style="color: hsl(120, 100%, 40%);">+     /* Should be okay to set sci mask for s0 path also because</span><br><span style="color: hsl(120, 100%, 40%);">+     * anyways SCI interrupt gets enabled later during PMC init</span><br><span style="color: hsl(120, 100%, 40%);">+    * stage this way we can avoid additional ACPI switch SMI</span><br><span style="color: hsl(120, 100%, 40%);">+      * later */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ google_chromeec_set_sci_mask(info->sci_events);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span>     /* Clear wake event mask. */</span><br><span>         google_chromeec_set_wake_mask(0);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28721">change 28721</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28721"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib4d2b3e12d1d63dba29c5365c5a2fbf7b221226b </div>
<div style="display:none"> Gerrit-Change-Number: 28721 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dhaval v sharma <dhaval.v.sharma@intel.com> </div>