<p><a href="https://review.coreboot.org/28641">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/azalia.c">File src/southbridge/intel/lynxpoint/azalia.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/azalia.c@157">Patch Set #6, Line 157:</a> <code style="font-family:monospace,monospace">static void azalia_set_subsystem(struct device *dev, unsigned vendor,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/azalia.c@158">Patch Set #6, Line 158:</a> <code style="font-family:monospace,monospace">                             unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/serialio.c">File src/southbridge/intel/lynxpoint/serialio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/serialio.c@240">Patch Set #6, Line 240:</a> <code style="font-family:monospace,monospace">static void serialio_set_subsystem(struct device *dev, unsigned vendor,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/smbus.c">File src/southbridge/intel/lynxpoint/smbus.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/smbus.c@73">Patch Set #6, Line 73:</a> <code style="font-family:monospace,monospace">static void smbus_set_subsystem(struct device *dev, unsigned vendor,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/smbus.c@74">Patch Set #6, Line 74:</a> <code style="font-family:monospace,monospace">                          unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb_ehci.c">File src/southbridge/intel/lynxpoint/usb_ehci.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb_ehci.c@167">Patch Set #6, Line 167:</a> <code style="font-family:monospace,monospace">static void usb_ehci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb_ehci.c@167">Patch Set #6, Line 167:</a> <code style="font-family:monospace,monospace">static void usb_ehci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb_ehci.c@167">Patch Set #6, Line 167:</a> <code style="font-family:monospace,monospace">static void usb_ehci_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb_xhci.c">File src/southbridge/intel/lynxpoint/usb_xhci.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28641/6/src/southbridge/intel/lynxpoint/usb_xhci.c@364">Patch Set #6, Line 364:</a> <code style="font-family:monospace,monospace">static void usb_xhci_set_subsystem(struct device *dev, unsigned vendor,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28641">change 28641</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28641"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I515b9e388dd2c1d1a9f4a24b2966a4b4656965a7 </div>
<div style="display:none"> Gerrit-Change-Number: 28641 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 20 Sep 2018 15:02:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>