<p>Jonathan Neuschäfer has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28706">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/lowrisc: Remove the Nexys4DDR port<br><br>This board doesn't support the newest RISC-V Privileged Architecture<br>spec (1.10), and it's based on an FPGA so it's a moving target.<br><br>Now that there's actual RISC-V silicon out there (from SiFive),<br>mb/lowrisc/nexys4ddr will only continue to bitrot.<br><br>Change-Id: I4e3e715106a1a94381a563dc4a56781c35883c2d<br>Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net><br>---<br>M MAINTAINERS<br>D src/mainboard/lowrisc/Kconfig<br>D src/mainboard/lowrisc/Kconfig.name<br>D src/mainboard/lowrisc/nexys4ddr/Kconfig<br>D src/mainboard/lowrisc/nexys4ddr/Kconfig.name<br>D src/mainboard/lowrisc/nexys4ddr/Makefile.inc<br>D src/mainboard/lowrisc/nexys4ddr/board_info.txt<br>D src/mainboard/lowrisc/nexys4ddr/devicetree.cb<br>D src/mainboard/lowrisc/nexys4ddr/mainboard.c<br>D src/mainboard/lowrisc/nexys4ddr/memlayout.ld<br>D src/mainboard/lowrisc/nexys4ddr/rom_media.c<br>D src/mainboard/lowrisc/nexys4ddr/romstage.c<br>D src/mainboard/lowrisc/nexys4ddr/uart.c<br>D src/soc/lowrisc/Kconfig<br>D src/soc/lowrisc/lowrisc/Kconfig<br>D src/soc/lowrisc/lowrisc/Makefile.inc<br>D src/soc/lowrisc/lowrisc/cbmem.c<br>M util/release/genrelnotes<br>18 files changed, 1 insertion(+), 322 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/28706/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/MAINTAINERS b/MAINTAINERS</span><br><span>index ca8a6f2..4d27129 100644</span><br><span>--- a/MAINTAINERS</span><br><span>+++ b/MAINTAINERS</span><br><span>@@ -124,10 +124,8 @@</span><br><span> M: Jonathan Neuschäfer <j.neuschaefer@gmx.net></span><br><span> S: Maintained</span><br><span> F: src/arch/riscv/</span><br><span style="color: hsl(0, 100%, 40%);">-F: src/soc/lowrisc</span><br><span> F: src/soc/ucb/</span><br><span> F: src/mainboard/emulation/*-riscv/</span><br><span style="color: hsl(0, 100%, 40%);">-F: src/mainboard/lowrisc</span><br><span> </span><br><span> POWER8 ARCHITECTURE</span><br><span> M: Ronald Minnich <rminnich@gmail.com></span><br><span>diff --git a/src/mainboard/lowrisc/Kconfig b/src/mainboard/lowrisc/Kconfig</span><br><span>deleted file mode 100644</span><br><span>index ba0fbe7..0000000</span><br><span>--- a/src/mainboard/lowrisc/Kconfig</span><br><span>+++ /dev/null</span><br><span>@@ -1,16 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-if VENDOR_LOWRISC</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-choice</span><br><span style="color: hsl(0, 100%, 40%);">- prompt "Mainboard model"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-source "src/mainboard/lowrisc/*/Kconfig.name"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-endchoice</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-source "src/mainboard/lowrisc/*/Kconfig"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config MAINBOARD_VENDOR</span><br><span style="color: hsl(0, 100%, 40%);">- string</span><br><span style="color: hsl(0, 100%, 40%);">- default "lowrisc"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-endif # VENDOR_LOWRISC</span><br><span>diff --git a/src/mainboard/lowrisc/Kconfig.name b/src/mainboard/lowrisc/Kconfig.name</span><br><span>deleted file mode 100644</span><br><span>index 4c992fc..0000000</span><br><span>--- a/src/mainboard/lowrisc/Kconfig.name</span><br><span>+++ /dev/null</span><br><span>@@ -1,2 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-config VENDOR_LOWRISC</span><br><span style="color: hsl(0, 100%, 40%);">- bool "lowrisc"</span><br><span>diff --git a/src/mainboard/lowrisc/nexys4ddr/Kconfig b/src/mainboard/lowrisc/nexys4ddr/Kconfig</span><br><span>deleted file mode 100644</span><br><span>index 5a6bfb2..0000000</span><br><span>--- a/src/mainboard/lowrisc/nexys4ddr/Kconfig</span><br><span>+++ /dev/null</span><br><span>@@ -1,37 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## Copyright (C) 2016 Google Inc.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This software is licensed under the terms of the GNU General Public</span><br><span style="color: hsl(0, 100%, 40%);">-## License version 2, as published by the Free Software Foundation, and</span><br><span style="color: hsl(0, 100%, 40%);">-## may be copied, distributed, and modified under those terms.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">-## but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">-## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">-## GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-if BOARD_LOWRISC_NEXYS4DDR</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config BOARD_SPECIFIC_OPTIONS # dummy</span><br><span style="color: hsl(0, 100%, 40%);">- def_bool y</span><br><span style="color: hsl(0, 100%, 40%);">- select SOC_LOWRISC_LOWRISC</span><br><span style="color: hsl(0, 100%, 40%);">- select BOARD_ROMSIZE_KB_4096</span><br><span style="color: hsl(0, 100%, 40%);">- select DRIVERS_UART_8250MEM</span><br><span style="color: hsl(0, 100%, 40%);">- select BOOT_DEVICE_NOT_SPI_FLASH</span><br><span style="color: hsl(0, 100%, 40%);">- select UART_OVERRIDE_REFCLK</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config MAINBOARD_DIR</span><br><span style="color: hsl(0, 100%, 40%);">- string</span><br><span style="color: hsl(0, 100%, 40%);">- default lowrisc/nexys4ddr</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config MAINBOARD_PART_NUMBER</span><br><span style="color: hsl(0, 100%, 40%);">- string</span><br><span style="color: hsl(0, 100%, 40%);">- default "LOWRISC NEXYS4DDR"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config MAX_CPUS</span><br><span style="color: hsl(0, 100%, 40%);">- int</span><br><span style="color: hsl(0, 100%, 40%);">- default 1</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-endif # BOARD_LOWRISC_NEXYS4DDR</span><br><span>diff --git a/src/mainboard/lowrisc/nexys4ddr/Kconfig.name b/src/mainboard/lowrisc/nexys4ddr/Kconfig.name</span><br><span>deleted file mode 100644</span><br><span>index f99b3cc..0000000</span><br><span>--- a/src/mainboard/lowrisc/nexys4ddr/Kconfig.name</span><br><span>+++ /dev/null</span><br><span>@@ -1,2 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-config BOARD_LOWRISC_NEXYS4DDR</span><br><span style="color: hsl(0, 100%, 40%);">- bool "nexys4ddr"</span><br><span>diff --git a/src/mainboard/lowrisc/nexys4ddr/Makefile.inc b/src/mainboard/lowrisc/nexys4ddr/Makefile.inc</span><br><span>deleted file mode 100644</span><br><span>index abd341c..0000000</span><br><span>--- a/src/mainboard/lowrisc/nexys4ddr/Makefile.inc</span><br><span>+++ /dev/null</span><br><span>@@ -1,25 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## Copyright (C) 2016 Google Inc.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This software is licensed under the terms of the GNU General Public</span><br><span style="color: hsl(0, 100%, 40%);">-## License version 2, as published by the Free Software Foundation, and</span><br><span style="color: hsl(0, 100%, 40%);">-## may be copied, distributed, and modified under those terms.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">-## but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">-## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">-## GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-bootblock-y += uart.c</span><br><span style="color: hsl(0, 100%, 40%);">-bootblock-y += rom_media.c</span><br><span style="color: hsl(0, 100%, 40%);">-romstage-y += romstage.c</span><br><span style="color: hsl(0, 100%, 40%);">-romstage-y += uart.c</span><br><span style="color: hsl(0, 100%, 40%);">-romstage-y += rom_media.c</span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-y += uart.c</span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-y += rom_media.c</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-bootblock-y += memlayout.ld</span><br><span style="color: hsl(0, 100%, 40%);">-romstage-y += memlayout.ld</span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-y += memlayout.ld</span><br><span>diff --git a/src/mainboard/lowrisc/nexys4ddr/board_info.txt b/src/mainboard/lowrisc/nexys4ddr/board_info.txt</span><br><span>deleted file mode 100644</span><br><span>index a305030..0000000</span><br><span>--- a/src/mainboard/lowrisc/nexys4ddr/board_info.txt</span><br><span>+++ /dev/null</span><br><span>@@ -1,3 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-Board name: lowrisc nexys4ddr</span><br><span style="color: hsl(0, 100%, 40%);">-Category: eval</span><br><span style="color: hsl(0, 100%, 40%);">-Board URL: https://www.google.com/search?q=Tutorial+for+the+debug+preview+of+lowRISC&oq=Tutorial+for+the+debug+preview+of+lowRISC&btnI</span><br><span>diff --git a/src/mainboard/lowrisc/nexys4ddr/devicetree.cb b/src/mainboard/lowrisc/nexys4ddr/devicetree.cb</span><br><span>deleted file mode 100644</span><br><span>index e857276..0000000</span><br><span>--- a/src/mainboard/lowrisc/nexys4ddr/devicetree.cb</span><br><span>+++ /dev/null</span><br><span>@@ -1,20 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## Copyright (C) 2016 Google, Inc.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This software is licensed under the terms of the GNU General Public</span><br><span style="color: hsl(0, 100%, 40%);">-## License version 2, as published by the Free Software Foundation, and</span><br><span style="color: hsl(0, 100%, 40%);">-## may be copied, distributed, and modified under those terms.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">-## but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">-## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">-## GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-chip soc/ucb/riscv</span><br><span style="color: hsl(0, 100%, 40%);">- device cpu_cluster 0 on end</span><br><span style="color: hsl(0, 100%, 40%);">- chip drivers/generic/generic # I2C0 controller</span><br><span style="color: hsl(0, 100%, 40%);">- device i2c 6 on end # Fake component for testing</span><br><span style="color: hsl(0, 100%, 40%);">- end</span><br><span style="color: hsl(0, 100%, 40%);">-end</span><br><span>diff --git a/src/mainboard/lowrisc/nexys4ddr/mainboard.c b/src/mainboard/lowrisc/nexys4ddr/mainboard.c</span><br><span>deleted file mode 100644</span><br><span>index 3ef8337..0000000</span><br><span>--- a/src/mainboard/lowrisc/nexys4ddr/mainboard.c</span><br><span>+++ /dev/null</span><br><span>@@ -1,35 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright (C) 2016 Google, Inc.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">- * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">- * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <symbols.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static void mainboard_enable(struct device *dev)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- uintptr_t ram_base;</span><br><span style="color: hsl(0, 100%, 40%);">- size_t ram_size;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* FIXME: These values shouldn't necessarily be hardcoded */</span><br><span style="color: hsl(0, 100%, 40%);">- ram_base = 0x80000000;</span><br><span style="color: hsl(0, 100%, 40%);">- ram_size = 128 * MiB;</span><br><span style="color: hsl(0, 100%, 40%);">- ram_resource(dev, 0, ram_base / KiB, ram_size / KiB);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- cbmem_initialize_empty();</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct chip_operations mainboard_ops = {</span><br><span style="color: hsl(0, 100%, 40%);">- .enable_dev = mainboard_enable,</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span>diff --git a/src/mainboard/lowrisc/nexys4ddr/memlayout.ld b/src/mainboard/lowrisc/nexys4ddr/memlayout.ld</span><br><span>deleted file mode 100644</span><br><span>index 86f3667..0000000</span><br><span>--- a/src/mainboard/lowrisc/nexys4ddr/memlayout.ld</span><br><span>+++ /dev/null</span><br><span>@@ -1,31 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright 2016 Google Inc.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">- * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">- * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <memlayout.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/header.ld></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#define START 0x80000000</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-SECTIONS</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- DRAM_START(START)</span><br><span style="color: hsl(0, 100%, 40%);">- BOOTBLOCK(START, 64K)</span><br><span style="color: hsl(0, 100%, 40%);">- STACK(START + 8M, 64K)</span><br><span style="color: hsl(0, 100%, 40%);">- ROMSTAGE(START + 8M + 64K, 128K)</span><br><span style="color: hsl(0, 100%, 40%);">- PRERAM_CBMEM_CONSOLE(START + 8M + 192k, 8K)</span><br><span style="color: hsl(0, 100%, 40%);">- /* hole at (START + 8M + 200K, 56K) */</span><br><span style="color: hsl(0, 100%, 40%);">- RAMSTAGE(START + 8M + 256K, 256K)</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/mainboard/lowrisc/nexys4ddr/rom_media.c b/src/mainboard/lowrisc/nexys4ddr/rom_media.c</span><br><span>deleted file mode 100644</span><br><span>index 7d4ed00..0000000</span><br><span>--- a/src/mainboard/lowrisc/nexys4ddr/rom_media.c</span><br><span>+++ /dev/null</span><br><span>@@ -1,30 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright 2015 Google Inc.</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright 2016 Jonathan Neuschäfer <j.neuschaefer@gmx.net></span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or</span><br><span style="color: hsl(0, 100%, 40%);">- * modify it under the terms of the GNU General Public License as</span><br><span style="color: hsl(0, 100%, 40%);">- * published by the Free Software Foundation; version 2 of</span><br><span style="color: hsl(0, 100%, 40%);">- * the License.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-#include <boot_device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <symbols.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * _dram is the start of RAM. We currently need to load coreboot.rom into</span><br><span style="color: hsl(0, 100%, 40%);">- * RAM. The actual "rom" code on the FPGAs is in a block ram.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-static const struct mem_region_device boot_dev =</span><br><span style="color: hsl(0, 100%, 40%);">- MEM_REGION_DEV_RO_INIT(_dram, CONFIG_ROM_SIZE);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-const struct region_device *boot_device_ro(void)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- return &boot_dev.rdev;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/mainboard/lowrisc/nexys4ddr/romstage.c b/src/mainboard/lowrisc/nexys4ddr/romstage.c</span><br><span>deleted file mode 100644</span><br><span>index c918c83..0000000</span><br><span>--- a/src/mainboard/lowrisc/nexys4ddr/romstage.c</span><br><span>+++ /dev/null</span><br><span>@@ -1,23 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright (C) 2016 Google, Inc.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">- * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">- * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <program_loading.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-void main(void)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- console_init();</span><br><span style="color: hsl(0, 100%, 40%);">- run_ramstage();</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/mainboard/lowrisc/nexys4ddr/uart.c b/src/mainboard/lowrisc/nexys4ddr/uart.c</span><br><span>deleted file mode 100644</span><br><span>index 7758db3..0000000</span><br><span>--- a/src/mainboard/lowrisc/nexys4ddr/uart.c</span><br><span>+++ /dev/null</span><br><span>@@ -1,30 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright 2016 Google Inc.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">- * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">- * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <types.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <console/uart.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <boot/coreboot_tables.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-uintptr_t uart_platform_base(int idx)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- return (uintptr_t) 0x42000000;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* The clock which the UART is based on */</span><br><span style="color: hsl(0, 100%, 40%);">-unsigned int uart_platform_refclk(void)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- return 25 * MHz;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/soc/lowrisc/Kconfig b/src/soc/lowrisc/Kconfig</span><br><span>deleted file mode 100644</span><br><span>index a514135..0000000</span><br><span>--- a/src/soc/lowrisc/Kconfig</span><br><span>+++ /dev/null</span><br><span>@@ -1,2 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-# Load all chipsets</span><br><span style="color: hsl(0, 100%, 40%);">-source "src/soc/lowrisc/*/Kconfig"</span><br><span>diff --git a/src/soc/lowrisc/lowrisc/Kconfig b/src/soc/lowrisc/lowrisc/Kconfig</span><br><span>deleted file mode 100644</span><br><span>index 8b35231..0000000</span><br><span>--- a/src/soc/lowrisc/lowrisc/Kconfig</span><br><span>+++ /dev/null</span><br><span>@@ -1,29 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-config SOC_LOWRISC_LOWRISC</span><br><span style="color: hsl(0, 100%, 40%);">- select ARCH_RISCV</span><br><span style="color: hsl(0, 100%, 40%);">- select ARCH_BOOTBLOCK_RISCV</span><br><span style="color: hsl(0, 100%, 40%);">- select ARCH_VERSTAGE_RISCV</span><br><span style="color: hsl(0, 100%, 40%);">- select ARCH_ROMSTAGE_RISCV</span><br><span style="color: hsl(0, 100%, 40%);">- select ARCH_RAMSTAGE_RISCV</span><br><span style="color: hsl(0, 100%, 40%);">- select BOOTBLOCK_CONSOLE</span><br><span style="color: hsl(0, 100%, 40%);">- select DRIVERS_UART_8250MEM_32</span><br><span style="color: hsl(0, 100%, 40%);">- select GENERIC_UDELAY</span><br><span style="color: hsl(0, 100%, 40%);">- select HAVE_MONOTONIC_TIMER</span><br><span style="color: hsl(0, 100%, 40%);">- select RISCV_USE_ARCH_TIMER</span><br><span style="color: hsl(0, 100%, 40%);">- bool</span><br><span style="color: hsl(0, 100%, 40%);">- default n</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-if SOC_LOWRISC_LOWRISC</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config RISCV_ARCH</span><br><span style="color: hsl(0, 100%, 40%);">- string</span><br><span style="color: hsl(0, 100%, 40%);">- default "rv64imafd"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config RISCV_ABI</span><br><span style="color: hsl(0, 100%, 40%);">- string</span><br><span style="color: hsl(0, 100%, 40%);">- default "lp64d"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-config RISCV_CODEMODEL</span><br><span style="color: hsl(0, 100%, 40%);">- string</span><br><span style="color: hsl(0, 100%, 40%);">- default "medany"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-endif</span><br><span>diff --git a/src/soc/lowrisc/lowrisc/Makefile.inc b/src/soc/lowrisc/lowrisc/Makefile.inc</span><br><span>deleted file mode 100644</span><br><span>index ccd9a16..0000000</span><br><span>--- a/src/soc/lowrisc/lowrisc/Makefile.inc</span><br><span>+++ /dev/null</span><br><span>@@ -1,8 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-ifeq ($(CONFIG_SOC_LOWRISC_LOWRISC),y)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-bootblock-y += mtime.c</span><br><span style="color: hsl(0, 100%, 40%);">-romstage-y += cbmem.c</span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-y += cbmem.c</span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-y += mtime.c</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-endif</span><br><span>diff --git a/src/soc/lowrisc/lowrisc/cbmem.c b/src/soc/lowrisc/lowrisc/cbmem.c</span><br><span>deleted file mode 100644</span><br><span>index a212666..0000000</span><br><span>--- a/src/soc/lowrisc/lowrisc/cbmem.c</span><br><span>+++ /dev/null</span><br><span>@@ -1,26 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">- * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">- * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-void *cbmem_top(void)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- uintptr_t base;</span><br><span style="color: hsl(0, 100%, 40%);">- size_t size;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* FIXME: These values shouldn't necessarily be hardcoded */</span><br><span style="color: hsl(0, 100%, 40%);">- base = 0x80000000;</span><br><span style="color: hsl(0, 100%, 40%);">- size = 128 * MiB;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- return (void *)(base + size);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/util/release/genrelnotes b/util/release/genrelnotes</span><br><span>index dfdf21e..3038eb3 100755</span><br><span>--- a/util/release/genrelnotes</span><br><span>+++ b/util/release/genrelnotes</span><br><span>@@ -349,7 +349,7 @@</span><br><span> </span><br><span> get_log_dedupe "RISC-V" \</span><br><span> "$(for codedir in $(grep -rl "_RISCV" --include=Kconfig | grep -v 'payloads/\|drivers/\|vendorcode/\|console' ); do dirname "$codedir"; done | grep -v '^src$')" \</span><br><span style="color: hsl(0, 100%, 40%);">- "riscv\|risc-v\|lowrisc\|sifive"</span><br><span style="color: hsl(120, 100%, 40%);">+ "riscv\|risc-v\|sifive"</span><br><span> </span><br><span> get_log_dedupe "MIPS" \</span><br><span> "$(for codedir in $(grep -rl "_MIPS" --include=Kconfig | \</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28706">change 28706</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28706"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4e3e715106a1a94381a563dc4a56781c35883c2d </div>
<div style="display:none"> Gerrit-Change-Number: 28706 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>