<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28702">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">northbridge: Use 'unsigned int' to bare use of 'unsigned'<br><br>Change-Id: Ib70eb33fac654a773ea39a5fd4206435dffdabb7<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/northbridge/amd/amdfam10/raminit_amdmct.c<br>M src/northbridge/amd/lx/raminit.h<br>M src/northbridge/intel/e7505/northbridge.c<br>M src/northbridge/intel/e7505/raminit.h<br>M src/northbridge/intel/fsp_rangeley/northbridge.c<br>M src/northbridge/intel/fsp_sandybridge/gma.c<br>M src/northbridge/intel/fsp_sandybridge/northbridge.c<br>M src/northbridge/intel/gm45/gma.c<br>M src/northbridge/intel/haswell/gma.c<br>M src/northbridge/intel/haswell/minihd.c<br>M src/northbridge/intel/haswell/northbridge.c<br>M src/northbridge/intel/nehalem/gma.c<br>M src/northbridge/intel/nehalem/northbridge.c<br>M src/northbridge/intel/pineview/gma.c<br>M src/northbridge/intel/pineview/raminit.c<br>M src/northbridge/intel/sandybridge/gma.c<br>M src/northbridge/intel/sandybridge/northbridge.c<br>17 files changed, 29 insertions(+), 22 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/28702/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/amd/amdfam10/raminit_amdmct.c b/src/northbridge/amd/amdfam10/raminit_amdmct.c</span><br><span>index ef54de5..2843b92 100644</span><br><span>--- a/src/northbridge/amd/amdfam10/raminit_amdmct.c</span><br><span>+++ b/src/northbridge/amd/amdfam10/raminit_amdmct.c</span><br><span>@@ -32,7 +32,7 @@</span><br><span> </span><br><span> struct mem_controller;</span><br><span> extern void activate_spd_rom(const struct mem_controller *ctrl);</span><br><span style="color: hsl(0, 100%, 40%);">-extern int spd_read_byte(unsigned device, unsigned address);</span><br><span style="color: hsl(120, 100%, 40%);">+extern int spd_read_byte(unsigned int device, unsigned int address);</span><br><span> </span><br><span> void fam15h_switch_dct(uint32_t dev, uint8_t dct)</span><br><span> {</span><br><span>diff --git a/src/northbridge/amd/lx/raminit.h b/src/northbridge/amd/lx/raminit.h</span><br><span>index 3a5d571..d106862 100644</span><br><span>--- a/src/northbridge/amd/lx/raminit.h</span><br><span>+++ b/src/northbridge/amd/lx/raminit.h</span><br><span>@@ -30,6 +30,6 @@</span><br><span> void sdram_initialize(int controllers, const struct mem_controller *ctrl);</span><br><span> </span><br><span> /* mainboard specific */</span><br><span style="color: hsl(0, 100%, 40%);">-int spd_read_byte(unsigned device, unsigned address);</span><br><span style="color: hsl(120, 100%, 40%);">+int spd_read_byte(unsigned int device, unsigned int address);</span><br><span> </span><br><span> #endif</span><br><span>diff --git a/src/northbridge/intel/e7505/northbridge.c b/src/northbridge/intel/e7505/northbridge.c</span><br><span>index 6d351a3..b625a80 100644</span><br><span>--- a/src/northbridge/intel/e7505/northbridge.c</span><br><span>+++ b/src/northbridge/intel/e7505/northbridge.c</span><br><span>@@ -76,7 +76,7 @@</span><br><span> }</span><br><span> </span><br><span> static void intel_set_subsystem(struct device *dev,</span><br><span style="color: hsl(0, 100%, 40%);">-                             unsigned vendor, unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+                             unsigned int vendor, unsigned int device)</span><br><span> {</span><br><span>       pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>             ((device & 0xffff) << 16) | (vendor & 0xffff));</span><br><span>diff --git a/src/northbridge/intel/e7505/raminit.h b/src/northbridge/intel/e7505/raminit.h</span><br><span>index eae8935..1581b82 100644</span><br><span>--- a/src/northbridge/intel/e7505/raminit.h</span><br><span>+++ b/src/northbridge/intel/e7505/raminit.h</span><br><span>@@ -35,6 +35,6 @@</span><br><span> </span><br><span> </span><br><span> /* Mainboard exports this. */</span><br><span style="color: hsl(0, 100%, 40%);">-int spd_read_byte(unsigned device, unsigned address);</span><br><span style="color: hsl(120, 100%, 40%);">+int spd_read_byte(unsigned int device, unsigned int address);</span><br><span> </span><br><span> #endif /* RAMINIT_H */</span><br><span>diff --git a/src/northbridge/intel/fsp_rangeley/northbridge.c b/src/northbridge/intel/fsp_rangeley/northbridge.c</span><br><span>index 27153f8..72b2761 100644</span><br><span>--- a/src/northbridge/intel/fsp_rangeley/northbridge.c</span><br><span>+++ b/src/northbridge/intel/fsp_rangeley/northbridge.c</span><br><span>@@ -173,7 +173,8 @@</span><br><span>     pci_dev_set_resources(dev);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void intel_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void intel_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                           unsigned int device)</span><br><span> {</span><br><span>    if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>diff --git a/src/northbridge/intel/fsp_sandybridge/gma.c b/src/northbridge/intel/fsp_sandybridge/gma.c</span><br><span>index 2cfd1f3..cba5869 100644</span><br><span>--- a/src/northbridge/intel/fsp_sandybridge/gma.c</span><br><span>+++ b/src/northbridge/intel/fsp_sandybridge/gma.c</span><br><span>@@ -66,8 +66,8 @@</span><br><span>                gnvs_ptr->aslb = aslb;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void gma_set_subsystem(struct device *dev, unsigned vendor,</span><br><span style="color: hsl(0, 100%, 40%);">-                            unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void gma_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                              unsigned int device)</span><br><span> {</span><br><span>    if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>diff --git a/src/northbridge/intel/fsp_sandybridge/northbridge.c b/src/northbridge/intel/fsp_sandybridge/northbridge.c</span><br><span>index b192161..111c201 100644</span><br><span>--- a/src/northbridge/intel/fsp_sandybridge/northbridge.c</span><br><span>+++ b/src/northbridge/intel/fsp_sandybridge/northbridge.c</span><br><span>@@ -248,8 +248,8 @@</span><br><span>      }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void intel_set_subsystem(struct device *dev, unsigned vendor,</span><br><span style="color: hsl(0, 100%, 40%);">-                          unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void intel_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                            unsigned int device)</span><br><span> {</span><br><span>    if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c</span><br><span>index 5335fbb..b86e2b3 100644</span><br><span>--- a/src/northbridge/intel/gm45/gma.c</span><br><span>+++ b/src/northbridge/intel/gm45/gma.c</span><br><span>@@ -788,7 +788,8 @@</span><br><span>  intel_gma_restore_opregion();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void gma_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                           unsigned int device)</span><br><span> {</span><br><span>      if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c</span><br><span>index 8f60da4..efc9fa3 100644</span><br><span>--- a/src/northbridge/intel/haswell/gma.c</span><br><span>+++ b/src/northbridge/intel/haswell/gma.c</span><br><span>@@ -494,8 +494,8 @@</span><br><span>      intel_gma_restore_opregion();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void gma_set_subsystem(struct device *dev, unsigned vendor,</span><br><span style="color: hsl(0, 100%, 40%);">-                              unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void gma_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                              unsigned int device)</span><br><span> {</span><br><span>      if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>diff --git a/src/northbridge/intel/haswell/minihd.c b/src/northbridge/intel/haswell/minihd.c</span><br><span>index d8b4b66..52710bb 100644</span><br><span>--- a/src/northbridge/intel/haswell/minihd.c</span><br><span>+++ b/src/northbridge/intel/haswell/minihd.c</span><br><span>@@ -103,8 +103,8 @@</span><br><span>  }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void minihd_set_subsystem(struct device *dev, unsigned vendor,</span><br><span style="color: hsl(0, 100%, 40%);">-                          unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void minihd_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                           unsigned int device)</span><br><span> {</span><br><span>   if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c</span><br><span>index f61a478..0453246 100644</span><br><span>--- a/src/northbridge/intel/haswell/northbridge.c</span><br><span>+++ b/src/northbridge/intel/haswell/northbridge.c</span><br><span>@@ -408,8 +408,8 @@</span><br><span>      mc_add_dram_resources(dev, &index);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void intel_set_subsystem(struct device *dev, unsigned vendor,</span><br><span style="color: hsl(0, 100%, 40%);">-                            unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void intel_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                            unsigned int device)</span><br><span> {</span><br><span>    if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>diff --git a/src/northbridge/intel/nehalem/gma.c b/src/northbridge/intel/nehalem/gma.c</span><br><span>index 6e2d404..b89215d 100644</span><br><span>--- a/src/northbridge/intel/nehalem/gma.c</span><br><span>+++ b/src/northbridge/intel/nehalem/gma.c</span><br><span>@@ -623,7 +623,8 @@</span><br><span>      intel_gma_restore_opregion();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void gma_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                           unsigned int device)</span><br><span> {</span><br><span>      if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>diff --git a/src/northbridge/intel/nehalem/northbridge.c b/src/northbridge/intel/nehalem/northbridge.c</span><br><span>index 8f55e3c..4c6cdd4 100644</span><br><span>--- a/src/northbridge/intel/nehalem/northbridge.c</span><br><span>+++ b/src/northbridge/intel/nehalem/northbridge.c</span><br><span>@@ -191,7 +191,8 @@</span><br><span>      pci_dev_set_resources(dev);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void intel_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void intel_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                           unsigned int device)</span><br><span> {</span><br><span>    if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>diff --git a/src/northbridge/intel/pineview/gma.c b/src/northbridge/intel/pineview/gma.c</span><br><span>index 02100e9..eb67c65 100644</span><br><span>--- a/src/northbridge/intel/pineview/gma.c</span><br><span>+++ b/src/northbridge/intel/pineview/gma.c</span><br><span>@@ -304,7 +304,8 @@</span><br><span>  intel_gma_restore_opregion();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void gma_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                           unsigned int device)</span><br><span> {</span><br><span>      if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c</span><br><span>index a050e06..5adf865 100644</span><br><span>--- a/src/northbridge/intel/pineview/raminit.c</span><br><span>+++ b/src/northbridge/intel/pineview/raminit.c</span><br><span>@@ -102,7 +102,7 @@</span><br><span>   __asm__ __volatile__("": : :"memory");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static inline int spd_read_byte(unsigned device, unsigned address)</span><br><span style="color: hsl(120, 100%, 40%);">+static inline int spd_read_byte(unsigned int device, unsigned int address)</span><br><span> {</span><br><span>      return smbus_read_byte(device, address);</span><br><span> }</span><br><span>diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c</span><br><span>index 042c2a9..cd8f7b9 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/gma.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/gma.c</span><br><span>@@ -669,7 +669,8 @@</span><br><span>         intel_gma_restore_opregion();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void gma_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                           unsigned int device)</span><br><span> {</span><br><span>      if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c</span><br><span>index 7863810..cb0e5db 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/northbridge.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/northbridge.c</span><br><span>@@ -287,7 +287,8 @@</span><br><span>      }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void intel_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void intel_set_subsystem(struct device *dev, unsigned int vendor,</span><br><span style="color: hsl(120, 100%, 40%);">+                             unsigned int device)</span><br><span> {</span><br><span>    if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28702">change 28702</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28702"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib70eb33fac654a773ea39a5fd4206435dffdabb7 </div>
<div style="display:none"> Gerrit-Change-Number: 28702 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>