<p><a href="https://review.coreboot.org/28608">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28608/1/src/soc/amd/stoneyridge/cpu.c">File src/soc/amd/stoneyridge/cpu.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28608/1/src/soc/amd/stoneyridge/cpu.c@123">Patch Set #1, Line 123:</a> <code style="font-family:monospace,monospace"> setup_lapic();</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It'd be nice to comment properly what's really needed. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes, I did tested it against S3 cycle and reboot. It's write once, it survives reboot and S3 cycle. Original Marshall's code caused errors both ways, reboot and S3 cycle. Once I added the protection, problem was gone. Also I tried without the code and using iotools to write it once... then it survived reboot and S3 cycle. Only S5 clears it!</p><p style="white-space: pre-wrap; word-wrap: break-word;">Will add the comment.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28608">change 28608</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28608"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I30027d3b0a6fbd540375e96001beb9c25bf3a678 </div>
<div style="display:none"> Gerrit-Change-Number: 28608 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall@amd.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 18 Sep 2018 20:48:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>