<p><a href="https://review.coreboot.org/28618">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28618/5/util/inteltool/inteltool.h">File util/inteltool/inteltool.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28618/5/util/inteltool/inteltool.h@144">Patch Set #5, Line 144:</a> <code style="font-family:monospace,monospace">PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP       </code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">0x9d58 should be KabyLake. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yep, that PCI ID is the LPC controller of 7 series (Kabylake) PCH-U Premium. See https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/7th-gen-core-family-mobile-u-y-processor-lines-i-o-datasheet-vol-1.pdf page 23 vs. https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/6th-gen-core-pch-u-y-io-datasheet-vol-1.pdf page 28. Would be good if you'd add support for those different SKUs</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28618">change 28618</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28618"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2454cc11d83a860815bfaab5197c25b29f3384df </div>
<div style="display:none"> Gerrit-Change-Number: 28618 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Daniel Maslowski <info@orangecms.org> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Maslowski <info@orangecms.org> </div>
<div style="display:none"> Gerrit-Reviewer: Johanna Schander <coreboot@mimoja.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 16 Sep 2018 10:36:22 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>