<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28628">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/lenovo/t400: Link the gpio.c settings<br><br>Linking this file instead of including a header makes it possible to easily<br>change gpio settings for a variant.<br><br>Change-Id: Ifd496510d4868f5901a9dbbf7f1523ccffaf15ab<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/mainboard/lenovo/t400/Makefile.inc<br>R src/mainboard/lenovo/t400/gpio.c<br>M src/mainboard/lenovo/t400/romstage.c<br>3 files changed, 5 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/28628/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/lenovo/t400/Makefile.inc b/src/mainboard/lenovo/t400/Makefile.inc</span><br><span>index 62e27d3..7721e03 100644</span><br><span>--- a/src/mainboard/lenovo/t400/Makefile.inc</span><br><span>+++ b/src/mainboard/lenovo/t400/Makefile.inc</span><br><span>@@ -13,6 +13,7 @@</span><br><span> ## GNU General Public License for more details.</span><br><span> ##</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+romstage-y += gpio.c</span><br><span> romstage-y += dock.c</span><br><span> </span><br><span> ramstage-y += dock.c</span><br><span>diff --git a/src/mainboard/lenovo/t400/gpio.h b/src/mainboard/lenovo/t400/gpio.c</span><br><span>similarity index 96%</span><br><span>rename from src/mainboard/lenovo/t400/gpio.h</span><br><span>rename to src/mainboard/lenovo/t400/gpio.c</span><br><span>index 261c912..ef340f2 100644</span><br><span>--- a/src/mainboard/lenovo/t400/gpio.h</span><br><span>+++ b/src/mainboard/lenovo/t400/gpio.c</span><br><span>@@ -11,9 +11,6 @@</span><br><span>  * GNU General Public License for more details.</span><br><span>  */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#ifndef LENOVO_T400_GPIO_H</span><br><span style="color: hsl(0, 100%, 40%);">-#define LENOVO_T400_GPIO_H</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #include <southbridge/intel/common/gpio.h></span><br><span> </span><br><span> static const struct pch_gpio_set1 pch_gpio_set1_mode = {</span><br><span>@@ -115,7 +112,7 @@</span><br><span>  .gpio49 = GPIO_LEVEL_HIGH,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-const struct pch_gpio_map t400_gpio_map = {</span><br><span style="color: hsl(120, 100%, 40%);">+const struct pch_gpio_map mainboard_gpio_map = {</span><br><span>    .set1 = {</span><br><span>            .mode      = &pch_gpio_set1_mode,</span><br><span>                .direction = &pch_gpio_set1_direction,</span><br><span>@@ -129,5 +126,3 @@</span><br><span>             .level     = &pch_gpio_set2_level,</span><br><span>       },</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span>diff --git a/src/mainboard/lenovo/t400/romstage.c b/src/mainboard/lenovo/t400/romstage.c</span><br><span>index 1974ab6..c66dacb 100644</span><br><span>--- a/src/mainboard/lenovo/t400/romstage.c</span><br><span>+++ b/src/mainboard/lenovo/t400/romstage.c</span><br><span>@@ -27,12 +27,12 @@</span><br><span> #include <lib.h></span><br><span> #include <romstage_handoff.h></span><br><span> #include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <southbridge/intel/i82801ix/i82801ix.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <southbridge/intel/i82801ix/i82801ix.h</span><br><span style="color: hsl(120, 100%, 40%);">+#include <southbridge/intel/common/gpio.h></span><br><span> #include <northbridge/intel/gm45/gm45.h></span><br><span> #include <drivers/lenovo/hybrid_graphics/hybrid_graphics.h></span><br><span> #include <timestamp.h></span><br><span> #include "dock.h"</span><br><span style="color: hsl(0, 100%, 40%);">-#include "gpio.h"</span><br><span> </span><br><span> #define LPC_DEV PCI_DEV(0, 0x1f, 0)</span><br><span> #define MCH_DEV PCI_DEV(0, 0, 0)</span><br><span>@@ -93,7 +93,7 @@</span><br><span>             gm45_early_reset();</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   setup_pch_gpios(&t400_gpio_map);</span><br><span style="color: hsl(120, 100%, 40%);">+  setup_pch_gpios(&mainboard_gpio_map);</span><br><span> </span><br><span>        /* ASPM related setting, set early by original BIOS. */</span><br><span>      DMIBAR16(0x204) &= ~(3 << 10);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28628">change 28628</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28628"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ifd496510d4868f5901a9dbbf7f1523ccffaf15ab </div>
<div style="display:none"> Gerrit-Change-Number: 28628 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>