<p><a href="https://review.coreboot.org/28569">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28569/4/src/arch/riscv/pmp.c">File src/arch/riscv/pmp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28569/4/src/arch/riscv/pmp.c@24">Patch Set #4, Line 24:</a> <code style="font-family:monospace,monospace">/* </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28569/4/src/arch/riscv/pmp.c@32">Patch Set #4, Line 32:</a> <code style="font-family:monospace,monospace">         * When generating a TOR type configuration,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28569/4/src/arch/riscv/pmp.c@34">Patch Set #4, Line 34:</a> <code style="font-family:monospace,monospace">        * used to record the value of pmpaddr[i - 1] </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28569/4/src/arch/riscv/pmp.c@35">Patch Set #4, Line 35:</a> <code style="font-family:monospace,monospace">         */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28569">change 28569</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28569"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2e9e0c94e6518f63ade7680a3ce68bacfae219d4 </div>
<div style="display:none"> Gerrit-Change-Number: 28569 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Xiang Wang <wxjstz@126.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Hug <philipp@hug.cx> </div>
<div style="display:none"> Gerrit-Reviewer: Shawn Chang <citypw@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 11 Sep 2018 14:23:18 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>