<p>Jose S. Cofreros Jr. has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28547">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Enabled USB Power on Leaf Hill CRB.<br><br>1) Enabled USB Power on Leaf Hill CRB to use keyboard and<br> mouse. Verified on Windows 10 Pro 10.0.17134 Build 17134.<br>2) Modified the following documentation that is blocking<br> the original intent of this commit.<br> - Verify that the word 'coreboot' is lowercase<br> (lint-stable-021-coreboot-lowercase)<br> - Documentation/Intel/SoC/quark.html<br> - Documentation/Intel/SoC/soc.html<br> - Documentation/Intel/development.html<br> - Documentation/Intel/index.html<br><br>Change-Id: I808d48789506123d544647ef3eefc0ea064d89a2<br>Signed-off-by: Jose S. Cofreros Jr <josh.cofreros@gmail.com><br>---<br>M Documentation/Intel/SoC/quark.html<br>M Documentation/Intel/SoC/soc.html<br>M Documentation/Intel/development.html<br>M Documentation/Intel/index.html<br>M src/mainboard/intel/leafhill/brd_gpio.h<br>5 files changed, 31 insertions(+), 26 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/28547/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Documentation/Intel/SoC/quark.html b/Documentation/Intel/SoC/quark.html</span><br><span>index c3eead2..1575c07 100644</span><br><span>--- a/Documentation/Intel/SoC/quark.html</span><br><span>+++ b/Documentation/Intel/SoC/quark.html</span><br><span>@@ -19,7 +19,7 @@</span><br><span> <li><a target="_blank" href="../fsp1_1.html">FSP 1.1</a> integration</li></span><br><span> <li><a target="_blank" href="../Board/board.html">Board</a> support</li></span><br><span> <li><a target="_blank" href="#QuarkFsp">Quark™ FSP</a></li></span><br><span style="color: hsl(0, 100%, 40%);">- <li><a target="_blank" href="#CorebootPayloadPkg">CorebootPayloadPkg</a></li></span><br><span style="color: hsl(120, 100%, 40%);">+ <li><a target="_blank" href="#corebootPayloadPkg">corebootPayloadPkg</a></li></span><br><span> </ul></span><br><span> </td></span><br><span> </tr></span><br><span>@@ -49,23 +49,23 @@</span><br><span> </span><br><span> </span><br><span> <hr></span><br><span style="color: hsl(0, 100%, 40%);">-<h2><a name="CorebootPayloadPkg">Quark™ EDK2 CorebootPayloadPkg</a></h2></span><br><span style="color: hsl(120, 100%, 40%);">+<h2><a name="corebootPayloadPkg">Quark™ EDK2 corebootPayloadPkg</a></h2></span><br><span> <p></span><br><span> Build Instructions:</span><br><span> </p></span><br><span> <ol></span><br><span> <li>Set up <a href="#BuildEnvironment">build environment</a></li></span><br><span> <li>Linux (assumes GCC48):</span><br><span style="color: hsl(0, 100%, 40%);">-<pre><code>build -p CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc -a IA32 \</span><br><span style="color: hsl(120, 100%, 40%);">+<pre><code>build -p corebootPayloadPkg/corebootPayloadPkgIa32.dsc -a IA32 \</span><br><span> -t GCC48 -b DEBUG -DDEBUG_PROPERTY_MASK=0x27 \</span><br><span> -DDEBUG_PRINT_ERROR_LEVEL=0x80000042 -DSHELL_TYPE=BUILD_SHELL \</span><br><span> -DMAX_LOGICAL_PROCESSORS=1</span><br><span style="color: hsl(0, 100%, 40%);">-ls Build/CorebootPayloadPkgIA32/DEBUG_GCC48/FV/UEFIPAYLOAD.fd</span><br><span style="color: hsl(120, 100%, 40%);">+ls Build/corebootPayloadPkgIA32/DEBUG_GCC48/FV/UEFIPAYLOAD.fd</span><br><span> </code></pre></span><br><span> </li></span><br><span> <li>Windows (assumes Visual Studio 2015):</span><br><span style="color: hsl(0, 100%, 40%);">-<pre><code>build -p CorebootPayloadPkg\CorebootPayloadPkgIa32.dsc -a IA32 -t VS2015x86 -b DEBUG -DDEBUG_PROPERTY_MASK=0x27 -DDEBUG_PRINT_ERROR_LEVEL=0x80000042 -DSHELL_TYPE=BUILD_SHELL -DMAX_LOGICAL_PROCESSORS=1</span><br><span style="color: hsl(0, 100%, 40%);">-dir Build\CorebootPayloadPkgIA32\DEBUG_VS2015x86\FV\UEFIPAYLOAD.fd</span><br><span style="color: hsl(120, 100%, 40%);">+<pre><code>build -p corebootPayloadPkg\corebootPayloadPkgIa32.dsc -a IA32 -t VS2015x86 -b DEBUG -DDEBUG_PROPERTY_MASK=0x27 -DDEBUG_PRINT_ERROR_LEVEL=0x80000042 -DSHELL_TYPE=BUILD_SHELL -DMAX_LOGICAL_PROCESSORS=1</span><br><span style="color: hsl(120, 100%, 40%);">+dir Build\corebootPayloadPkgIA32\DEBUG_VS2015x86\FV\UEFIPAYLOAD.fd</span><br><span> </code></pre></span><br><span> </li></span><br><span> <li>In the .config for coreboot, set the following Kconfig values:</span><br><span>diff --git a/Documentation/Intel/SoC/soc.html b/Documentation/Intel/SoC/soc.html</span><br><span>index 29b819e..a796b85 100644</span><br><span>--- a/Documentation/Intel/SoC/soc.html</span><br><span>+++ b/Documentation/Intel/SoC/soc.html</span><br><span>@@ -572,18 +572,18 @@</span><br><span> <hr></span><br><span> <h2><a name="AcpiTables">ACPI Tables</a></h2></span><br><span> <p></span><br><span style="color: hsl(0, 100%, 40%);">- One of the payloads that needs ACPI tables is the EDK2 <a target="_blank" href="quark.html#CorebootPayloadPkg">CorebootPayloadPkg</a>.</span><br><span style="color: hsl(120, 100%, 40%);">+ One of the payloads that needs ACPI tables is the EDK2 <a target="_blank" href="quark.html#corebootPayloadPkg">corebootPayloadPkg</a>.</span><br><span> </p></span><br><span> </span><br><span> <h3>FADT</h3></span><br><span> <p></span><br><span> The EDK2 module</span><br><span style="color: hsl(0, 100%, 40%);">- CorebootModulePkg/Library/CbParseLib/<a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootModulePkg/Library/CbParseLib/CbParseLib.c#l450">CbParseLib.c</a></span><br><span style="color: hsl(120, 100%, 40%);">+ corebootModulePkg/Library/CbParseLib/<a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootModulePkg/Library/CbParseLib/CbParseLib.c#l450">CbParseLib.c</a></span><br><span> requires that the FADT contains the values in the table below.</span><br><span> These values are placed into a HOB identified by</span><br><span style="color: hsl(0, 100%, 40%);">- <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootModulePkg/CorebootModulePkg.dec#l36">gUefiAcpiBoardInfoGuid</a></span><br><span style="color: hsl(120, 100%, 40%);">+ <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootModulePkg/corebootModulePkg.dec#l36">gUefiAcpiBoardInfoGuid</a></span><br><span> by routine</span><br><span style="color: hsl(0, 100%, 40%);">- CorebootModulePkg/CbSupportPei/CbSupportPei/<a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootModulePkg/CbSupportPei/CbSupportPei.c#l364">CbPeiEntryPoint</a>.</span><br><span style="color: hsl(120, 100%, 40%);">+ corebootModulePkg/CbSupportPei/CbSupportPei/<a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootModulePkg/CbSupportPei/CbSupportPei.c#l364">CbPeiEntryPoint</a>.</span><br><span> </p></span><br><span> <table border="1"></span><br><span> <tr bgcolor="#c0ffc0"></span><br><span>@@ -600,9 +600,9 @@</span><br><span> <td>gpe0_blk<br>gpe0_blk_len</td></span><br><span> <td>Gpe0Blk<br>Gpe0BlkLen</td></span><br><span> <td></span><br><span style="color: hsl(0, 100%, 40%);">- <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootModulePkg/Library/CbParseLib/CbParseLib.c#l477">PmGpeEnBase</a></span><br><span style="color: hsl(120, 100%, 40%);">+ <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootModulePkg/Library/CbParseLib/CbParseLib.c#l477">PmGpeEnBase</a></span><br><span> </td></span><br><span style="color: hsl(0, 100%, 40%);">- <td><a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l129">Shutdown</a></td></span><br><span style="color: hsl(120, 100%, 40%);">+ <td><a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l129">Shutdown</a></td></span><br><span> <td>4.8.4.1</td></span><br><span> </tr></span><br><span> <tr></span><br><span>@@ -610,8 +610,8 @@</span><br><span> <td>Pm1aCntBlk</td></span><br><span> <td>PmCtrlRegBase</td></span><br><span> <td></span><br><span style="color: hsl(0, 100%, 40%);">- <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l139">Shutdown</a><br></span><br><span style="color: hsl(0, 100%, 40%);">- <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l40">Suspend</a></span><br><span style="color: hsl(120, 100%, 40%);">+ <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l139">Shutdown</a><br></span><br><span style="color: hsl(120, 100%, 40%);">+ <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l40">Suspend</a></span><br><span> </td></span><br><span> <td>4.8.3.2.1</td></span><br><span> </tr></span><br><span>@@ -619,7 +619,7 @@</span><br><span> <td>pm1a_evt_blk</td></span><br><span> <td>Pm1aEvtBlk</td></span><br><span> <td>PmEvtBase</td></span><br><span style="color: hsl(0, 100%, 40%);">- <td><a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l134">Shutdown</a></td></span><br><span style="color: hsl(120, 100%, 40%);">+ <td><a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l134">Shutdown</a></td></span><br><span> <td>4.8.3.1.1</td></span><br><span> </tr></span><br><span> <tr></span><br><span>@@ -627,7 +627,7 @@</span><br><span> <td>PmTmrBlk</td></span><br><span> <td>PmTimerRegBase</td></span><br><span> <td></span><br><span style="color: hsl(0, 100%, 40%);">- <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.c#l55">Timer</a></span><br><span style="color: hsl(120, 100%, 40%);">+ <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.c#l55">Timer</a></span><br><span> </td></span><br><span> <td>4.8.3.3</td></span><br><span> </tr></span><br><span>@@ -636,9 +636,9 @@</span><br><span> <td>ResetReg.Address</td></span><br><span> <td>ResetRegAddress</td></span><br><span> <td></span><br><span style="color: hsl(0, 100%, 40%);">- <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l71">Cold</a></span><br><span style="color: hsl(120, 100%, 40%);">+ <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l71">Cold</a></span><br><span> and</span><br><span style="color: hsl(0, 100%, 40%);">- <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l98">Warm</a></span><br><span style="color: hsl(120, 100%, 40%);">+ <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l98">Warm</a></span><br><span> resets</span><br><span> </td></span><br><span> <td>4.3.3.6</td></span><br><span>@@ -648,9 +648,9 @@</span><br><span> <td>ResetValue</td></span><br><span> <td>ResetValue</td></span><br><span> <td></span><br><span style="color: hsl(0, 100%, 40%);">- <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l71">Cold</a></span><br><span style="color: hsl(120, 100%, 40%);">+ <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l71">Cold</a></span><br><span> and</span><br><span style="color: hsl(0, 100%, 40%);">- <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l98">Warm</a></span><br><span style="color: hsl(120, 100%, 40%);">+ <a target="_blank" href="https://github.com/tianocore/edk2/blob/master/corebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c#l98">Warm</a></span><br><span> resets</span><br><span> </td></span><br><span> <td>4.8.3.6</td></span><br><span>@@ -680,7 +680,7 @@</span><br><span> <hr></span><br><span> <h2><a name="LegacyHardware">Legacy Hardware</a></h2></span><br><span> <p></span><br><span style="color: hsl(0, 100%, 40%);">- One of the payloads that needs legacy hardare is the EDK2 <a target="_blank" href="quark.html#CorebootPayloadPkg">CorebootPayloadPkg</a>.</span><br><span style="color: hsl(120, 100%, 40%);">+ One of the payloads that needs legacy hardare is the EDK2 <a target="_blank" href="quark.html#corebootPayloadPkg">corebootPayloadPkg</a>.</span><br><span> </p></span><br><span> </span><br><span> <table border="1"></span><br><span>diff --git a/Documentation/Intel/development.html b/Documentation/Intel/development.html</span><br><span>index 24b2fa9..08617c9 100644</span><br><span>--- a/Documentation/Intel/development.html</span><br><span>+++ b/Documentation/Intel/development.html</span><br><span>@@ -150,12 +150,12 @@</span><br><span> <tr></span><br><span> <td>8254 Programmable Interval Timer</td></span><br><span> <td><a target="_blank" href="SoC/soc.html#LegacyHardware">Legacy hardware</a> support</td></span><br><span style="color: hsl(0, 100%, 40%);">- <td><a target="_blank" href="SoC/quark.html#CorebootPayloadPkg">CorebootPayloadPkg</a> gets to shell prompt</td></span><br><span style="color: hsl(120, 100%, 40%);">+ <td><a target="_blank" href="SoC/quark.html#corebootPayloadPkg">corebootPayloadPkg</a> gets to shell prompt</td></span><br><span> </tr></span><br><span> <tr></span><br><span> <td>8259 Programmable Interrupt Controller</td></span><br><span> <td><a target="_blank" href="SoC/soc.html#LegacyHardware">Legacy hardware</a> support</td></span><br><span style="color: hsl(0, 100%, 40%);">- <td><a target="_blank" href="SoC/quark.html#CorebootPayloadPkg">CorebootPayloadPkg</a> gets to shell prompt</td></span><br><span style="color: hsl(120, 100%, 40%);">+ <td><a target="_blank" href="SoC/quark.html#corebootPayloadPkg">corebootPayloadPkg</a> gets to shell prompt</td></span><br><span> </tr></span><br><span> <tr></span><br><span> <td>Cache-as-RAM</td></span><br><span>@@ -374,4 +374,4 @@</span><br><span> <hr></span><br><span> <p>Modified: 4 March 2016</p></span><br><span> </body></span><br><span style="color: hsl(0, 100%, 40%);">-</html></span><br><span>\ No newline at end of file</span><br><span style="color: hsl(120, 100%, 40%);">+</html></span><br><span>diff --git a/Documentation/Intel/index.html b/Documentation/Intel/index.html</span><br><span>index b4daa96..d5f32a4 100644</span><br><span>--- a/Documentation/Intel/index.html</span><br><span>+++ b/Documentation/Intel/index.html</span><br><span>@@ -10,7 +10,7 @@</span><br><span> <h2>Intel® x86 Boards</h2></span><br><span> <ul></span><br><span> <li><a target="_blank" href="Board/galileo.html">Galileo</a></li></span><br><span style="color: hsl(0, 100%, 40%);">- <li><a target="_blank" href="http://wiki.minnowboard.org/Coreboot">MinnowBoard MAX</a></li></span><br><span style="color: hsl(120, 100%, 40%);">+ <li><a target="_blank" href="http://wiki.minnowboard.org/coreboot">MinnowBoard MAX</a></li></span><br><span> </ul></span><br><span> </span><br><span> <h2>Intel® x86 SoCs</h2></span><br><span>@@ -37,7 +37,7 @@</span><br><span> <hr></span><br><span> <h2>Payload Development</h2></span><br><span> <ul></span><br><span style="color: hsl(0, 100%, 40%);">- <li><a target="_blank" href="SoC/quark.html#CorebootPayloadPkg">CorebootPayloadPkg</a></span><br><span style="color: hsl(120, 100%, 40%);">+ <li><a target="_blank" href="SoC/quark.html#corebootPayloadPkg">corebootPayloadPkg</a></span><br><span> <ul></span><br><span> <li><a target="_blank" href="https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process">EDK II Development Process</a></li></span><br><span> <li>EDK II <a target="_blank" href="https://github.com/tianocore/tianocore.github.io/wiki/EDK%20II%20White%20papers">White Papers</a></li></span><br><span>diff --git a/src/mainboard/intel/leafhill/brd_gpio.h b/src/mainboard/intel/leafhill/brd_gpio.h</span><br><span>index 18d130b..ca99f11 100644</span><br><span>--- a/src/mainboard/intel/leafhill/brd_gpio.h</span><br><span>+++ b/src/mainboard/intel/leafhill/brd_gpio.h</span><br><span>@@ -46,4 +46,9 @@</span><br><span> </span><br><span> PAD_CFG_NF(SMB_CLK, NATIVE, DEEP, NF1),</span><br><span> PAD_CFG_NF(SMB_DATA, NATIVE, DEEP, NF1),</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef CONFIG_BOARD_INTEL_LEAFHILL</span><br><span style="color: hsl(120, 100%, 40%);">+ /// Added feature to enable USB power for USB devices, specifically keyboard and mouse.</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_23, 1, DEEP, DN_20K, TxLASTRxE, SAME), /// Feature: LB USB Power in LFH</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> };</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28547">change 28547</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28547"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I808d48789506123d544647ef3eefc0ea064d89a2 </div>
<div style="display:none"> Gerrit-Change-Number: 28547 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jose S. Cofreros Jr. <josh.cofreros@gmail.com> </div>