<p>Evgeny Zinoviev has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28565">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/board_status: Add support of CMOS values dump<br><br>Change-Id: I89f9a0e9622557b01dda52378f8f1323777bce39<br>Signed-off-by: Evgeny Zinoviev <me@ch1p.com><br>---<br>M util/board_status/board_status.sh<br>1 file changed, 47 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/28565/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh</span><br><span>index 13c58e1..132056d 100755</span><br><span>--- a/util/board_status/board_status.sh</span><br><span>+++ b/util/board_status/board_status.sh</span><br><span>@@ -27,6 +27,9 @@</span><br><span> # Used if cbmem is not in default $PATH, e.g. not installed or when using `sudo`</span><br><span> CBMEM_PATH=""</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+# Used if nvramtool is not in default $PATH, e.g. not installed or when using `sudo`</span><br><span style="color: hsl(120, 100%, 40%);">+NVRAMTOOL_PATH=""</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> # test a command</span><br><span> #</span><br><span> # $1: 0 ($LOCAL) to run command locally,</span><br><span>@@ -176,6 +179,8 @@</span><br><span> Options</span><br><span>     -c, --cbmem</span><br><span>         Path to cbmem on device under test (DUT).</span><br><span style="color: hsl(120, 100%, 40%);">+    -n, --nvramtool</span><br><span style="color: hsl(120, 100%, 40%);">+        Path to nvramtool on device under test (DUT).</span><br><span>     -C, --clobber</span><br><span>         Clobber temporary output when finished. Useful for debugging.</span><br><span>     -h, --help</span><br><span>@@ -207,7 +212,7 @@</span><br><span> LONGOPTS="${LONGOPTS},serial-device:,serial-speed:"</span><br><span> LONGOPTS="${LONGOPTS},ssh-port:"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-ARGS=$(getopt -o c:Chi:r:s:S:u -l "$LONGOPTS" -n "$0" -- "$@");</span><br><span style="color: hsl(120, 100%, 40%);">+ARGS=$(getopt -o c:n:Chi:r:s:S:u -l "$LONGOPTS" -n "$0" -- "$@");</span><br><span> if [ $? != 0 ] ; then echo "Terminating..." >&2 ; exit 1 ; fi</span><br><span> eval set -- "$ARGS"</span><br><span> while true ; do</span><br><span>@@ -217,6 +222,10 @@</span><br><span>                         shift</span><br><span>                        CBMEM_PATH="$1"</span><br><span>                    ;;</span><br><span style="color: hsl(120, 100%, 40%);">+            -n|--nvramtool)</span><br><span style="color: hsl(120, 100%, 40%);">+                       shift</span><br><span style="color: hsl(120, 100%, 40%);">+                 NVRAMTOOL_PATH="$1"</span><br><span style="color: hsl(120, 100%, 40%);">+                 ;;</span><br><span>           -C|--clobber)</span><br><span>                        CLOBBER_OUTPUT=1</span><br><span>                     ;;</span><br><span>@@ -370,6 +379,17 @@</span><br><span>    cbmem_cmd="cbmem"</span><br><span> fi</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+cmos_enabled=0</span><br><span style="color: hsl(120, 100%, 40%);">+if grep -q "CONFIG_USE_OPTION_TABLE=y" "${tmpdir}/${results}/config.short.txt" > /dev/null; then</span><br><span style="color: hsl(120, 100%, 40%);">+        cmos_enabled=1</span><br><span style="color: hsl(120, 100%, 40%);">+fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+if [ -n "$NVRAMTOOL_PATH" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+     nvramtool_cmd="$NVRAMTOOL_PATH"</span><br><span style="color: hsl(120, 100%, 40%);">+else</span><br><span style="color: hsl(120, 100%, 40%);">+       nvramtool_cmd="nvramtool"</span><br><span style="color: hsl(120, 100%, 40%);">+fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if [ -n "$SERIAL_DEVICE" ]; then</span><br><span>      get_serial_bootlog "$SERIAL_DEVICE" "$SERIAL_PORT_SPEED" "${tmpdir}/${results}/coreboot_console.txt"</span><br><span> elif [ -n "$REMOTE_HOST" ]; then</span><br><span>@@ -380,6 +400,13 @@</span><br><span>      echo "Getting timestamp data"</span><br><span>      cmd_nonfatal $REMOTE "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   if [ "$cmos_enabled" -eq 1 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+          echo "Verifying that nvramtool is available on remote device"</span><br><span style="color: hsl(120, 100%, 40%);">+               test_cmd $REMOTE "$nvramtool_cmd"</span><br><span style="color: hsl(120, 100%, 40%);">+           echo "Getting all CMOS values"</span><br><span style="color: hsl(120, 100%, 40%);">+              cmd $REMOTE "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt"</span><br><span style="color: hsl(120, 100%, 40%);">+    fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         echo "Getting remote dmesg"</span><br><span>        cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt"</span><br><span> else</span><br><span>@@ -402,6 +429,25 @@</span><br><span>     echo "Getting timestamp data"</span><br><span>      cmd_nonfatal $LOCAL "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    if [ "$cmos_enabled" -eq 1 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+          echo "Verifying that nvramtool is available"</span><br><span style="color: hsl(120, 100%, 40%);">+                if [ $(id -u) -ne 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+                   command -v "$nvramtool_cmd" >/dev/null</span><br><span style="color: hsl(120, 100%, 40%);">+                   if [ $? -ne 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+                         echo "Failed to run $nvramtool_cmd. Check \$PATH or" \</span><br><span style="color: hsl(120, 100%, 40%);">+                              "use -n to specify path to nvramtool binary."</span><br><span style="color: hsl(120, 100%, 40%);">+                               exit $EXIT_FAILURE</span><br><span style="color: hsl(120, 100%, 40%);">+                    else</span><br><span style="color: hsl(120, 100%, 40%);">+                          nvramtool_cmd="sudo $nvramtool_cmd"</span><br><span style="color: hsl(120, 100%, 40%);">+                 fi</span><br><span style="color: hsl(120, 100%, 40%);">+            else</span><br><span style="color: hsl(120, 100%, 40%);">+                  test_cmd $LOCAL "$nvramtool_cmd"</span><br><span style="color: hsl(120, 100%, 40%);">+            fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+          echo "Getting all CMOS values"</span><br><span style="color: hsl(120, 100%, 40%);">+              cmd $LOCAL "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt"</span><br><span style="color: hsl(120, 100%, 40%);">+     fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         echo "Getting local dmesg"</span><br><span>         cmd $LOCAL dmesg "${tmpdir}/${results}/kernel_log.txt"</span><br><span> fi</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28565">change 28565</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28565"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I89f9a0e9622557b01dda52378f8f1323777bce39 </div>
<div style="display:none"> Gerrit-Change-Number: 28565 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> </div>