<p>Patrick Georgi has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28532">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboards: Add SMMSTORE region in chromeos configs<br><br>Only for those that are x86 and also have a RW_LEGACY region.<br>The assumption is that all devices touched have 64k block sizes when<br>choosing size and alignment of the region.<br><br>Change-Id: I12addb137604f003d1296f34f555dae219330b18<br>Signed-off-by: Patrick Georgi <pgeorgi@google.com><br>---<br>M src/mainboard/google/auron/chromeos.fmd<br>M src/mainboard/google/beltino/chromeos.fmd<br>M src/mainboard/google/butterfly/chromeos.fmd<br>M src/mainboard/google/cyan/chromeos.fmd<br>M src/mainboard/google/eve/chromeos.fmd<br>M src/mainboard/google/fizz/chromeos.fmd<br>M src/mainboard/google/glados/chromeos.fmd<br>M src/mainboard/google/jecht/chromeos.fmd<br>M src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd<br>M src/mainboard/google/kukui/chromeos.fmd<br>M src/mainboard/google/link/chromeos.fmd<br>M src/mainboard/google/octopus/chromeos.fmd<br>M src/mainboard/google/parrot/chromeos.fmd<br>M src/mainboard/google/poppy/chromeos.fmd<br>M src/mainboard/google/rambi/chromeos.fmd<br>M src/mainboard/google/reef/chromeos.fmd<br>M src/mainboard/google/slippy/chromeos.fmd<br>M src/mainboard/google/stout/chromeos.fmd<br>M src/mainboard/google/zoombini/chromeos.fmd<br>M src/mainboard/intel/cannonlake_rvp/chromeos.fmd<br>M src/mainboard/intel/coffeelake_rvp/chromeos.fmd<br>M src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd<br>M src/mainboard/intel/galileo/vboot.fmd<br>M src/mainboard/intel/glkrvp/chromeos.fmd<br>M src/mainboard/intel/kblrvp/chromeos.fmd<br>M src/mainboard/intel/kunimitsu/chromeos.fmd<br>M src/mainboard/intel/strago/chromeos.fmd<br>27 files changed, 54 insertions(+), 27 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/28532/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/auron/chromeos.fmd b/src/mainboard/google/auron/chromeos.fmd</span><br><span>index 0c05ce9..215247f 100644</span><br><span>--- a/src/mainboard/google/auron/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/auron/chromeos.fmd</span><br><span>@@ -22,7 +22,8 @@</span><br><span> }</span><br><span> RW_VPD@0x1f8000 0x2000</span><br><span> RW_UNUSED@0x1fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/beltino/chromeos.fmd b/src/mainboard/google/beltino/chromeos.fmd</span><br><span>index 0c05ce9..215247f 100644</span><br><span>--- a/src/mainboard/google/beltino/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/beltino/chromeos.fmd</span><br><span>@@ -22,7 +22,8 @@</span><br><span> }</span><br><span> RW_VPD@0x1f8000 0x2000</span><br><span> RW_UNUSED@0x1fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/butterfly/chromeos.fmd b/src/mainboard/google/butterfly/chromeos.fmd</span><br><span>index 0071533..14c91d7 100644</span><br><span>--- a/src/mainboard/google/butterfly/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/butterfly/chromeos.fmd</span><br><span>@@ -23,7 +23,8 @@</span><br><span> RW_ENVIRONMENT@0x1f8000 0x4000</span><br><span> RW_VPD@0x1fc000 0x2000</span><br><span> RW_UNUSED@0x1fe000 0x2000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/cyan/chromeos.fmd b/src/mainboard/google/cyan/chromeos.fmd</span><br><span>index 0c05ce9..215247f 100644</span><br><span>--- a/src/mainboard/google/cyan/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/cyan/chromeos.fmd</span><br><span>@@ -22,7 +22,8 @@</span><br><span> }</span><br><span> RW_VPD@0x1f8000 0x2000</span><br><span> RW_UNUSED@0x1fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/eve/chromeos.fmd b/src/mainboard/google/eve/chromeos.fmd</span><br><span>index bdadcf7..145fc7b 100644</span><br><span>--- a/src/mainboard/google/eve/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/eve/chromeos.fmd</span><br><span>@@ -27,7 +27,8 @@</span><br><span> RW_VPD@0x28000 0x2000</span><br><span> RW_NVRAM@0x2a000 0x6000</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x800000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x800000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x840000 0x1c0000</span><br><span> WP_RO@0xa00000 0x400000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/fizz/chromeos.fmd b/src/mainboard/google/fizz/chromeos.fmd</span><br><span>index bdadcf7..145fc7b 100644</span><br><span>--- a/src/mainboard/google/fizz/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/fizz/chromeos.fmd</span><br><span>@@ -27,7 +27,8 @@</span><br><span> RW_VPD@0x28000 0x2000</span><br><span> RW_NVRAM@0x2a000 0x6000</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x800000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x800000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x840000 0x1c0000</span><br><span> WP_RO@0xa00000 0x400000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/glados/chromeos.fmd b/src/mainboard/google/glados/chromeos.fmd</span><br><span>index 58b6127..78c6ab1 100644</span><br><span>--- a/src/mainboard/google/glados/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/glados/chromeos.fmd</span><br><span>@@ -22,7 +22,8 @@</span><br><span> }</span><br><span> RW_VPD@0x7f8000 0x2000</span><br><span> RW_NVRAM@0x7fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x800000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x800000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x840000 0x1c0000</span><br><span> WP_RO@0xa00000 0x400000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/jecht/chromeos.fmd b/src/mainboard/google/jecht/chromeos.fmd</span><br><span>index 0c05ce9..215247f 100644</span><br><span>--- a/src/mainboard/google/jecht/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/jecht/chromeos.fmd</span><br><span>@@ -22,7 +22,8 @@</span><br><span> }</span><br><span> RW_VPD@0x1f8000 0x2000</span><br><span> RW_UNUSED@0x1fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd b/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd</span><br><span>index 336aced..f84ed01 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd</span><br><span>@@ -24,7 +24,8 @@</span><br><span> RW_VPD@0x465000 0x2000</span><br><span> RW_NVRAM@0x467000 0x5000</span><br><span> RW_UNUSED@0x46C000 0x14000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY@0x480000 0x780000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x480000 0x20000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY@0x4a0000 0x760000</span><br><span> </span><br><span> WP_RO@0xC00000 0x400000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span>diff --git a/src/mainboard/google/kukui/chromeos.fmd b/src/mainboard/google/kukui/chromeos.fmd</span><br><span>index a521b0c..1602f80 100644</span><br><span>--- a/src/mainboard/google/kukui/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/kukui/chromeos.fmd</span><br><span>@@ -25,5 +25,6 @@</span><br><span> RW_FWID_B@0x77f00 0x100</span><br><span> }</span><br><span> RW_VPD@0x2f8000 0x8000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x300000 0x100000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x300000 0x20000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x320000 0xe0000</span><br><span> }</span><br><span>diff --git a/src/mainboard/google/link/chromeos.fmd b/src/mainboard/google/link/chromeos.fmd</span><br><span>index 113fba6..8a06dc2 100644</span><br><span>--- a/src/mainboard/google/link/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/link/chromeos.fmd</span><br><span>@@ -22,7 +22,8 @@</span><br><span> }</span><br><span> RW_VPD@0x1f8000 0x2000</span><br><span> RW_UNUSED@0x1fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/octopus/chromeos.fmd b/src/mainboard/google/octopus/chromeos.fmd</span><br><span>index 5572930..f601adc 100644</span><br><span>--- a/src/mainboard/google/octopus/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/octopus/chromeos.fmd</span><br><span>@@ -36,7 +36,8 @@</span><br><span> FW_MAIN_B(CBFS)@0x10000 0x46ffc0</span><br><span> RW_FWID_B@0x47ffc0 0x40</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0xd30000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0xd30000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0xd70000 0x1c0000</span><br><span> BIOS_UNUSABLE@0xf30000 0x4f000</span><br><span> DEVICE_EXTENSION@0xf7f000 0x80000</span><br><span> # Currently, it is required that the BIOS region be a multiple of 8KiB.</span><br><span>diff --git a/src/mainboard/google/parrot/chromeos.fmd b/src/mainboard/google/parrot/chromeos.fmd</span><br><span>index 524399b..5f98229 100644</span><br><span>--- a/src/mainboard/google/parrot/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/parrot/chromeos.fmd</span><br><span>@@ -23,7 +23,8 @@</span><br><span> RW_ENVIRONMENT@0x1f8000 0x4000</span><br><span> RW_VPD@0x1fc000 0x2000</span><br><span> RW_UNUSED@0x1fe000 0x2000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/poppy/chromeos.fmd b/src/mainboard/google/poppy/chromeos.fmd</span><br><span>index bdadcf7..145fc7b 100644</span><br><span>--- a/src/mainboard/google/poppy/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/poppy/chromeos.fmd</span><br><span>@@ -27,7 +27,8 @@</span><br><span> RW_VPD@0x28000 0x2000</span><br><span> RW_NVRAM@0x2a000 0x6000</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x800000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x800000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x840000 0x1c0000</span><br><span> WP_RO@0xa00000 0x400000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/rambi/chromeos.fmd b/src/mainboard/google/rambi/chromeos.fmd</span><br><span>index 0c05ce9..215247f 100644</span><br><span>--- a/src/mainboard/google/rambi/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/rambi/chromeos.fmd</span><br><span>@@ -22,7 +22,8 @@</span><br><span> }</span><br><span> RW_VPD@0x1f8000 0x2000</span><br><span> RW_UNUSED@0x1fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/reef/chromeos.fmd b/src/mainboard/google/reef/chromeos.fmd</span><br><span>index e5cda78..768d322 100644</span><br><span>--- a/src/mainboard/google/reef/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/reef/chromeos.fmd</span><br><span>@@ -37,7 +37,8 @@</span><br><span> FW_MAIN_B(CBFS)@0x10000 0x46ffc0</span><br><span> RW_FWID_B@0x47ffc0 0x40</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0xd30000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0xd30000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0xd70000 0x1c0000</span><br><span> BIOS_UNUSABLE@0xf30000 0x4f000</span><br><span> DEVICE_EXTENSION@0xf7f000 0x80000</span><br><span> # Currently, it is required that the BIOS region be a multiple of 8KiB.</span><br><span>diff --git a/src/mainboard/google/slippy/chromeos.fmd b/src/mainboard/google/slippy/chromeos.fmd</span><br><span>index 0c05ce9..215247f 100644</span><br><span>--- a/src/mainboard/google/slippy/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/slippy/chromeos.fmd</span><br><span>@@ -22,7 +22,8 @@</span><br><span> }</span><br><span> RW_VPD@0x1f8000 0x2000</span><br><span> RW_UNUSED@0x1fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/stout/chromeos.fmd b/src/mainboard/google/stout/chromeos.fmd</span><br><span>index 0071533..14c91d7 100644</span><br><span>--- a/src/mainboard/google/stout/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/stout/chromeos.fmd</span><br><span>@@ -23,7 +23,8 @@</span><br><span> RW_ENVIRONMENT@0x1f8000 0x4000</span><br><span> RW_VPD@0x1fc000 0x2000</span><br><span> RW_UNUSED@0x1fe000 0x2000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/google/zoombini/chromeos.fmd b/src/mainboard/google/zoombini/chromeos.fmd</span><br><span>index 4e23bbf..7123a5f 100644</span><br><span>--- a/src/mainboard/google/zoombini/chromeos.fmd</span><br><span>+++ b/src/mainboard/google/zoombini/chromeos.fmd</span><br><span>@@ -27,7 +27,8 @@</span><br><span> RW_VPD@0x28000 0x2000</span><br><span> RW_NVRAM@0x2a000 0x6000</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x700000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x700000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x740000 0x1c0000</span><br><span> WP_RO@0x900000 0x400000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/intel/cannonlake_rvp/chromeos.fmd b/src/mainboard/intel/cannonlake_rvp/chromeos.fmd</span><br><span>index cca80ab..65d22c3 100644</span><br><span>--- a/src/mainboard/intel/cannonlake_rvp/chromeos.fmd</span><br><span>+++ b/src/mainboard/intel/cannonlake_rvp/chromeos.fmd</span><br><span>@@ -28,7 +28,8 @@</span><br><span> RW_VPD@0x28000 0x2000</span><br><span> RW_NVRAM@0x2a000 0x6000</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x700000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x700000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x740000 0x1c0000</span><br><span> WP_RO@0x900000 0x380000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/intel/coffeelake_rvp/chromeos.fmd b/src/mainboard/intel/coffeelake_rvp/chromeos.fmd</span><br><span>index cca80ab..65d22c3 100644</span><br><span>--- a/src/mainboard/intel/coffeelake_rvp/chromeos.fmd</span><br><span>+++ b/src/mainboard/intel/coffeelake_rvp/chromeos.fmd</span><br><span>@@ -28,7 +28,8 @@</span><br><span> RW_VPD@0x28000 0x2000</span><br><span> RW_NVRAM@0x2a000 0x6000</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x700000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x700000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x740000 0x1c0000</span><br><span> WP_RO@0x900000 0x380000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd b/src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd</span><br><span>index be6bfc0..bfbd304 100644</span><br><span>--- a/src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd</span><br><span>+++ b/src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd</span><br><span>@@ -28,7 +28,8 @@</span><br><span> RW_VPD@0x28000 0x2000</span><br><span> RW_NVRAM@0x2a000 0x6000</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x5d0000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x5d0000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x610000 0x1c0000</span><br><span> WP_RO@0x7d0000 0x430000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_SECTION@0x4000 0x42c000 {</span><br><span>diff --git a/src/mainboard/intel/galileo/vboot.fmd b/src/mainboard/intel/galileo/vboot.fmd</span><br><span>index 55e41e56..efc4a75 100644</span><br><span>--- a/src/mainboard/intel/galileo/vboot.fmd</span><br><span>+++ b/src/mainboard/intel/galileo/vboot.fmd</span><br><span>@@ -36,7 +36,8 @@</span><br><span> }</span><br><span> RW_VPD@0x1f8000 0x2000</span><br><span> RW_NVRAM@0x1fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/intel/glkrvp/chromeos.fmd b/src/mainboard/intel/glkrvp/chromeos.fmd</span><br><span>index 84808ab..e513f7c 100644</span><br><span>--- a/src/mainboard/intel/glkrvp/chromeos.fmd</span><br><span>+++ b/src/mainboard/intel/glkrvp/chromeos.fmd</span><br><span>@@ -38,7 +38,8 @@</span><br><span> RW_FWID_B@0x4777c0 0x40</span><br><span> }</span><br><span> RW_NVRAM@0xd39000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0xd3f000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0xd40000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0xd80000 0x1b0000</span><br><span> BIOS_UNUSABLE@0xf3f000 0x40000</span><br><span> DEVICE_EXTENSION@0xf7f000 0x80000</span><br><span> # Currently, it is required that the BIOS region be a multiple of 8KiB.</span><br><span>diff --git a/src/mainboard/intel/kblrvp/chromeos.fmd b/src/mainboard/intel/kblrvp/chromeos.fmd</span><br><span>index 58b6127..78c6ab1 100644</span><br><span>--- a/src/mainboard/intel/kblrvp/chromeos.fmd</span><br><span>+++ b/src/mainboard/intel/kblrvp/chromeos.fmd</span><br><span>@@ -22,7 +22,8 @@</span><br><span> }</span><br><span> RW_VPD@0x7f8000 0x2000</span><br><span> RW_NVRAM@0x7fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x800000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x800000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x840000 0x1c0000</span><br><span> WP_RO@0xa00000 0x400000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/intel/kunimitsu/chromeos.fmd b/src/mainboard/intel/kunimitsu/chromeos.fmd</span><br><span>index 58b6127..78c6ab1 100644</span><br><span>--- a/src/mainboard/intel/kunimitsu/chromeos.fmd</span><br><span>+++ b/src/mainboard/intel/kunimitsu/chromeos.fmd</span><br><span>@@ -22,7 +22,8 @@</span><br><span> }</span><br><span> RW_VPD@0x7f8000 0x2000</span><br><span> RW_NVRAM@0x7fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x800000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x800000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x840000 0x1c0000</span><br><span> WP_RO@0xa00000 0x400000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span>diff --git a/src/mainboard/intel/strago/chromeos.fmd b/src/mainboard/intel/strago/chromeos.fmd</span><br><span>index 0c05ce9..215247f 100644</span><br><span>--- a/src/mainboard/intel/strago/chromeos.fmd</span><br><span>+++ b/src/mainboard/intel/strago/chromeos.fmd</span><br><span>@@ -22,7 +22,8 @@</span><br><span> }</span><br><span> RW_VPD@0x1f8000 0x2000</span><br><span> RW_UNUSED@0x1fa000 0x6000</span><br><span style="color: hsl(0, 100%, 40%);">- RW_LEGACY(CBFS)@0x200000 0x200000</span><br><span style="color: hsl(120, 100%, 40%);">+ SMMSTORE@0x200000 0x40000</span><br><span style="color: hsl(120, 100%, 40%);">+ RW_LEGACY(CBFS)@0x240000 0x1c0000</span><br><span> WP_RO@0x400000 0x200000 {</span><br><span> RO_VPD@0x0 0x4000</span><br><span> RO_UNUSED@0x4000 0xc000</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28532">change 28532</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28532"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I12addb137604f003d1296f34f555dae219330b18 </div>
<div style="display:none"> Gerrit-Change-Number: 28532 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> </div>