<p><a href="https://review.coreboot.org/28480">View Change</a></p><p>150 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c">File src/soc/amd/stoneyridge/bertdump.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@46">Patch Set #3, Line 46:</a> <code style="font-family:monospace,monospace">static const char *acpi_severity[] = {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">static const char * array should probably be static const char * const</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@65">Patch Set #3, Line 65:</a> <code style="font-family:monospace,monospace"> printk(0, " e * Invalid bits %llx\n", check & ~valid);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@67">Patch Set #3, Line 67:</a> <code style="font-family:monospace,monospace"> printk(0, " e Transaction Type = %llx %s\n", check & X86_PROC_CHK_XACT_MASK >> X86_PROC_CHK_XACT_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@67">Patch Set #3, Line 67:</a> <code style="font-family:monospace,monospace"> printk(0, " e Transaction Type = %llx %s\n", check & X86_PROC_CHK_XACT_MASK >> X86_PROC_CHK_XACT_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Possible precedence defect with mask then right shift - may need parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@68">Patch Set #3, Line 68:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_XACT_MASK ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@70">Patch Set #3, Line 70:</a> <code style="font-family:monospace,monospace"> printk(0, " e Operation = %llx %s\n", check & X86_PROC_CHK_OPER_MASK >> X86_PROC_CHK_OPER_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@70">Patch Set #3, Line 70:</a> <code style="font-family:monospace,monospace"> printk(0, " e Operation = %llx %s\n", check & X86_PROC_CHK_OPER_MASK >> X86_PROC_CHK_OPER_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Possible precedence defect with mask then right shift - may need parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@71">Patch Set #3, Line 71:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_OPERATION_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@73">Patch Set #3, Line 73:</a> <code style="font-family:monospace,monospace"> printk(0, " e Cache Level = %llx %s\n", check & X86_PROC_CHK_LEVEL_MASK >> X86_PROC_CHK_LEVEL_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@73">Patch Set #3, Line 73:</a> <code style="font-family:monospace,monospace"> printk(0, " e Cache Level = %llx %s\n", check & X86_PROC_CHK_LEVEL_MASK >> X86_PROC_CHK_LEVEL_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Possible precedence defect with mask then right shift - may need parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@74">Patch Set #3, Line 74:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_LEVEL_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@76">Patch Set #3, Line 76:</a> <code style="font-family:monospace,monospace"> printk(0, " e Context Corrupt = %x %s\n", !!(check & X86_PROC_CHK_CTX_CORRUPT),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@77">Patch Set #3, Line 77:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_CONTEXT_CORPT_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@79">Patch Set #3, Line 79:</a> <code style="font-family:monospace,monospace"> printk(0, " e Uncorrected = %x %s\n", !!(check & X86_PROC_CHK_UNCORRECTED),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@80">Patch Set #3, Line 80:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_UNCORRECTED_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@82">Patch Set #3, Line 82:</a> <code style="font-family:monospace,monospace"> printk(0, " e Precise IP = %x %s\n", !!(check & X86_PROC_CHK_PRECISE_IP),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@83">Patch Set #3, Line 83:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_PRECISE_IP_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@85">Patch Set #3, Line 85:</a> <code style="font-family:monospace,monospace"> printk(0, " e Restartable IP = %x %s\n", !!(check & X86_PROC_CHK_RESTARTABLE_IP),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@86">Patch Set #3, Line 86:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_RESTARTABLE_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@88">Patch Set #3, Line 88:</a> <code style="font-family:monospace,monospace"> printk(0, " e Overflow = %x %s\n", !!(check & X86_PROC_CHK_OVERFLOW),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@89">Patch Set #3, Line 89:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_OVERFLOW_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@91">Patch Set #3, Line 91:</a> <code style="font-family:monospace,monospace"> printk(0, " e Participation Type = %llx %s\n", check & X86_PROC_CHK_PARTIC_MASK >> X86_PROC_CHK_PARTIC_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@91">Patch Set #3, Line 91:</a> <code style="font-family:monospace,monospace"> printk(0, " e Participation Type = %llx %s\n", check & X86_PROC_CHK_PARTIC_MASK >> X86_PROC_CHK_PARTIC_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Possible precedence defect with mask then right shift - may need parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@92">Patch Set #3, Line 92:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_PART_TYPE_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@94">Patch Set #3, Line 94:</a> <code style="font-family:monospace,monospace"> printk(0, " e Time Out = %x %s\n", !!(check & X86_PROC_CHK_OVERFLOW),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@95">Patch Set #3, Line 95:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_TIMEOUT ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@97">Patch Set #3, Line 97:</a> <code style="font-family:monospace,monospace"> printk(0, " e Address Space = %llx %s\n", check & X86_PROC_CHK_PARTIC_MASK >> X86_PROC_CHK_PARTIC_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@97">Patch Set #3, Line 97:</a> <code style="font-family:monospace,monospace"> printk(0, " e Address Space = %llx %s\n", check & X86_PROC_CHK_PARTIC_MASK >> X86_PROC_CHK_PARTIC_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Possible precedence defect with mask then right shift - may need parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@98">Patch Set #3, Line 98:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_ADDR_SPACE_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@104">Patch Set #3, Line 104:</a> <code style="font-family:monospace,monospace"> printk(0, " e * Invalid bits %llx\n", check & ~valid);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@106">Patch Set #3, Line 106:</a> <code style="font-family:monospace,monospace"> printk(0, " e Transaction Type = %llx %s\n", check & X86_PROC_MS_CHK_XACT_MASK >> X86_PROC_MS_CHK_XACT_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@106">Patch Set #3, Line 106:</a> <code style="font-family:monospace,monospace"> printk(0, " e Transaction Type = %llx %s\n", check & X86_PROC_MS_CHK_XACT_MASK >> X86_PROC_MS_CHK_XACT_SH,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Possible precedence defect with mask then right shift - may need parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@107">Patch Set #3, Line 107:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_XACT_MASK ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@109">Patch Set #3, Line 109:</a> <code style="font-family:monospace,monospace"> printk(0, " e Uncorrected = %x %s\n", !!(check & X86_PROC_MS_CHK_UNCORRECTED),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@110">Patch Set #3, Line 110:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_UNCORRECTED_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@112">Patch Set #3, Line 112:</a> <code style="font-family:monospace,monospace"> printk(0, " e Precise IP = %x %s\n", !!(check & X86_PROC_MS_CHK_PRECISE_IP),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@113">Patch Set #3, Line 113:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_PRECISE_IP_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@115">Patch Set #3, Line 115:</a> <code style="font-family:monospace,monospace"> printk(0, " e Restartable IP = %x %s\n", !!(check & X86_PROC_MS_CHK_RESTARTABLE_IP),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@116">Patch Set #3, Line 116:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_RESTARTABLE_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@118">Patch Set #3, Line 118:</a> <code style="font-family:monospace,monospace"> printk(0, " e Overflow = %x %s\n", !!(check & X86_PROC_MS_CHK_OVERFLOW),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@119">Patch Set #3, Line 119:</a> <code style="font-family:monospace,monospace"> check & X86_PROC_CHK_OVERFLOW_VALID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@122">Patch Set #3, Line 122:</a> <code style="font-family:monospace,monospace">static const char *check_guid_names[] = {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">static const char * array should probably be static const char * const</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@147">Patch Set #3, Line 147:</a> <code style="font-family:monospace,monospace"> printk(0, " ___ CPER IA32/x64 Processor Error (Check) Information @0x%p - 0x%p (size 0x%zx) ___\n", err, err + 1, sizeof(*err));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@148">Patch Set #3, Line 148:</a> <code style="font-family:monospace,monospace"> printk(0, " e Structure Type GUID = %s\n", check_guid_name(err->type));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@151">Patch Set #3, Line 151:</a> <code style="font-family:monospace,monospace"> printk(0, " e Validation Bits = %llx\n", err->validation);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@153">Patch Set #3, Line 153:</a> <code style="font-family:monospace,monospace"> x86_chkprint_with_valid(err->check_info, X86_PROC_CHK_XACT_TYPE_VALID | X86_PROC_CHK_OPERATION_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@154">Patch Set #3, Line 154:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_LEVEL_VALID | X86_PROC_CHK_CONTEXT_CORPT_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@155">Patch Set #3, Line 155:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_UNCORRECTED_VALID | X86_PROC_CHK_PRECISE_IP_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@156">Patch Set #3, Line 156:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_RESTARTABLE_VALID | X86_PROC_CHK_OVERFLOW_VALID);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@158">Patch Set #3, Line 158:</a> <code style="font-family:monospace,monospace"> x86_chkprint_with_valid(err->check_info, X86_PROC_CHK_XACT_TYPE_VALID | X86_PROC_CHK_OPERATION_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@159">Patch Set #3, Line 159:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_LEVEL_VALID | X86_PROC_CHK_CONTEXT_CORPT_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@160">Patch Set #3, Line 160:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_UNCORRECTED_VALID | X86_PROC_CHK_PRECISE_IP_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@161">Patch Set #3, Line 161:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_RESTARTABLE_VALID | X86_PROC_CHK_OVERFLOW_VALID);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@163">Patch Set #3, Line 163:</a> <code style="font-family:monospace,monospace"> x86_chkprint_with_valid(err->check_info, X86_PROC_CHK_XACT_TYPE_VALID | X86_PROC_CHK_OPERATION_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@164">Patch Set #3, Line 164:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_LEVEL_VALID | X86_PROC_CHK_CONTEXT_CORPT_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@165">Patch Set #3, Line 165:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_UNCORRECTED_VALID | X86_PROC_CHK_PRECISE_IP_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@166">Patch Set #3, Line 166:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_RESTARTABLE_VALID | X86_PROC_CHK_OVERFLOW_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@167">Patch Set #3, Line 167:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_PART_TYPE_VALID | X86_PROC_CHK_TIMEOUT_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@168">Patch Set #3, Line 168:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_ADDR_SPACE_VALID);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@170">Patch Set #3, Line 170:</a> <code style="font-family:monospace,monospace"> x86_mschkprint_with_valid(err->check_info, X86_PROC_CHK_XACT_TYPE_VALID | X86_PROC_CHK_OPERATION_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@171">Patch Set #3, Line 171:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_LEVEL_VALID | X86_PROC_CHK_CONTEXT_CORPT_VALID</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@172">Patch Set #3, Line 172:</a> <code style="font-family:monospace,monospace"> | X86_PROC_CHK_UNCORRECTED_VALID | X86_PROC_CHK_PRECISE_IP_VALID);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@179">Patch Set #3, Line 179:</a> <code style="font-family:monospace,monospace">static const char *context_names[] = {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">static const char * array should probably be static const char * const</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@210">Patch Set #3, Line 210:</a> <code style="font-family:monospace,monospace"> printk(0, " ___ CPER IA32/x64 Processor Context Information @0x%p - 0x%p (size 0x%zx) ___\n", ctx,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@211">Patch Set #3, Line 211:</a> <code style="font-family:monospace,monospace"> (u8 *)ctx + ALIGN_UP(sizeof(*ctx) + ctx->array_size, 16),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@212">Patch Set #3, Line 212:</a> <code style="font-family:monospace,monospace"> ALIGN_UP(sizeof(*ctx) + ctx->array_size, 16));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@213">Patch Set #3, Line 213:</a> <code style="font-family:monospace,monospace"> printk(0, " t Context Type = %x %s\n", ctx->type, context_name(ctx->type));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@214">Patch Set #3, Line 214:</a> <code style="font-family:monospace,monospace"> printk(0, " t Array Size = %x\n", ctx->array_size);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@216">Patch Set #3, Line 216:</a> <code style="font-family:monospace,monospace"> printk(0, " t MM Address = %llx\n", ctx->mmap_addr);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@224">Patch Set #3, Line 224:</a> <code style="font-family:monospace,monospace"> printk(0, " t %08x_%08x\n", (u32)(*(array + i) >> 32), (u32)*(array + i));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@233">Patch Set #3, Line 233:</a> <code style="font-family:monospace,monospace"> int errs = (ia32->validation & I32X64SEC_VALID_ERRNUM_MASK) >> I32X64SEC_VALID_ERRNUM_SH;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@234">Patch Set #3, Line 234:</a> <code style="font-family:monospace,monospace"> int ctxs = (ia32->validation & I32X64SEC_VALID_CTXNUM_MASK) >> I32X64SEC_VALID_CTXNUM_SH;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@236">Patch Set #3, Line 236:</a> <code style="font-family:monospace,monospace"> printk(0, " ___ CPER IA32/x64 Processor Error @0x%p sizeof(proc error section struct) is 0x%zx/%zd) ___\n", ia32, sizeof(*ia32), sizeof(*ia32));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@237">Patch Set #3, Line 237:</a> <code style="font-family:monospace,monospace"> printk(0, " x Validation Bits = %llx\n", ia32->validation);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@240">Patch Set #3, Line 240:</a> <code style="font-family:monospace,monospace"> printk(0, " x Processor APIC ID = %llx %s\n", ia32->apicid, ia32->validation & I32X64SEC_VALID_LAPIC ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@241">Patch Set #3, Line 241:</a> <code style="font-family:monospace,monospace"> printk(0, " x Processor CPUID = EAX = %x %s\n", (u32)ia32->cpuid[0], ia32->validation & I32X64SEC_VALID_CPUID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@242">Patch Set #3, Line 242:</a> <code style="font-family:monospace,monospace"> printk(0, " x EBX = %x\n", (u32)ia32->cpuid[1]);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@243">Patch Set #3, Line 243:</a> <code style="font-family:monospace,monospace"> printk(0, " x ECX = %x\n", (u32)ia32->cpuid[2]);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@244">Patch Set #3, Line 244:</a> <code style="font-family:monospace,monospace"> printk(0, " x EDX = %x\n", (u32)ia32->cpuid[3]);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@248">Patch Set #3, Line 248:</a> <code style="font-family:monospace,monospace"> adder += parse_x86_error_info((cper_ia32x64_proc_error_info_t *)((u8 *)ia32 + adder));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@251">Patch Set #3, Line 251:</a> <code style="font-family:monospace,monospace"> adder += parse_x86_context_info((cper_ia32x64_context_t *)((u8 *)ia32 + adder));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@256">Patch Set #3, Line 256:</a> <code style="font-family:monospace,monospace">static size_t parse_cper_structure_generic(cper_proc_generic_error_section_t *gen)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@258">Patch Set #3, Line 258:</a> <code style="font-family:monospace,monospace"> printk(0, " ___ CPER Generic Processor Error @0x%p sizeof(generic error struct) is 0x%zx/%zd\n", gen, sizeof(*gen), sizeof(*gen));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@259">Patch Set #3, Line 259:</a> <code style="font-family:monospace,monospace"> printk(0, " c Validation Bits = %llx\n", gen->validation);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@260">Patch Set #3, Line 260:</a> <code style="font-family:monospace,monospace"> printk(0, " c Processor Type = %x %s\n", gen->proc_type, gen->validation & GENPROC_VALID_PROC_TYPE ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@261">Patch Set #3, Line 261:</a> <code style="font-family:monospace,monospace"> printk(0, " c Processor ISA = %x %s\n", gen->proc_isa, gen->validation & GENPROC_VALID_PROC_ISA ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@262">Patch Set #3, Line 262:</a> <code style="font-family:monospace,monospace"> printk(0, " c Processor Error Type = %x %s\n", gen->error_type, gen->validation & GENPROC_VALID_PROC_ERR_TYPE ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@263">Patch Set #3, Line 263:</a> <code style="font-family:monospace,monospace"> printk(0, " c Operation = %x %s\n", gen->operation, gen->validation & GENPROC_VALID_OPERATION ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@264">Patch Set #3, Line 264:</a> <code style="font-family:monospace,monospace"> printk(0, " c Flags = %x %s\n", gen->flags, gen->validation & GENPROC_VALID_FLAGS ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@265">Patch Set #3, Line 265:</a> <code style="font-family:monospace,monospace"> printk(0, " c Level = %x %s\n", gen->level, gen->validation & GENPROC_VALID_LEVEL ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@266">Patch Set #3, Line 266:</a> <code style="font-family:monospace,monospace"> printk(0, " c CPU Version Info = %llx %s\n", gen->cpu_version, gen->validation & GENPROC_VALID_CPU_VERSION ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@267">Patch Set #3, Line 267:</a> <code style="font-family:monospace,monospace"> printk(0, " c CPU Brand String = %s %s\n", gen->cpu_brand_string, gen->validation & GENPROC_VALID_CPU_BRAND ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@268">Patch Set #3, Line 268:</a> <code style="font-family:monospace,monospace"> printk(0, " c Processor ID = %llx %s\n", gen->proc_id, gen->validation & GENPROC_VALID_CPU_ID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@269">Patch Set #3, Line 269:</a> <code style="font-family:monospace,monospace"> printk(0, " c Target Address = %llx %s\n", gen->target_addr, gen->validation & GENPROC_VALID_TGT_ADDR ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@270">Patch Set #3, Line 270:</a> <code style="font-family:monospace,monospace"> printk(0, " c Requestor Identifier = %llx %s\n", gen->requestor_id, gen->validation & GENPROC_VALID_REQR_ID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@271">Patch Set #3, Line 271:</a> <code style="font-family:monospace,monospace"> printk(0, " c Responder Identifier = %llx %s\n", gen->responder_id, gen->validation & GENPROC_VALID_RSPR_ID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@272">Patch Set #3, Line 272:</a> <code style="font-family:monospace,monospace"> printk(0, " c Instruction IP = %llx %s\n", gen->instruction_ip, gen->validation & GENPROC_VALID_INSTR_IP ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@296">Patch Set #3, Line 296:</a> <code style="font-family:monospace,monospace"> return sizeof(acpi_hest_generic_data_v300_t) + entry->data_length;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@301">Patch Set #3, Line 301:</a> <code style="font-family:monospace,monospace">static const char *guids382[] = {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">static const char * array should probably be static const char * const</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@319">Patch Set #3, Line 319:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_PROC_GENERIC_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@321">Patch Set #3, Line 321:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_PROC_IA32X64_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@323">Patch Set #3, Line 323:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_PROC_ARM_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@325">Patch Set #3, Line 325:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_PLATFORM_MEM_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@327">Patch Set #3, Line 327:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_PLATFORM_MEM2_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@329">Patch Set #3, Line 329:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_PCIE_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@331">Patch Set #3, Line 331:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_FW_ERR_REC_REF_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@333">Patch Set #3, Line 333:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_PCI_X_BUS_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@335">Patch Set #3, Line 335:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_PCI_DEV_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@337">Patch Set #3, Line 337:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_DMAR_GENERIC_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@339">Patch Set #3, Line 339:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_DMAR_VT_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@341">Patch Set #3, Line 341:</a> <code style="font-family:monospace,monospace"> if(!guidcmp(&guid, &CPER_SEC_DMAR_IOMMU_GUID))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@351">Patch Set #3, Line 351:</a> <code style="font-family:monospace,monospace"> printk(0, " ___ 382 found @0x%p sizeof(%s) = 0x%zx/%zd ___\n", entry, entry->revision == 0x300 ? "v3" : "old-type",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@352">Patch Set #3, Line 352:</a> <code style="font-family:monospace,monospace"> entry->revision == 0x300 ? sizeof(acpi_hest_generic_data_v300_t) : sizeof(acpi_hest_generic_data_t),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@353">Patch Set #3, Line 353:</a> <code style="font-family:monospace,monospace"> entry->revision == 0x300 ? sizeof(acpi_hest_generic_data_v300_t) : sizeof(acpi_hest_generic_data_t));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@354">Patch Set #3, Line 354:</a> <code style="font-family:monospace,monospace"> printk(0, " 3 Section Type GUID = %s\n", guid382_name(entry->section_type));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@357">Patch Set #3, Line 357:</a> <code style="font-family:monospace,monospace"> printk(0, " 3 Severity = %x: %s\n", entry->error_severity, acpi_sev(entry->error_severity));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@358">Patch Set #3, Line 358:</a> <code style="font-family:monospace,monospace"> printk(0, " 3 Revision = %x\n", entry->revision);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@359">Patch Set #3, Line 359:</a> <code style="font-family:monospace,monospace"> printk(0, " 3 Validation = %x\n", entry->validation_bits);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@361">Patch Set #3, Line 361:</a> <code style="font-family:monospace,monospace"> printk(0, " 3 Error Data Length = %x\n", entry->data_length);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@362">Patch Set #3, Line 362:</a> <code style="font-family:monospace,monospace"> printk(0, " 3 FRU ID = <todo> %s\n", entry->validation_bits & ACPI_GENERROR_VALID_FRUID ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@363">Patch Set #3, Line 363:</a> <code style="font-family:monospace,monospace"> printk(0, " 3 FRU text = <todo> %s\n", entry->validation_bits & ACPI_GENERROR_VALID_FRUID_TEXT ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@365">Patch Set #3, Line 365:</a> <code style="font-family:monospace,monospace"> /* I can cheat on x300 because I know only diff is timestamp */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@370">Patch Set #3, Line 370:</a> <code style="font-family:monospace,monospace"> entry->timestamp.hour, entry->timestamp.min, entry->timestamp.sec,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@371">Patch Set #3, Line 371:</a> <code style="font-family:monospace,monospace"> entry->validation_bits & ACPI_GENERROR_VALID_TIMESTAMP ? "V" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@375">Patch Set #3, Line 375:</a> <code style="font-family:monospace,monospace"> /* each table-382 entry should contain 0 or 1 cper structure at its end */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@378">Patch Set #3, Line 378:</a> <code style="font-family:monospace,monospace"> parse_cper_structure((void *)(entry + 1), entry->section_type);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@380">Patch Set #3, Line 380:</a> <code style="font-family:monospace,monospace"> parse_cper_structure((void *)((u8 *)entry + sizeof(acpi_hest_generic_data_t)), entry->section_type);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@384">Patch Set #3, Line 384:</a> <code style="font-family:monospace,monospace"> entry = (acpi_hest_generic_data_v300_t *)((u8 *)entry + entry382_size(entry));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@400">Patch Set #3, Line 400:</a> <code style="font-family:monospace,monospace">static acpi_hest_generic_data_v300_t *ptr382_from_bert_entry(acpi_generic_error_status_t *bert_data)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@403">Patch Set #3, Line 403:</a> <code style="font-family:monospace,monospace"> return (acpi_hest_generic_data_v300_t *)((u8 *)bert_data + sizeof(*bert_data));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@429">Patch Set #3, Line 429:</a> <code style="font-family:monospace,monospace"> printk(0, "***** BERT storage at 0x%p - 0x%p (%zd) *****\n", bert_base, (u8 *)bert_base + size, size);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@431">Patch Set #3, Line 431:</a> <code style="font-family:monospace,monospace"> while(offset < size) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@432">Patch Set #3, Line 432:</a> <code style="font-family:monospace,monospace"> entries = (bert_data->block_status & GENERIC_ERR_STS_ENTRY_COUNT_MASK) >> GENERIC_ERR_STS_ENTRY_COUNT_SHIFT;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@433">Patch Set #3, Line 433:</a> <code style="font-family:monospace,monospace"> printk(0, " ___ BERT entry @0x%p - (sizeof(status)=0x%zx/%zd) ___\n", bert_data, sizeof(*bert_data), sizeof(*bert_data));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@434">Patch Set #3, Line 434:</a> <code style="font-family:monospace,monospace"> printk(0, " b Block Status = %x\n", bert_data->block_status);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@436">Patch Set #3, Line 436:</a> <code style="font-family:monospace,monospace"> bert_data->block_status & BIT(0) ? " uncorrectable" : "",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@437">Patch Set #3, Line 437:</a> <code style="font-family:monospace,monospace"> bert_data->block_status & BIT(1) ? " correctable" : "",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@438">Patch Set #3, Line 438:</a> <code style="font-family:monospace,monospace"> bert_data->block_status & BIT(2) ? " mult-uncorrected" : "",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@439">Patch Set #3, Line 439:</a> <code style="font-family:monospace,monospace"> bert_data->block_status & BIT(3) ? " mult-corrected" : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@441">Patch Set #3, Line 441:</a> <code style="font-family:monospace,monospace"> printk(0, " b Raw Data Offset = %x\n", bert_data->raw_data_offset);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@442">Patch Set #3, Line 442:</a> <code style="font-family:monospace,monospace"> printk(0, " b Raw Data Length = %x\n", bert_data->raw_data_length);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@443">Patch Set #3, Line 443:</a> <code style="font-family:monospace,monospace"> printk(0, " b Data Length = %x\n", bert_data->data_length);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@444">Patch Set #3, Line 444:</a> <code style="font-family:monospace,monospace"> printk(0, " b Error Severity = %x: %s\n", bert_data->error_severity, acpi_sev(bert_data->error_severity));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@445">Patch Set #3, Line 445:</a> <code style="font-family:monospace,monospace"> if (bert_data->data_length && bert_data->data_length < sizeof(acpi_hest_generic_data_v300_t))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@447">Patch Set #3, Line 447:</a> <code style="font-family:monospace,monospace"> bert_data->data_length, sizeof(acpi_hest_generic_data_v300_t));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@448">Patch Set #3, Line 448:</a> <code style="font-family:monospace,monospace"> if (bert_data->raw_data_length && bert_data->raw_data_offset < sizeof(*bert_data) + bert_data->data_length)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@450">Patch Set #3, Line 450:</a> <code style="font-family:monospace,monospace"> bert_data->raw_data_offset, sizeof(*bert_data), bert_data->data_length);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@453">Patch Set #3, Line 453:</a> <code style="font-family:monospace,monospace"> /* can have zero or more data entries, of type 382 and/or of raw */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@454">Patch Set #3, Line 454:</a> <code style="font-family:monospace,monospace"> gen382 = ptr382_from_bert_entry(bert_data); // todo: this only handles a single 382 entry</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28480/3/src/soc/amd/stoneyridge/bertdump.c@463">Patch Set #3, Line 463:</a> <code style="font-family:monospace,monospace"> bert_data = (acpi_generic_error_status_t *)((u8 *)bert_data + offset);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28480">change 28480</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28480"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8ecf920499a662db34a332e9df05e4ee2383b6d4 </div>
<div style="display:none"> Gerrit-Change-Number: 28480 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 06 Sep 2018 18:14:54 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>