<p><a href="https://review.coreboot.org/28393">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.c">File src/mainboard/lenovo/t430s/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.c@72">Patch Set #2, Line 72:</a> <code style="font-family:monospace,monospace">   enum hybrid_graphics_req mode = HYBRID_GRAPHICS_INTEGRATED;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">why not using the hybrid graphics driver ? it looks like the code is the same. Just use: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Well, here https://review.coreboot.org/c/coreboot/+/28380/2/src/mainboard/lenovo/t430s/Kconfig#26 you pointed me at "DRIVERS_LENOVO_HYBRID_GRAPHICS" in Kconfig and said that there's no hybrid graphics in this model, I thought that means "don't use it".</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28393">change 28393</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28393"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8842fef0fa1235eb91abf6b7e655ed4d8598adc7 </div>
<div style="display:none"> Gerrit-Change-Number: 28393 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> </div>
<div style="display:none"> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 31 Aug 2018 07:32:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>