<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28396">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[Please test]nb/intel/i945/raminit: "Correct" DRTST<br><br>Tested on 945G-M4, it now boot even if channel 0 is<br>not populated at all.<br>Could you test if i945 laptop version will boot if<br>DIMM0 is not populated?<br><br>Change-Id: I0d3229b842808d0920e25dcefe49eaceb8e10cdc<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/northbridge/intel/i945/raminit.c<br>1 file changed, 1 insertion(+), 17 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/28396/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c</span><br><span>index c259530..af741d5 100644</span><br><span>--- a/src/northbridge/intel/i945/raminit.c</span><br><span>+++ b/src/northbridge/intel/i945/raminit.c</span><br><span>@@ -1150,23 +1150,7 @@</span><br><span> </span><br><span>   asm volatile ("nop; nop;" ::: "memory");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        reg32 = MCHBAR32(DRTST);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-        /* Is channel 0 populated? */</span><br><span style="color: hsl(0, 100%, 40%);">-   if (sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED ||</span><br><span style="color: hsl(0, 100%, 40%);">-                        sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED)</span><br><span style="color: hsl(0, 100%, 40%);">-              reg32 |= (1 << 7) | (1 << 5);</span><br><span style="color: hsl(0, 100%, 40%);">-       else</span><br><span style="color: hsl(0, 100%, 40%);">-            reg32 |= (1 << 31);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       /* Is channel 1 populated? */</span><br><span style="color: hsl(0, 100%, 40%);">-   if (sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED ||</span><br><span style="color: hsl(0, 100%, 40%);">-                        sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)</span><br><span style="color: hsl(0, 100%, 40%);">-              reg32 |= (1 << 9) | (1 << 8);</span><br><span style="color: hsl(0, 100%, 40%);">-       else</span><br><span style="color: hsl(0, 100%, 40%);">-            reg32 |= (1 << 30);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       MCHBAR32(DRTST) = reg32;</span><br><span style="color: hsl(120, 100%, 40%);">+      MCHBAR32(DRTST) |= (1 << 7) | (1 << 5);</span><br><span> </span><br><span>      /* Activate DRAM Channel IO Buffers */</span><br><span>       if (sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED ||</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28396">change 28396</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28396"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0d3229b842808d0920e25dcefe49eaceb8e10cdc </div>
<div style="display:none"> Gerrit-Change-Number: 28396 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>