<p>Evgeny Zinoviev has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28392">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/lenovo: dGPU power handling on T430(s), T530<br><br>Enable dGPU power handling on Lenovo ThinkPad T430, T430s, T530 via<br>PMH7 register 0x50.<br><br>Although there's no Thinker-1 chip on these models according to<br>schematics, dGPU power control via PMH7 works the same as on T420/T520,<br>so they can be considered Thinker-1-compatible.<br><br>It can be tested from linux userpace using util/pmh7tool.<br><br>To turn dGPU power off:<br> pmh7tool -c 0x50 7<br> pmh7tool -c 0x50 3<br><br>To turn it on:<br> pmh7tool -s 0x50 3<br> pmh7tool -s 0x50 7<br><br>To check whether it is on (bash):<br> reg=0x$(pmh7tool -r 0x50)<br> echo "$(( (( reg & 0x08 )) >> 3 ))"<br>or just `pmh7tool -b 0x50 3` with<br>https://review.coreboot.org/#/c/coreboot/+/28388/<br><br>Tested on ThinkPad W530.<br><br>Change-Id: Ieab1a33b3c680c757cc0999660b5cb7e122474cc<br>Signed-off-by: Evgeny Zinoviev <me@ch1p.com><br>---<br>M src/mainboard/lenovo/t430/devicetree.cb<br>M src/mainboard/lenovo/t530/variants/t530/devicetree.cb<br>M src/mainboard/lenovo/t530/variants/w530/devicetree.cb<br>3 files changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/28392/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb</span><br><span>index d466b36..5eb92bc 100644</span><br><span>--- a/src/mainboard/lenovo/t430/devicetree.cb</span><br><span>+++ b/src/mainboard/lenovo/t430/devicetree.cb</span><br><span>@@ -167,7 +167,7 @@</span><br><span> register "has_backlight_gpio" = "0"</span><br><span> register "has_dgpu_power_gpio" = "0"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- register "has_thinker1" = "0"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "has_thinker1" = "1"</span><br><span> end</span><br><span> chip drivers/pc80/tpm</span><br><span> device pnp 0c31.0 on end</span><br><span>diff --git a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb</span><br><span>index 0da05e0..4dcdc9d 100644</span><br><span>--- a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb</span><br><span>+++ b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb</span><br><span>@@ -157,7 +157,7 @@</span><br><span> register "has_backlight_gpio" = "0"</span><br><span> register "has_dgpu_power_gpio" = "0"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- register "has_thinker1" = "0"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "has_thinker1" = "1"</span><br><span> end</span><br><span> end # LPC bridge</span><br><span> device pci 1f.2 on end # SATA Controller 1</span><br><span>diff --git a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb</span><br><span>index d9d9df5..7a72b26 100644</span><br><span>--- a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb</span><br><span>+++ b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb</span><br><span>@@ -179,7 +179,7 @@</span><br><span> register "has_backlight_gpio" = "0"</span><br><span> register "has_dgpu_power_gpio" = "0"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- register "has_thinker1" = "0"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "has_thinker1" = "1"</span><br><span> end</span><br><span> end</span><br><span> device pci 1f.2 on # SATA Controller 1</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28392">change 28392</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28392"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ieab1a33b3c680c757cc0999660b5cb7e122474cc </div>
<div style="display:none"> Gerrit-Change-Number: 28392 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> </div>