<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28342">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/stoneyridge/enable_usbdebug.c: Update pci_ehci_dbg_set_port()<br><br>Function pci_ehci_dbg_set_port() used NDA register DEBUGPORT_MISC_CONTROL,<br>which was deprecated in favor of a public PCI register (though only the<br>bits to enable debug port became public) 0x90. Therefor code needs to be<br>updated.<br><br>BUG=b:69231009<br>TEST=Build and boot grunt.<br><br>Change-Id: I5938ada96999774bd998998d47686427ec34d4d1<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/stoneyridge/include/soc/southbridge.h<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/28342/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/include/soc/southbridge.h b/src/soc/amd/stoneyridge/include/soc/southbridge.h</span><br><span>index 5f1faea..acbd6ec 100644</span><br><span>--- a/src/soc/amd/stoneyridge/include/soc/southbridge.h</span><br><span>+++ b/src/soc/amd/stoneyridge/include/soc/southbridge.h</span><br><span>@@ -308,7 +308,7 @@</span><br><span> #define EHCI_HUB_CONFIG4            0x90</span><br><span> #define   DEBUG_PORT_SELECT_SHIFT         16</span><br><span> #define   DEBUG_PORT_ENABLE               BIT(18)</span><br><span style="color: hsl(0, 100%, 40%);">-#define   DEBUG_PORT_MASK              ( BIT(16) | BIT(17) | (BIT(18) )</span><br><span style="color: hsl(120, 100%, 40%);">+#define   DEBUG_PORT_MASK             ((BIT(16) | BIT(17) | (BIT(18)))</span><br><span> </span><br><span> #define WIDEIO_RANGE_ERROR              -1</span><br><span> #define TOTAL_WIDEIO_PORTS                3</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28342">change 28342</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28342"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5938ada96999774bd998998d47686427ec34d4d1 </div>
<div style="display:none"> Gerrit-Change-Number: 28342 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>