<p>Lucas Chen has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28333">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">acpi: Hide Chrome and Coreboot specific devices<br><br>Some ACPI interfaces introduced by Chrome or Coreboot do not<br>need drivers outside ChromeOS, for example Chrome EC or<br>Coreboot table.<br><br>These interfaces should be set to hidden so non-ChromeOS systems,<br>for example Windows, won't have problem finding driver.<br><br>Interfaces changed:<br>- Coreboot (BOOT0000), only used by Chrome OS / Linux kernel.<br>- Chrome OS EC<br>- Chrome OS EC PD<br>- Chrome OS TBMC<br>- Chrome OS RAMoops<br><br>BUG=b:72200466<br>BRANCH=eve<br>TEST=Boot into legacy mode and checked ACPI devices on UI.<br><br>Change-Id: I9786cf9ee07b2c3f11509850604f2bfb3f3e710a<br>Signed-off-by: David Wu <David_Wu@quanta.corp-partner.google.com><br>Reviewed-on: https://chromium-review.googlesource.com/1078211<br>Reviewed-by: Hung-Te Lin <hungte@chromium.org><br>Commit-Queue: Hung-Te Lin <hungte@chromium.org><br>Tested-by: Hung-Te Lin <hungte@chromium.org><br>Trybot-Ready: Hung-Te Lin <hungte@chromium.org><br>---<br>M src/arch/x86/acpi.c<br>M src/arch/x86/include/arch/acpigen.h<br>M src/ec/google/chromeec/acpi/cros_ec.asl<br>M src/ec/google/chromeec/acpi/pd.asl<br>M src/ec/google/chromeec/acpi/tbmc.asl<br>M src/vendorcode/google/chromeos/acpi/ramoops.asl<br>6 files changed, 20 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/28333/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c</span><br><span>index 78eeaa7..8e16f94 100644</span><br><span>--- a/src/arch/x86/acpi.c</span><br><span>+++ b/src/arch/x86/acpi.c</span><br><span>@@ -324,7 +324,7 @@</span><br><span> acpigen_write_device("CTBL");</span><br><span> acpigen_write_coreboot_hid(COREBOOT_ACPI_ID_CBTABLE);</span><br><span> acpigen_write_name_integer("_UID", 0);</span><br><span style="color: hsl(0, 100%, 40%);">- acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);</span><br><span style="color: hsl(120, 100%, 40%);">+ acpigen_write_STA(ACPI_STATUS_DEVICE_HIDDEN_ON);</span><br><span> acpigen_write_name("_CRS");</span><br><span> acpigen_write_resourcetemplate_header();</span><br><span> acpigen_write_mem32fixed(0, base, size);</span><br><span>diff --git a/src/arch/x86/include/arch/acpigen.h b/src/arch/x86/include/arch/acpigen.h</span><br><span>index 775339a..a27bd6f 100644</span><br><span>--- a/src/arch/x86/include/arch/acpigen.h</span><br><span>+++ b/src/arch/x86/include/arch/acpigen.h</span><br><span>@@ -36,6 +36,9 @@</span><br><span> ACPI_STATUS_DEVICE_ENABLED |\</span><br><span> ACPI_STATUS_DEVICE_SHOW_IN_UI |\</span><br><span> ACPI_STATUS_DEVICE_STATE_OK)</span><br><span style="color: hsl(120, 100%, 40%);">+#define ACPI_STATUS_DEVICE_HIDDEN_ON (ACPI_STATUS_DEVICE_PRESENT |\</span><br><span style="color: hsl(120, 100%, 40%);">+ ACPI_STATUS_DEVICE_ENABLED |\</span><br><span style="color: hsl(120, 100%, 40%);">+ ACPI_STATUS_DEVICE_STATE_OK)</span><br><span> </span><br><span> /* ACPI Op/Prefix Codes */</span><br><span> enum {</span><br><span>diff --git a/src/ec/google/chromeec/acpi/cros_ec.asl b/src/ec/google/chromeec/acpi/cros_ec.asl</span><br><span>index 1d7fb52..d0a5b68 100644</span><br><span>--- a/src/ec/google/chromeec/acpi/cros_ec.asl</span><br><span>+++ b/src/ec/google/chromeec/acpi/cros_ec.asl</span><br><span>@@ -39,4 +39,8 @@</span><br><span> Name (_DDN, "EC Base Switch Device")</span><br><span> }</span><br><span> #endif</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_STA, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0xB)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span>diff --git a/src/ec/google/chromeec/acpi/pd.asl b/src/ec/google/chromeec/acpi/pd.asl</span><br><span>index a5a58f5..7b799e8 100644</span><br><span>--- a/src/ec/google/chromeec/acpi/pd.asl</span><br><span>+++ b/src/ec/google/chromeec/acpi/pd.asl</span><br><span>@@ -18,4 +18,8 @@</span><br><span> Name (_HID, "GOOG0003")</span><br><span> Name (_UID, 1)</span><br><span> Name (_DDN, "EC PD Device")</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_STA, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0xB)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span>diff --git a/src/ec/google/chromeec/acpi/tbmc.asl b/src/ec/google/chromeec/acpi/tbmc.asl</span><br><span>index 25a27ef1b..86a6de8 100644</span><br><span>--- a/src/ec/google/chromeec/acpi/tbmc.asl</span><br><span>+++ b/src/ec/google/chromeec/acpi/tbmc.asl</span><br><span>@@ -26,4 +26,8 @@</span><br><span> Return (0x0)</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_STA, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0xB)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span>diff --git a/src/vendorcode/google/chromeos/acpi/ramoops.asl b/src/vendorcode/google/chromeos/acpi/ramoops.asl</span><br><span>index 5a8ed86..810ff91 100644</span><br><span>--- a/src/vendorcode/google/chromeos/acpi/ramoops.asl</span><br><span>+++ b/src/vendorcode/google/chromeos/acpi/ramoops.asl</span><br><span>@@ -35,5 +35,9 @@</span><br><span> Store (\RMOL, RLEN)</span><br><span> Return (^RBUF)</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ Method(_STA, 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0xB)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28333">change 28333</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28333"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9786cf9ee07b2c3f11509850604f2bfb3f3e710a </div>
<div style="display:none"> Gerrit-Change-Number: 28333 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lucas Chen <lucas.chen@quanta.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com> </div>