<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28297">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vendorcode/amd/pi/00670F00: Transfer IDS_CALLOUT to AGESA.h<br><br>Currently, IDS_CALLOUT macros are only used in stoneyridge callout. In<br>preparation to remove IDS headers, move the definitions to AGESA.h.<br><br>BUG=b:112885948<br>TEST=Build grunt<br><br>Change-Id: Ia9717eb68fed2e568eaf169157c2837bb8232b7e<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/vendorcode/amd/pi/00670F00/AGESA.h<br>M src/vendorcode/amd/pi/00670F00/Include/Ids.h<br>2 files changed, 30 insertions(+), 30 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/28297/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vendorcode/amd/pi/00670F00/AGESA.h b/src/vendorcode/amd/pi/00670F00/AGESA.h</span><br><span>index 41180cb..22ba7fe 100644</span><br><span>--- a/src/vendorcode/amd/pi/00670F00/AGESA.h</span><br><span>+++ b/src/vendorcode/amd/pi/00670F00/AGESA.h</span><br><span>@@ -3579,6 +3579,36 @@</span><br><span> CoreLevelModeMax ///< Used for bounds checking</span><br><span> } CORE_LEVELING_TYPE;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+///For IDS feat use</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_FAMILY_ALL 0xFFFFFFFFFFFFFFFFull</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_BSP_ONLY TRUE</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_ALL_CORES FALSE</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_LATE_RUN_AP_TASK_ID PROC_IDS_LIBRARY_IDSLIB_FILECODE</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_INIT 0x01 ///< The function data of IDS callout function of initialization.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_PPFUSE_OVERRIDE 0x83 ///< The function data of IDS callout function of GNB pp fuse table.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_INTEGRATED_TABLE_CONFIG 0x84 ///< The function data of IDS callout function of GNB integrated table.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_NB_POWERGATE_CONFIG 0x85 ///< The function data of IDS callout function of GNB NB power gate config.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_PCIE_POWERGATE_CONFIG 0x86 ///< The function data of IDS callout function of GNB PCIE power gateconfig.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_PCIE_PLATFORM_CONFIG 0x87 ///< The function data of IDS callout function of GNB pcie platform config.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_PCIE_PHY_CONFIG 0x88 ///< The function data of IDS callout function of GNB pcie PHY config.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_GMM_REGISTER_OVERRIDE 0x89 ///< The function data of IDS callout function of GNB GMM register override</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_FCH_INIT_RESET 0x8A ///< The function data of IDS callout function of FchInitReset</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_FCH_INIT_ENV 0x8B ///< The function data of IDS callout function of FchInitEnv.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_POWER_PLAN_INIT 0x8C ///< The function data of IDS callout function of Override Power Plan Init</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GET_PERF_BUFFER 0x8D ///< The function data of IDS callout function of get platform performance buffer.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_PACKAGE_POWER_CONFIG 0x8E ///< The function data of IDS callout function of Bapm Package Power.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_SMU_PORT80_LOGGING_BUFFER 0x8F ///< The function data of IDS callout function of SMU port80 logging buffer.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_BEFORE_EARLY_INIT 0x90 ///< The function data of IDS callout function of GNB before early init.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_SMUBIOSTABLE_OVERRIDE 0x91 ///< The function data of IDS callout function of GNB smu bios table.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_PCIE_AER_CONFIG 0x92 ///< The function data of IDS callout function of GNB PCIE AER config.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_PCIE_EARLY_PORT_CONFIG 0x93 ///< The function data of IDS callout function of GNB pcie early port config.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_BUILDOPTIONS_OVERRIDE 0x94 ///< The function data of IDS callout function of GNB build options override.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_SMUFEATURES_MASK_OVERRIDE 0x95 ///< The function data of IDS callout function of GNB SMU Features MASK override.</span><br><span style="color: hsl(120, 100%, 40%);">+#define IDS_CALLOUT_GNB_BEFORE_TXPRESET_LOADING 0x96 ///< The function data of IDS callout function of GNB pcie Tx preset loading sequence.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> </span><br><span> </span><br><span>diff --git a/src/vendorcode/amd/pi/00670F00/Include/Ids.h b/src/vendorcode/amd/pi/00670F00/Include/Ids.h</span><br><span>index 1cf390d..cc1a2b9 100644</span><br><span>--- a/src/vendorcode/amd/pi/00670F00/Include/Ids.h</span><br><span>+++ b/src/vendorcode/amd/pi/00670F00/Include/Ids.h</span><br><span>@@ -916,36 +916,6 @@</span><br><span> #define IDS_PERF_ANALYSE(StdHeader)</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-///For IDS feat use</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_FAMILY_ALL 0xFFFFFFFFFFFFFFFFull</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_BSP_ONLY TRUE</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_ALL_CORES FALSE</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_LATE_RUN_AP_TASK_ID PROC_IDS_LIBRARY_IDSLIB_FILECODE</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_INIT 0x01 ///< The function data of IDS callout function of initialization.</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_PPFUSE_OVERRIDE 0x83 ///< The function data of IDS callout function of GNB pp fuse table.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_INTEGRATED_TABLE_CONFIG 0x84 ///< The function data of IDS callout function of GNB integrated table.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_NB_POWERGATE_CONFIG 0x85 ///< The function data of IDS callout function of GNB NB power gate config.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_PCIE_POWERGATE_CONFIG 0x86 ///< The function data of IDS callout function of GNB PCIE power gateconfig.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_PCIE_PLATFORM_CONFIG 0x87 ///< The function data of IDS callout function of GNB pcie platform config.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_PCIE_PHY_CONFIG 0x88 ///< The function data of IDS callout function of GNB pcie PHY config.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_GMM_REGISTER_OVERRIDE 0x89 ///< The function data of IDS callout function of GNB GMM register override</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_FCH_INIT_RESET 0x8A ///< The function data of IDS callout function of FchInitReset</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_FCH_INIT_ENV 0x8B ///< The function data of IDS callout function of FchInitEnv.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_POWER_PLAN_INIT 0x8C ///< The function data of IDS callout function of Override Power Plan Init</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GET_PERF_BUFFER 0x8D ///< The function data of IDS callout function of get platform performance buffer.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_PACKAGE_POWER_CONFIG 0x8E ///< The function data of IDS callout function of Bapm Package Power.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_SMU_PORT80_LOGGING_BUFFER 0x8F ///< The function data of IDS callout function of SMU port80 logging buffer.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_BEFORE_EARLY_INIT 0x90 ///< The function data of IDS callout function of GNB before early init.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_SMUBIOSTABLE_OVERRIDE 0x91 ///< The function data of IDS callout function of GNB smu bios table.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_PCIE_AER_CONFIG 0x92 ///< The function data of IDS callout function of GNB PCIE AER config.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_PCIE_EARLY_PORT_CONFIG 0x93 ///< The function data of IDS callout function of GNB pcie early port config.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_BUILDOPTIONS_OVERRIDE 0x94 ///< The function data of IDS callout function of GNB build options override.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_SMUFEATURES_MASK_OVERRIDE 0x95 ///< The function data of IDS callout function of GNB SMU Features MASK override.</span><br><span style="color: hsl(0, 100%, 40%);">-#define IDS_CALLOUT_GNB_BEFORE_TXPRESET_LOADING 0x96 ///< The function data of IDS callout function of GNB pcie Tx preset loading sequence.</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /// Function entry for HDT script to call</span><br><span> typedef struct _SCRIPT_FUNCTION {</span><br><span> UINT32 FuncAddr; ///< Function address in ROM</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28297">change 28297</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28297"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia9717eb68fed2e568eaf169157c2837bb8232b7e </div>
<div style="display:none"> Gerrit-Change-Number: 28297 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>