<p>Pratikkumar V Prajapati has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28274">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">skylake,kabylake: Add support to set eMMC tuning param from dev tree<br><br>Add support to set eMMC tuning params from the device tree so that it<br>can be configured per board.<br><br>BUG=b:112718426,b:112690628<br>BRANCH=none<br>TEST=Build nocturne image and checked values passed in dev tree is set<br>by FSP.<br><br>Change-Id: Ic71934dce9a1c380a057e579ca3fda41983b9385<br>Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati@intel.com><br>---<br>M src/soc/intel/skylake/chip.h<br>M src/soc/intel/skylake/chip_fsp20.c<br>2 files changed, 12 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/28274/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h</span><br><span>index ec8b461..101ac61 100644</span><br><span>--- a/src/soc/intel/skylake/chip.h</span><br><span>+++ b/src/soc/intel/skylake/chip.h</span><br><span>@@ -288,6 +288,9 @@</span><br><span>         u8 ScsEmmcEnabled;</span><br><span>   u8 ScsEmmcHs400Enabled;</span><br><span>      u8 ScsSdCardEnabled;</span><br><span style="color: hsl(120, 100%, 40%);">+  u8 EmmcHs400DllNeed;</span><br><span style="color: hsl(120, 100%, 40%);">+  u8 ScsEmmcHs400RxStrobeDll1;</span><br><span style="color: hsl(120, 100%, 40%);">+  u8 ScsEmmcHs400TxDataDll;</span><br><span> </span><br><span>        u8 PttSwitch;</span><br><span>        u8 HeciTimeouts;</span><br><span>diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c</span><br><span>index d5f5433..c2c0745 100644</span><br><span>--- a/src/soc/intel/skylake/chip_fsp20.c</span><br><span>+++ b/src/soc/intel/skylake/chip_fsp20.c</span><br><span>@@ -336,6 +336,15 @@</span><br><span>         params->ScsEmmcHs400Enabled = config->ScsEmmcHs400Enabled;</span><br><span>     params->ScsSdCardEnabled = config->ScsSdCardEnabled;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        if (!!params->ScsEmmcHs400Enabled && !!config->EmmcHs400DllNeed) {</span><br><span style="color: hsl(120, 100%, 40%);">+              params->PchScsEmmcHs400DllDataValid =</span><br><span style="color: hsl(120, 100%, 40%);">+                      !!config->EmmcHs400DllNeed;</span><br><span style="color: hsl(120, 100%, 40%);">+                params->PchScsEmmcHs400RxStrobeDll1 =</span><br><span style="color: hsl(120, 100%, 40%);">+                      config->ScsEmmcHs400RxStrobeDll1;</span><br><span style="color: hsl(120, 100%, 40%);">+          params->PchScsEmmcHs400TxDataDll =</span><br><span style="color: hsl(120, 100%, 40%);">+                 config->ScsEmmcHs400TxDataDll;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  /* If ISH is enabled, enable ISH elements */</span><br><span>         dev = dev_find_slot(0, PCH_DEVFN_ISH);</span><br><span>       if (dev)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28274">change 28274</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28274"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic71934dce9a1c380a057e579ca3fda41983b9385 </div>
<div style="display:none"> Gerrit-Change-Number: 28274 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> </div>