<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28302">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/intel/gma: Fix OpRegion Mailbox3 synchronization<br><br>Make XBCM `Serialized` (obvious), and check for the callee clearing the<br>request bit (we checked only the status for 0 which we potentially wrote<br>ourselves).<br><br>Change-Id: Ic92d525eda8d0a159fa5ddaacf230658d71c1578<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M src/drivers/intel/gma/acpi/configure_brightness_levels.asl<br>1 file changed, 9 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/28302/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl</span><br><span>index 024360f..951d33d 100644</span><br><span>--- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl</span><br><span>+++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl</span><br><span>@@ -55,7 +55,7 @@</span><br><span> * * Driver not loaded or not ready</span><br><span> * * Driver reported an error during ASLE IRQ</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">- Method (XBCM, 1, NotSerialized)</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (XBCM, 1, Serialized)</span><br><span> {</span><br><span> If (LEqual(ASLS, Zero))</span><br><span> {</span><br><span>@@ -84,9 +84,14 @@</span><br><span> While (LGreater(Local0, Zero))</span><br><span> {</span><br><span> Sleep (1)</span><br><span style="color: hsl(0, 100%, 40%);">- If (LEqual(And(ShiftRight(ASLC, 12), 0x3), Zero))</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (Zero)</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LEqual (And (ASLC, 0x2), 0)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Request has been processed, check status: */</span><br><span style="color: hsl(120, 100%, 40%);">+ And (ShiftRight (ASLC, 12), 0x3, Local1)</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LEqual (Local1, 0)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0)</span><br><span style="color: hsl(120, 100%, 40%);">+ } Else {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (Ones)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> Decrement (Local0)</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28302">change 28302</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28302"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic92d525eda8d0a159fa5ddaacf230658d71c1578 </div>
<div style="display:none"> Gerrit-Change-Number: 28302 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>