<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28288">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/kconfig: Fix typo<br><br>Change-Id: I02063c1d4e76f0c55937da7a309c0f668bc0e064<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M util/kconfig/conf.c<br>M util/kconfig/confdata.c<br>M util/kconfig/gconf.c<br>M util/kconfig/kxgettext.c<br>M util/kconfig/lkc_proto.h<br>M util/kconfig/mconf.c<br>M util/kconfig/nconf.c<br>M util/kconfig/qconf.cc<br>M util/kconfig/symbol.c<br>9 files changed, 21 insertions(+), 21 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/28288/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/kconfig/conf.c b/util/kconfig/conf.c</span><br><span>index 7aae1c7..1e704a6 100644</span><br><span>--- a/util/kconfig/conf.c</span><br><span>+++ b/util/kconfig/conf.c</span><br><span>@@ -93,7 +93,7 @@</span><br><span> line[0] = '\n';</span><br><span> line[1] = 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (!sym_is_changable(sym)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!sym_is_changeable(sym)) {</span><br><span> printf("%s\n", def);</span><br><span> line[0] = '\n';</span><br><span> line[1] = 0;</span><br><span>@@ -242,7 +242,7 @@</span><br><span> </span><br><span> sym = menu->sym;</span><br><span> is_new = !sym_has_value(sym);</span><br><span style="color: hsl(0, 100%, 40%);">- if (sym_is_changable(sym)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (sym_is_changeable(sym)) {</span><br><span> conf_sym(menu);</span><br><span> sym_calc_value(sym);</span><br><span> switch (sym_get_tristate_value(sym)) {</span><br><span>@@ -429,7 +429,7 @@</span><br><span> </span><br><span> sym = menu->sym;</span><br><span> if (sym && !sym_has_value(sym)) {</span><br><span style="color: hsl(0, 100%, 40%);">- if (sym_is_changable(sym) ||</span><br><span style="color: hsl(120, 100%, 40%);">+ if (sym_is_changeable(sym) ||</span><br><span> (sym_is_choice(sym) && sym_get_tristate_value(sym) == yes)) {</span><br><span> if (input_mode == listnewconfig) {</span><br><span> if (sym->name && !sym_is_choice_value(sym)) {</span><br><span>diff --git a/util/kconfig/confdata.c b/util/kconfig/confdata.c</span><br><span>index fc4a07a..a9051fa 100644</span><br><span>--- a/util/kconfig/confdata.c</span><br><span>+++ b/util/kconfig/confdata.c</span><br><span>@@ -718,7 +718,7 @@</span><br><span> goto next_menu;</span><br><span> sym->flags &= ~SYMBOL_WRITE;</span><br><span> /* If we cannot change the symbol - skip */</span><br><span style="color: hsl(0, 100%, 40%);">- if (!sym_is_changable(sym))</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!sym_is_changeable(sym))</span><br><span> goto next_menu;</span><br><span> /* If symbol equals to default value - skip */</span><br><span> if (strcmp(sym_get_string_value(sym), sym_get_string_default(sym)) == 0)</span><br><span>diff --git a/util/kconfig/gconf.c b/util/kconfig/gconf.c</span><br><span>index faa1c59..f0291c4 100644</span><br><span>--- a/util/kconfig/gconf.c</span><br><span>+++ b/util/kconfig/gconf.c</span><br><span>@@ -40,7 +40,7 @@</span><br><span> static gboolean show_name = TRUE;</span><br><span> static gboolean show_range = TRUE;</span><br><span> static gboolean show_value = TRUE;</span><br><span style="color: hsl(0, 100%, 40%);">-static gboolean resizeable = FALSE;</span><br><span style="color: hsl(120, 100%, 40%);">+static gboolean resizable = FALSE;</span><br><span> static int opt_mode = OPT_NORMAL;</span><br><span> </span><br><span> GtkWidget *main_wnd = NULL;</span><br><span>@@ -375,7 +375,7 @@</span><br><span> column = gtk_tree_view_get_column(view, COL_VALUE);</span><br><span> gtk_tree_view_column_set_visible(column, show_value);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (resizeable) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (resizable) {</span><br><span> for (i = 0; i < COL_VALUE; i++) {</span><br><span> column = gtk_tree_view_get_column(view, i);</span><br><span> gtk_tree_view_column_set_resizable(column, TRUE);</span><br><span>diff --git a/util/kconfig/kxgettext.c b/util/kconfig/kxgettext.c</span><br><span>index 2858738..907eae8 100644</span><br><span>--- a/util/kconfig/kxgettext.c</span><br><span>+++ b/util/kconfig/kxgettext.c</span><br><span>@@ -117,7 +117,7 @@</span><br><span> goto out;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static struct message *mesage__find(const char *msg)</span><br><span style="color: hsl(120, 100%, 40%);">+static struct message *message__find(const char *msg)</span><br><span> {</span><br><span> struct message *m = message__list;</span><br><span> </span><br><span>@@ -152,7 +152,7 @@</span><br><span> int rc = 0;</span><br><span> char bf[16384];</span><br><span> char *escaped = escape(msg, bf, sizeof(bf));</span><br><span style="color: hsl(0, 100%, 40%);">- struct message *m = mesage__find(escaped);</span><br><span style="color: hsl(120, 100%, 40%);">+ struct message *m = message__find(escaped);</span><br><span> </span><br><span> if (m != NULL)</span><br><span> rc = message__add_file_line(m, file, lineno);</span><br><span>diff --git a/util/kconfig/lkc_proto.h b/util/kconfig/lkc_proto.h</span><br><span>index ecdb965..a6e30c7 100644</span><br><span>--- a/util/kconfig/lkc_proto.h</span><br><span>+++ b/util/kconfig/lkc_proto.h</span><br><span>@@ -45,7 +45,7 @@</span><br><span> P(sym_string_valid,bool,(struct symbol *sym, const char *newval));</span><br><span> P(sym_string_within_range,bool,(struct symbol *sym, const char *str));</span><br><span> P(sym_set_string_value,bool,(struct symbol *sym, const char *newval));</span><br><span style="color: hsl(0, 100%, 40%);">-P(sym_is_changable,bool,(struct symbol *sym));</span><br><span style="color: hsl(120, 100%, 40%);">+P(sym_is_changeable,bool,(struct symbol *sym));</span><br><span> P(sym_get_choice_prop,struct property *,(struct symbol *sym));</span><br><span> P(sym_get_default_prop,struct property *,(struct symbol *sym));</span><br><span> P(sym_get_string_value,const char *,(struct symbol *sym));</span><br><span>diff --git a/util/kconfig/mconf.c b/util/kconfig/mconf.c</span><br><span>index 7e5dc76..81eebba 100644</span><br><span>--- a/util/kconfig/mconf.c</span><br><span>+++ b/util/kconfig/mconf.c</span><br><span>@@ -539,7 +539,7 @@</span><br><span> }</span><br><span> </span><br><span> val = sym_get_tristate_value(sym);</span><br><span style="color: hsl(0, 100%, 40%);">- if (sym_is_changable(sym)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (sym_is_changeable(sym)) {</span><br><span> switch (type) {</span><br><span> case S_BOOLEAN:</span><br><span> item_make("[%c]", val == no ? ' ' : '*');</span><br><span>@@ -590,7 +590,7 @@</span><br><span> } else {</span><br><span> switch (type) {</span><br><span> case S_BOOLEAN:</span><br><span style="color: hsl(0, 100%, 40%);">- if (sym_is_changable(sym))</span><br><span style="color: hsl(120, 100%, 40%);">+ if (sym_is_changeable(sym))</span><br><span> item_make("[%c]", val == no ? ' ' : '*');</span><br><span> else</span><br><span> item_make("-%c-", val == no ? ' ' : '*');</span><br><span>@@ -603,7 +603,7 @@</span><br><span> case mod: ch = 'M'; break;</span><br><span> default: ch = ' '; break;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- if (sym_is_changable(sym)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (sym_is_changeable(sym)) {</span><br><span> if (sym->rev_dep.tri == mod)</span><br><span> item_make("{%c}", ch);</span><br><span> else</span><br><span>@@ -620,7 +620,7 @@</span><br><span> if (tmp < 0)</span><br><span> tmp = 0;</span><br><span> item_add_str("%*c%s%s", tmp, ' ', _(menu_get_prompt(menu)),</span><br><span style="color: hsl(0, 100%, 40%);">- (sym_has_value(sym) || !sym_is_changable(sym)) ?</span><br><span style="color: hsl(120, 100%, 40%);">+ (sym_has_value(sym) || !sym_is_changeable(sym)) ?</span><br><span> "" : _(" (NEW)"));</span><br><span> item_set_tag('s');</span><br><span> item_set_data(menu);</span><br><span>@@ -628,7 +628,7 @@</span><br><span> }</span><br><span> }</span><br><span> item_add_str("%*c%s%s", indent + 1, ' ', _(menu_get_prompt(menu)),</span><br><span style="color: hsl(0, 100%, 40%);">- (sym_has_value(sym) || !sym_is_changable(sym)) ?</span><br><span style="color: hsl(120, 100%, 40%);">+ (sym_has_value(sym) || !sym_is_changeable(sym)) ?</span><br><span> "" : _(" (NEW)"));</span><br><span> if (menu->prompt->type == P_MENU) {</span><br><span> item_add_str(" %s", menu_is_empty(menu) ? "----" : "--->");</span><br><span>diff --git a/util/kconfig/nconf.c b/util/kconfig/nconf.c</span><br><span>index 905dcd1..35c397f 100644</span><br><span>--- a/util/kconfig/nconf.c</span><br><span>+++ b/util/kconfig/nconf.c</span><br><span>@@ -814,7 +814,7 @@</span><br><span> }</span><br><span> </span><br><span> val = sym_get_tristate_value(sym);</span><br><span style="color: hsl(0, 100%, 40%);">- if (sym_is_changable(sym)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (sym_is_changeable(sym)) {</span><br><span> switch (type) {</span><br><span> case S_BOOLEAN:</span><br><span> item_make(menu, 't', "[%c]",</span><br><span>@@ -868,7 +868,7 @@</span><br><span> } else {</span><br><span> switch (type) {</span><br><span> case S_BOOLEAN:</span><br><span style="color: hsl(0, 100%, 40%);">- if (sym_is_changable(sym))</span><br><span style="color: hsl(120, 100%, 40%);">+ if (sym_is_changeable(sym))</span><br><span> item_make(menu, 't', "[%c]",</span><br><span> val == no ? ' ' : '*');</span><br><span> else</span><br><span>@@ -887,7 +887,7 @@</span><br><span> ch = ' ';</span><br><span> break;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- if (sym_is_changable(sym)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (sym_is_changeable(sym)) {</span><br><span> if (sym->rev_dep.tri == mod)</span><br><span> item_make(menu,</span><br><span> 't', "{%c}", ch);</span><br><span>@@ -907,14 +907,14 @@</span><br><span> item_add_str("%*c%s%s", tmp, ' ',</span><br><span> _(menu_get_prompt(menu)),</span><br><span> (sym_has_value(sym) ||</span><br><span style="color: hsl(0, 100%, 40%);">- !sym_is_changable(sym)) ? "" :</span><br><span style="color: hsl(120, 100%, 40%);">+ !sym_is_changeable(sym)) ? "" :</span><br><span> _(" (NEW)"));</span><br><span> goto conf_childs;</span><br><span> }</span><br><span> }</span><br><span> item_add_str("%*c%s%s", indent + 1, ' ',</span><br><span> _(menu_get_prompt(menu)),</span><br><span style="color: hsl(0, 100%, 40%);">- (sym_has_value(sym) || !sym_is_changable(sym)) ?</span><br><span style="color: hsl(120, 100%, 40%);">+ (sym_has_value(sym) || !sym_is_changeable(sym)) ?</span><br><span> "" : _(" (NEW)"));</span><br><span> if (menu->prompt && menu->prompt->type == P_MENU) {</span><br><span> item_add_str(" %s", menu_is_empty(menu) ? "----" : "--->");</span><br><span>diff --git a/util/kconfig/qconf.cc b/util/kconfig/qconf.cc</span><br><span>index e787117..972326c 100644</span><br><span>--- a/util/kconfig/qconf.cc</span><br><span>+++ b/util/kconfig/qconf.cc</span><br><span>@@ -155,7 +155,7 @@</span><br><span> case S_TRISTATE:</span><br><span> char ch;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (!sym_is_changable(sym) && list->optMode == normalOpt) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!sym_is_changeable(sym) && list->optMode == normalOpt) {</span><br><span> setPixmap(promptColIdx, QIcon());</span><br><span> setText(noColIdx, QString::null);</span><br><span> setText(modColIdx, QString::null);</span><br><span>diff --git a/util/kconfig/symbol.c b/util/kconfig/symbol.c</span><br><span>index af49439..b969616 100644</span><br><span>--- a/util/kconfig/symbol.c</span><br><span>+++ b/util/kconfig/symbol.c</span><br><span>@@ -792,7 +792,7 @@</span><br><span> return (const char *)sym->curr.val;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-bool sym_is_changable(struct symbol *sym)</span><br><span style="color: hsl(120, 100%, 40%);">+bool sym_is_changeable(struct symbol *sym)</span><br><span> {</span><br><span> return sym->visible > sym->rev_dep.tri;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28288">change 28288</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28288"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I02063c1d4e76f0c55937da7a309c0f668bc0e064 </div>
<div style="display:none"> Gerrit-Change-Number: 28288 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>