<p><a href="https://review.coreboot.org/28293">View Change</a></p><p>22 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c">File util/romcc/romcc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@1770">Patch Set #1, Line 1770:</a> <code style="font-family:monospace,monospace"> for(spot = triple->occurrence; spot; spot = spot->parent) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@1952">Patch Set #1, Line 1952:</a> <code style="font-family:monospace,monospace"> if (occurrence->parent) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@2403">Patch Set #1, Line 2403:</a> <code style="font-family:monospace,monospace"> piece = alloc_triple(state, OP_PIECE, piece_type, -1, -1, ins->occurrence);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@2522">Patch Set #1, Line 2522:</a> <code style="font-family:monospace,monospace"> for(ptr = ins->occurrence; ptr; ptr = ptr->parent) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@2605">Patch Set #1, Line 2605:</a> <code style="font-family:monospace,monospace"> for(ptr = orig->occurrence; ptr; ptr = ptr->parent) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@13722">Patch Set #1, Line 13722:</a> <code style="font-family:monospace,monospace"> occurrence = inline_occurrence(state, base_occurrence, old->occurrence);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@15918">Patch Set #1, Line 15918:</a> <code style="font-family:monospace,monospace"> while(ins != block->last && (ins->occurrence->line == 0)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@15918">Patch Set #1, Line 15918:</a> <code style="font-family:monospace,monospace"> while(ins != block->last && (ins->occurrence->line == 0)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@16628">Patch Set #1, Line 16628:</a> <code style="font-family:monospace,monospace"> phi->type, 0, 0, phi->occurrence));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@20782">Patch Set #1, Line 20782:</a> <code style="font-family:monospace,monospace">#warning "FIXME constant propagate through expressions with multiple left hand sides"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@21479">Patch Set #1, Line 21479:</a> <code style="font-family:monospace,monospace"> if ( (dummy_occurrence.count != 2) ||</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited after that open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@21484">Patch Set #1, Line 21484:</a> <code style="font-family:monospace,monospace"> internal_error(state, &unknown_triple, "dummy_occurrence corrupted!");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@24821">Patch Set #1, Line 24821:</a> <code style="font-family:monospace,monospace"> ins->occurrence->function?ins->occurrence->function:"(null)",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@24822">Patch Set #1, Line 24822:</a> <code style="font-family:monospace,monospace"> ins->occurrence->filename?ins->occurrence->filename:"(null)",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@24831">Patch Set #1, Line 24831:</a> <code style="font-family:monospace,monospace"> for(ptr = ins->occurrence; ptr; ptr = ptr->parent) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@24831">Patch Set #1, Line 24831:</a> <code style="font-family:monospace,monospace"> for(ptr = ins->occurrence; ptr; ptr = ptr->parent) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@24844">Patch Set #1, Line 24844:</a> <code style="font-family:monospace,monospace"> if (last_occurrence) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/tests/linux_test2.c">File util/romcc/tests/linux_test2.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/tests/linux_test2.c@487">Patch Set #1, Line 487:</a> <code style="font-family:monospace,monospace"> * This field defines the upp address bits of a 40-bit address that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test.c">File util/romcc/tests/raminit_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test.c@757">Patch Set #1, Line 757:</a> <code style="font-family:monospace,monospace"> * DRAMC register, which records if ram is registered or not,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test1.c">File util/romcc/tests/raminit_test1.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test1.c@757">Patch Set #1, Line 757:</a> <code style="font-family:monospace,monospace"> * DRAMC register, which records if ram is registered or not,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test2.c">File util/romcc/tests/raminit_test2.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test2.c@757">Patch Set #1, Line 757:</a> <code style="font-family:monospace,monospace"> * DRAMC register, which records if ram is registered or not,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/tests/simple_test30.c">File util/romcc/tests/simple_test30.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28293/1/util/romcc/tests/simple_test30.c@901">Patch Set #1, Line 901:</a> <code style="font-family:monospace,monospace"> * This field defines the upp address bits of a 40-bit address that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28293">change 28293</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28293"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia9f0f1f527476900e6c54c60508600e16bea786f </div>
<div style="display:none"> Gerrit-Change-Number: 28293 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 23 Aug 2018 16:27:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>