<p>Marc Jones has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28277">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">update all FADT version 3.0 to use the get tables function<br><br>Most FADT report using ACPIv3 FADT table. Using the get revision<br>function keeps the table versions in sync.<br><br>Change-Id: Ie554faf1be65c7034dd0836f0029cdc79eae1aed<br>Signed-off-by: Marc Jones <marcj303@gmail.com><br>---<br>M src/mainboard/aopen/dxplplusu/fadt.c<br>M src/mainboard/google/auron/fadt.c<br>M src/mainboard/google/beltino/fadt.c<br>M src/mainboard/google/cyan/fadt.c<br>M src/mainboard/google/jecht/fadt.c<br>M src/mainboard/google/rambi/fadt.c<br>M src/mainboard/google/slippy/fadt.c<br>M src/mainboard/purism/librem_bdw/fadt.c<br>M src/soc/amd/stoneyridge/acpi.c<br>M src/soc/intel/common/block/acpi/acpi.c<br>M src/soc/intel/fsp_baytrail/acpi.c<br>M src/soc/intel/fsp_broadwell_de/acpi.c<br>M src/soc/intel/skylake/acpi.c<br>M src/southbridge/amd/agesa/hudson/fadt.c<br>M src/southbridge/amd/cimx/sb800/fadt.c<br>M src/southbridge/amd/pi/hudson/fadt.c<br>M src/southbridge/intel/fsp_rangeley/acpi.c<br>17 files changed, 17 insertions(+), 17 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/28277/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/aopen/dxplplusu/fadt.c b/src/mainboard/aopen/dxplplusu/fadt.c</span><br><span>index 418d547..9e44b85 100644</span><br><span>--- a/src/mainboard/aopen/dxplplusu/fadt.c</span><br><span>+++ b/src/mainboard/aopen/dxplplusu/fadt.c</span><br><span>@@ -37,7 +37,7 @@</span><br><span> memset((void *) fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = 4;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/mainboard/google/auron/fadt.c b/src/mainboard/google/auron/fadt.c</span><br><span>index dea67d0..c96ae68 100644</span><br><span>--- a/src/mainboard/google/auron/fadt.c</span><br><span>+++ b/src/mainboard/google/auron/fadt.c</span><br><span>@@ -24,7 +24,7 @@</span><br><span> memset((void *) fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/mainboard/google/beltino/fadt.c b/src/mainboard/google/beltino/fadt.c</span><br><span>index 486a343..806902d 100644</span><br><span>--- a/src/mainboard/google/beltino/fadt.c</span><br><span>+++ b/src/mainboard/google/beltino/fadt.c</span><br><span>@@ -27,7 +27,7 @@</span><br><span> memset((void *) fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/mainboard/google/cyan/fadt.c b/src/mainboard/google/cyan/fadt.c</span><br><span>index d62c28d..29e2d2a 100644</span><br><span>--- a/src/mainboard/google/cyan/fadt.c</span><br><span>+++ b/src/mainboard/google/cyan/fadt.c</span><br><span>@@ -24,7 +24,7 @@</span><br><span> memset((void *) fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/mainboard/google/jecht/fadt.c b/src/mainboard/google/jecht/fadt.c</span><br><span>index dea67d0..c96ae68 100644</span><br><span>--- a/src/mainboard/google/jecht/fadt.c</span><br><span>+++ b/src/mainboard/google/jecht/fadt.c</span><br><span>@@ -24,7 +24,7 @@</span><br><span> memset((void *) fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/mainboard/google/rambi/fadt.c b/src/mainboard/google/rambi/fadt.c</span><br><span>index b0fe9d6..4aa4ec6 100644</span><br><span>--- a/src/mainboard/google/rambi/fadt.c</span><br><span>+++ b/src/mainboard/google/rambi/fadt.c</span><br><span>@@ -23,7 +23,7 @@</span><br><span> memset((void *) fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/mainboard/google/slippy/fadt.c b/src/mainboard/google/slippy/fadt.c</span><br><span>index fe86f56..8a04591 100644</span><br><span>--- a/src/mainboard/google/slippy/fadt.c</span><br><span>+++ b/src/mainboard/google/slippy/fadt.c</span><br><span>@@ -27,7 +27,7 @@</span><br><span> memset((void *) fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/mainboard/purism/librem_bdw/fadt.c b/src/mainboard/purism/librem_bdw/fadt.c</span><br><span>index 9cbcd3f..fbce9d7 100644</span><br><span>--- a/src/mainboard/purism/librem_bdw/fadt.c</span><br><span>+++ b/src/mainboard/purism/librem_bdw/fadt.c</span><br><span>@@ -23,7 +23,7 @@</span><br><span> memset(fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c</span><br><span>index 7b4f07b..4094c38 100644</span><br><span>--- a/src/soc/amd/stoneyridge/acpi.c</span><br><span>+++ b/src/soc/amd/stoneyridge/acpi.c</span><br><span>@@ -77,7 +77,7 @@</span><br><span> memset((void *)fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c</span><br><span>index ae645a5..8fdaeee 100644</span><br><span>--- a/src/soc/intel/common/block/acpi/acpi.c</span><br><span>+++ b/src/soc/intel/common/block/acpi/acpi.c</span><br><span>@@ -110,7 +110,7 @@</span><br><span> const uint16_t pmbase = ACPI_BASE_ADDRESS;</span><br><span> </span><br><span> /* Use ACPI 3.0 revision. */</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->header.revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ fadt->header.revision = get_acpi_table_revision(FADT);</span><br><span> </span><br><span> fadt->sci_int = acpi_sci_irq();</span><br><span> fadt->smi_cmd = APM_CNT;</span><br><span>diff --git a/src/soc/intel/fsp_baytrail/acpi.c b/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>index 748b6cf..f4dd545 100644</span><br><span>--- a/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>+++ b/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>@@ -191,7 +191,7 @@</span><br><span> /* FADT Header Structure */</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c</span><br><span>index 38b4d47..9b64edc 100644</span><br><span>--- a/src/soc/intel/fsp_broadwell_de/acpi.c</span><br><span>+++ b/src/soc/intel/fsp_broadwell_de/acpi.c</span><br><span>@@ -167,7 +167,7 @@</span><br><span> /* FADT Header Structure */</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c</span><br><span>index cff610f..44096cd 100644</span><br><span>--- a/src/soc/intel/skylake/acpi.c</span><br><span>+++ b/src/soc/intel/skylake/acpi.c</span><br><span>@@ -241,7 +241,7 @@</span><br><span> const uint16_t pmbase = ACPI_BASE_ADDRESS;</span><br><span> </span><br><span> /* Use ACPI 3.0 revision */</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->header.revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ fadt->header.revision = get_acpi_table_revision(FADT);</span><br><span> </span><br><span> fadt->sci_int = acpi_sci_irq();</span><br><span> fadt->smi_cmd = APM_CNT;</span><br><span>diff --git a/src/southbridge/amd/agesa/hudson/fadt.c b/src/southbridge/amd/agesa/hudson/fadt.c</span><br><span>index c1d9b72..1cb9875 100644</span><br><span>--- a/src/southbridge/amd/agesa/hudson/fadt.c</span><br><span>+++ b/src/southbridge/amd/agesa/hudson/fadt.c</span><br><span>@@ -49,7 +49,7 @@</span><br><span> memset((void *)fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/southbridge/amd/cimx/sb800/fadt.c b/src/southbridge/amd/cimx/sb800/fadt.c</span><br><span>index ad47ad7..59e61da 100644</span><br><span>--- a/src/southbridge/amd/cimx/sb800/fadt.c</span><br><span>+++ b/src/southbridge/amd/cimx/sb800/fadt.c</span><br><span>@@ -53,7 +53,7 @@</span><br><span> memset((void *)fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c</span><br><span>index 84c6a1d..c2a3ff4 100644</span><br><span>--- a/src/southbridge/amd/pi/hudson/fadt.c</span><br><span>+++ b/src/southbridge/amd/pi/hudson/fadt.c</span><br><span>@@ -49,7 +49,7 @@</span><br><span> memset((void *)fadt, 0, sizeof(acpi_fadt_t));</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span>diff --git a/src/southbridge/intel/fsp_rangeley/acpi.c b/src/southbridge/intel/fsp_rangeley/acpi.c</span><br><span>index 45f0558..ca711dc 100644</span><br><span>--- a/src/southbridge/intel/fsp_rangeley/acpi.c</span><br><span>+++ b/src/southbridge/intel/fsp_rangeley/acpi.c</span><br><span>@@ -48,7 +48,7 @@</span><br><span> /* FADT Header Structure */</span><br><span> memcpy(header->signature, "FACP", 4);</span><br><span> header->length = sizeof(acpi_fadt_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = ACPI_FADT_REV_ACPI_3_0;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(FADT);</span><br><span> memcpy(header->oem_id, OEM_ID, 6);</span><br><span> memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28277">change 28277</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28277"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie554faf1be65c7034dd0836f0029cdc79eae1aed </div>
<div style="display:none"> Gerrit-Change-Number: 28277 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>