<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28300">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/intel/gma: Fix OpRegion Mailbox3 backlight change<br><br>The ACPI interface always uses a percentage for the brightness value,<br>BCLP, OTOH, is defined to take a value from 0 to 255. We also always<br>update BCLP, no matter if the driver is ready yet to process the re-<br>quest. This way it will hold the current value when the driver ini-<br>tializes.<br><br>Change-Id: I4b091d744f95da39abe542966f0a8589a187573b<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M src/drivers/intel/gma/acpi/configure_brightness_levels.asl<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/28300/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl</span><br><span>index 8625f04..72e5466 100644</span><br><span>--- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl</span><br><span>+++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl</span><br><span>@@ -2,6 +2,7 @@</span><br><span>  * This file is part of the coreboot project.</span><br><span>  *</span><br><span>  * Copyright (C) 2015 Nico Huber <nico.huber@secunet.com></span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Nico Huber <nico.h@gmx.de></span><br><span>  * Copyright (C) 2018 Patrick Rudolph</span><br><span>  *</span><br><span>  * This program is free software; you can redistribute it and/or modify</span><br><span>@@ -64,12 +65,16 @@</span><br><span>                       {</span><br><span>                            Return (Ones)</span><br><span>                        }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* Always keep BCLP up to date, even if driver is not ready */</span><br><span style="color: hsl(120, 100%, 40%);">+                        Store (Divide (Multiply (Arg0, 255), 100), Local0)</span><br><span style="color: hsl(120, 100%, 40%);">+                    Store (Or (Local0, 0x80000000), BCLP)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>                      If (LEqual(ARDY, Zero))</span><br><span>                      {</span><br><span>                            Return (Ones)</span><br><span>                        }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-                   Store (Or (Arg0, 0x80000000), BCLP)</span><br><span>                  /* Request back-light change */</span><br><span>                      Store (0x2, ASLC)</span><br><span>                    /* Trigger IRQ */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28300">change 28300</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28300"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4b091d744f95da39abe542966f0a8589a187573b </div>
<div style="display:none"> Gerrit-Change-Number: 28300 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>