<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +2</span></p><p><a href="https://review.coreboot.org/28286">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28286/2/src/vendorcode/intel/fsp/fsp2_0/coffeelake/CFLFspHeaderUpdate.sh">File src/vendorcode/intel/fsp/fsp2_0/coffeelake/CFLFspHeaderUpdate.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28286/2/src/vendorcode/intel/fsp/fsp2_0/coffeelake/CFLFspHeaderUpdate.sh">Patch Set #2:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">I wonder if it's possible to generalize the script a bit and put it in util/scripts?</p><p style="white-space: pre-wrap; word-wrap: break-word;">eg. update-fsp-headers.sh CoffeeLake -> loads from $1FspBinPkg and stores in src/vendorcode/fsp/fsp2_0/$(echo $1 | tr '[A-Z]' '[a-z]')/</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28286">change 28286</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28286"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I656da83e9042642576b785643e423ba47da8dd73 </div>
<div style="display:none"> Gerrit-Change-Number: 28286 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 23 Aug 2018 14:32:49 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>