<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28263">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus/variants/bobba: Apply new GPIO configs for bid >= 2<br><br>This change updates the board id check for version >=2 to apply new<br>GPIO configs.<br><br>BUG=b:112618194<br><br>Change-Id: I3544c9596c465615818d2040682e554a64fc6b1a<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/octopus/variants/bobba/gpio.c<br>M src/mainboard/google/octopus/variants/bobba/variant.c<br>2 files changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/28263/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/variants/bobba/gpio.c b/src/mainboard/google/octopus/variants/bobba/gpio.c</span><br><span>index 4fe5434..20e2230 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/bobba/gpio.c</span><br><span>+++ b/src/mainboard/google/octopus/variants/bobba/gpio.c</span><br><span>@@ -39,6 +39,7 @@</span><br><span>         const struct pad_config *c = NULL;</span><br><span>   switch (board_id()) {</span><br><span>        case 0:</span><br><span style="color: hsl(120, 100%, 40%);">+       case 1:</span><br><span>      case UNDEFINED_STRAPPING_ID:</span><br><span>                 *num = 0;</span><br><span>            break;</span><br><span>@@ -81,11 +82,11 @@</span><br><span> {</span><br><span>    /*</span><br><span>    * This is a hack to configure EN_PP3300_WLAN based on board id. Once</span><br><span style="color: hsl(0, 100%, 40%);">-    * board id 0 is deprecated, we can get rid of this.</span><br><span style="color: hsl(120, 100%, 40%);">+   * board id 0/1 is deprecated, we can get rid of this.</span><br><span>        */</span><br><span>  uint32_t bid = board_id();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  if (bid == UNDEFINED_STRAPPING_ID || bid < 1)</span><br><span style="color: hsl(120, 100%, 40%);">+      if (bid == UNDEFINED_STRAPPING_ID || bid < 2)</span><br><span>             gpio_output(GPIO_178, 1);</span><br><span>    else</span><br><span>                 gpio_output(GPIO_178, 0);</span><br><span>diff --git a/src/mainboard/google/octopus/variants/bobba/variant.c b/src/mainboard/google/octopus/variants/bobba/variant.c</span><br><span>index 1ead5e2..07545dc 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/bobba/variant.c</span><br><span>+++ b/src/mainboard/google/octopus/variants/bobba/variant.c</span><br><span>@@ -38,7 +38,7 @@</span><br><span>       bid = board_id();</span><br><span> </span><br><span>        /* Nothing to update. */</span><br><span style="color: hsl(0, 100%, 40%);">-        if (bid == UNDEFINED_STRAPPING_ID || bid < 1)</span><br><span style="color: hsl(120, 100%, 40%);">+      if (bid == UNDEFINED_STRAPPING_ID || bid < 2)</span><br><span>             return;</span><br><span> </span><br><span>  touchscreen_i2c_host = dev_find_slot(0, PCH_DEVFN_I2C7);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28263">change 28263</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28263"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3544c9596c465615818d2040682e554a64fc6b1a </div>
<div style="display:none"> Gerrit-Change-Number: 28263 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>