<p>John Zhao has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28261">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/apollolake: Fix logical vs. bitwise operator<br><br>src/soc/intel/apollolake/chip.c<br>  Apply bitwise operator instead of logical one.<br><br>Found-by: Coverity Scan<br>BRANCH=None<br>TEST=Built & booted Yorp board.<br><br>Change-Id: I36746b04dec889f53c8d7eeb3b1d8118eff1de42<br>Signed-off-by: John Zhao <john.zhao@intel.com><br>---<br>M src/soc/intel/apollolake/chip.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/28261/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c</span><br><span>index 83a6baa..9b8cfd7 100644</span><br><span>--- a/src/soc/intel/apollolake/chip.c</span><br><span>+++ b/src/soc/intel/apollolake/chip.c</span><br><span>@@ -678,7 +678,7 @@</span><br><span>       cfg0 = (void *)(uintptr_t)(res->base + DUAL_ROLE_CFG0);</span><br><span>   cfg1 = (void *)(uintptr_t)(res->base + DUAL_ROLE_CFG1);</span><br><span>   reg = read32(cfg0);</span><br><span style="color: hsl(0, 100%, 40%);">-     if (!(reg && SW_IDPIN_EN_MASK))</span><br><span style="color: hsl(120, 100%, 40%);">+       if (!(reg & SW_IDPIN_EN_MASK))</span><br><span>           return;</span><br><span> </span><br><span>  reg &= ~(SW_IDPIN_MASK | SW_VBUS_VALID_MASK);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28261">change 28261</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28261"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I36746b04dec889f53c8d7eeb3b1d8118eff1de42 </div>
<div style="display:none"> Gerrit-Change-Number: 28261 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: John Zhao <john.zhao@intel.com> </div>