<p>John Zhao has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28235">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/mainboard: Fix issues found by klockwork<br><br>src/mainboard/google/octopus/mainboard.c<br>  Function wifi_device_update: Pointer dev returned from<br>  call dev_find_slot may be NULL and will be dereferenced.<br><br>BRANCH=None<br>TEST=Built & booted Yorp board.<br><br>Change-Id: I160adbe3b0a5a2b0f11fd1567513860664d4bee3<br>Signed-off-by: John Zhao <john.zhao@intel.com><br>---<br>M src/mainboard/google/octopus/mainboard.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/28235/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/mainboard.c b/src/mainboard/google/octopus/mainboard.c</span><br><span>index 61d254e..6effa7c 100644</span><br><span>--- a/src/mainboard/google/octopus/mainboard.c</span><br><span>+++ b/src/mainboard/google/octopus/mainboard.c</span><br><span>@@ -169,7 +169,8 @@</span><br><span>               devfn = PCH_DEVFN_PCIE1;</span><br><span> </span><br><span>         dev = dev_find_slot(0, devfn);</span><br><span style="color: hsl(0, 100%, 40%);">-  dev->enabled = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+  if (dev)</span><br><span style="color: hsl(120, 100%, 40%);">+              dev->enabled = 0;</span><br><span> }</span><br><span> </span><br><span> void mainboard_devtree_update(struct device *dev)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28235">change 28235</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28235"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I160adbe3b0a5a2b0f11fd1567513860664d4bee3 </div>
<div style="display:none"> Gerrit-Change-Number: 28235 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: John Zhao <john.zhao@intel.com> </div>