<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28249">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lib/gpio.c: Validate num_gpio<br><br>In function _gpio_base3_value(), if num_gpio is 0 it'll cause the return<br>of an undefined value, as no for loop will be executed. Assert that it's<br>not 0.<br><br>BUG=b:112253891<br>TEST=Build and boot grunt.<br><br>Change-Id: I2b6537900fa41ebbee0171959f3ce236d360bc80<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/lib/gpio.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/28249/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/lib/gpio.c b/src/lib/gpio.c</span><br><span>index 0656dfb..482f62d 100644</span><br><span>--- a/src/lib/gpio.c</span><br><span>+++ b/src/lib/gpio.c</span><br><span>@@ -82,7 +82,7 @@</span><br><span>  int index;</span><br><span>   int temp;</span><br><span>    char value[32];</span><br><span style="color: hsl(0, 100%, 40%);">- assert(num_gpio <= 32);</span><br><span style="color: hsl(120, 100%, 40%);">+    assert((num_gpio <= 32) && (num_gpio > 0));</span><br><span> </span><br><span>        /* Enable internal pull up */</span><br><span>        for (index = 0; index < num_gpio; ++index)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28249">change 28249</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28249"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2b6537900fa41ebbee0171959f3ce236d360bc80 </div>
<div style="display:none"> Gerrit-Change-Number: 28249 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>