<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28229">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/pineview: Use i2c block read to fetch SPD<br><br>With this the time spend during the raminit decreases from ~480ms to ~126ms.<br><br>Change-Id: Ic23f39f1017010c89795e626f6a6f918f8bda17a<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/pineview/raminit.c<br>1 file changed, 5 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/28229/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c</span><br><span>index 2a1e34c..f1e0767 100644</span><br><span>--- a/src/northbridge/intel/pineview/raminit.c</span><br><span>+++ b/src/northbridge/intel/pineview/raminit.c</span><br><span>@@ -271,20 +271,13 @@</span><br><span> </span><br><span> static void sdram_read_spds(struct sysinfo *s)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- u8 i, j, chan;</span><br><span style="color: hsl(0, 100%, 40%);">-  int status = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+       u8 i, chan;</span><br><span>  s->dt0mode = 0;</span><br><span>   FOR_EACH_DIMM(i) {</span><br><span style="color: hsl(0, 100%, 40%);">-              for (j = 0; j < 64; j++) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   status = spd_read_byte(s->spd_map[i], j);</span><br><span style="color: hsl(0, 100%, 40%);">-                    if (status < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                            s->dimms[i].card_type = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-                           break;</span><br><span style="color: hsl(0, 100%, 40%);">-                  }</span><br><span style="color: hsl(0, 100%, 40%);">-                       s->dimms[i].spd_data[j] = (u8) status;</span><br><span style="color: hsl(0, 100%, 40%);">-                       if (j == 62)</span><br><span style="color: hsl(0, 100%, 40%);">-                            s->dimms[i].card_type = ((u8) status) & 0x1f;</span><br><span style="color: hsl(0, 100%, 40%);">-            }</span><br><span style="color: hsl(120, 100%, 40%);">+             if (i2c_block_read(s->spd_map[i], 0, 64, s->dimms[i].spd_data) != 64)</span><br><span style="color: hsl(120, 100%, 40%);">+                   s->dimms[i].card_type = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+               s->dimms[i].card_type = s->dimms[i].spd_data[62] & 0x1f;</span><br><span>           hexdump(s->dimms[i].spd_data, 64);</span><br><span>        }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28229">change 28229</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28229"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic23f39f1017010c89795e626f6a6f918f8bda17a </div>
<div style="display:none"> Gerrit-Change-Number: 28229 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>