<p>Martin Roth <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/28122">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/kahlee: Fix ACPI method Not Serialized error<br><br>Fix the following failure from FWTS:<br><br>FAILED [LOW] AMLAsmASL_MSG_SERIALIZED_REQUIRED: Test 1, Assembler remark in line<br>131<br>Line | AML source<br>--------------------------------------------------------------------------------<br>00128|                 }<br>00129|             }<br>00130|         })<br>00131|         Method (_CRS, 0, NotSerialized)  // _CRS: Current Resource Settings<br>     |                   ^<br>     | Remark 2120: Control Method should be made Serialized    (due to creation of named objects within)<br>00132|         {<br>00133|             Name (RBUF, ResourceTemplate ()<br>00134|             {<br>================================================================================<br><br>ADVICE: (for Remark #2120, ASL_MSG_SERIALIZED_REQUIRED): A named object is<br>created inside a non-serialized method - this method should be serialized. It is<br>possible that one thread enters the method and blocks and then a second thread<br>also executes the method, ending up in two attempts to create the object and<br>causing a failure.<br><br>BUG=b:112476331<br>TEST= Run FWTS.<br><br>Change-Id: I6f4f6e7e94b01f673afc97d9415481ee63e406e3<br>Signed-off-by: Marc Jones <marcj303@gmail.com><br>Reviewed-on: https://review.coreboot.org/28122<br>Reviewed-by: Martin Roth <martinroth@google.com><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl</span><br><span>index 28599a0..6bb41ae 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl</span><br><span>@@ -31,7 +31,7 @@</span><br><span>               }</span><br><span>    })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  Method (_CRS, 0x0, NotSerialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+   Method (_CRS, 0x0, Serialized) {</span><br><span>             Name (RBUF, ResourceTemplate () {</span><br><span>                    // Memory resource is for MISC FCH register set.</span><br><span>                     // It is needed for enabling the clock.</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28122">change 28122</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28122"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6f4f6e7e94b01f673afc97d9415481ee63e406e3 </div>
<div style="display:none"> Gerrit-Change-Number: 28122 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>