<p>Martin Roth <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/28121">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Martin Roth: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix PCI ACPI _OSC methods<br><br>Fix the IASL build warnings:<br>Object is not referenced (Name [CDW2] is within a method [_OSC])<br>Object is not referenced (Name [CDW3] is within a method [_OSC])<br><br>Remove the not referenced objects. They are not needed.<br><br>BUG=b:112476331<br>TEST=IASL doesn't give the warning.<br><br>Change-Id: I5b38d4de3f9875c5b013a49eb5146bf5916b96a6<br>Signed-off-by: Marc Jones <marcj303@gmail.com><br>Reviewed-on: https://review.coreboot.org/28121<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Martin Roth <martinroth@google.com><br>---<br>M src/northbridge/intel/i945/acpi/i945.asl<br>M src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl<br>M src/southbridge/amd/agesa/hudson/acpi/fch.asl<br>M src/southbridge/amd/cimx/sb800/acpi/fch.asl<br>M src/southbridge/amd/pi/hudson/acpi/fch.asl<br>5 files changed, 5 insertions(+), 25 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/i945/acpi/i945.asl b/src/northbridge/intel/i945/acpi/i945.asl</span><br><span>index 5a93238..79fb371 100644</span><br><span>--- a/src/northbridge/intel/i945/acpi/i945.asl</span><br><span>+++ b/src/northbridge/intel/i945/acpi/i945.asl</span><br><span>@@ -20,17 +20,13 @@</span><br><span> /* Operating System Capabilities Method */</span><br><span> Method (_OSC, 4)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- // Create DWord-addressable fields from the Capabilities Buffer</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3, 0, CDW1)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3, 4, CDW2)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3, 8, CDW3)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Check for proper PCI/PCIe UUID */</span><br><span> If (LEqual(Arg0, ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))</span><br><span> {</span><br><span> /* Let OS control everything */</span><br><span> Return(Arg3)</span><br><span> } Else {</span><br><span style="color: hsl(120, 100%, 40%);">+ CreateDWordField(Arg3, 0, CDW1)</span><br><span> Or(CDW1, 4, CDW1) // Unrecognized UUID, so set bit 2 to 1</span><br><span> Return(Arg3)</span><br><span> }</span><br><span>diff --git a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl</span><br><span>index 2855b23..cdda503 100644</span><br><span>--- a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl</span><br><span>+++ b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl</span><br><span>@@ -22,17 +22,13 @@</span><br><span> /* Operating System Capabilities Method */</span><br><span> Method(_OSC,4)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- // Create DWord-addressable fields from the Capabilities Buffer</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,0,CDW1)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,4,CDW2)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,8,CDW3)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Check for proper PCI/PCIe UUID */</span><br><span> If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))</span><br><span> {</span><br><span> /* Let OS control everything */</span><br><span> Return (Arg3)</span><br><span> } Else {</span><br><span style="color: hsl(120, 100%, 40%);">+ CreateDWordField(Arg3,0,CDW1)</span><br><span> Or(CDW1,4,CDW1) // Unrecognized UUID</span><br><span> Return(Arg3)</span><br><span> }</span><br><span>diff --git a/src/southbridge/amd/agesa/hudson/acpi/fch.asl b/src/southbridge/amd/agesa/hudson/acpi/fch.asl</span><br><span>index efd6a93..2bbaa25 100644</span><br><span>--- a/src/southbridge/amd/agesa/hudson/acpi/fch.asl</span><br><span>+++ b/src/southbridge/amd/agesa/hudson/acpi/fch.asl</span><br><span>@@ -20,17 +20,13 @@</span><br><span> /* Operating System Capabilities Method */</span><br><span> Method(_OSC,4)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- // Create DWord-addressable fields from the Capabilities Buffer</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,0,CDW1)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,4,CDW2)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,8,CDW3)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Check for proper PCI/PCIe UUID */</span><br><span> If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))</span><br><span> {</span><br><span> /* Let OS control everything */</span><br><span> Return (Arg3)</span><br><span> } Else {</span><br><span style="color: hsl(120, 100%, 40%);">+ CreateDWordField(Arg3,0,CDW1)</span><br><span> Or(CDW1,4,CDW1) // Unrecognized UUID</span><br><span> Return(Arg3)</span><br><span> }</span><br><span>diff --git a/src/southbridge/amd/cimx/sb800/acpi/fch.asl b/src/southbridge/amd/cimx/sb800/acpi/fch.asl</span><br><span>index 6f0826f..2dc3438 100644</span><br><span>--- a/src/southbridge/amd/cimx/sb800/acpi/fch.asl</span><br><span>+++ b/src/southbridge/amd/cimx/sb800/acpi/fch.asl</span><br><span>@@ -19,17 +19,13 @@</span><br><span> /* Operating System Capabilities Method */</span><br><span> Method(_OSC,4)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- // Create DWord-addressable fields from the Capabilities Buffer</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,0,CDW1)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,4,CDW2)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,8,CDW3)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Check for proper PCI/PCIe UUID */</span><br><span> If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))</span><br><span> {</span><br><span> /* Let OS control everything */</span><br><span> Return (Arg3)</span><br><span> } Else {</span><br><span style="color: hsl(120, 100%, 40%);">+ CreateDWordField(Arg3,0,CDW1)</span><br><span> Or(CDW1,4,CDW1) // Unrecognized UUID</span><br><span> Return(Arg3)</span><br><span> }</span><br><span>diff --git a/src/southbridge/amd/pi/hudson/acpi/fch.asl b/src/southbridge/amd/pi/hudson/acpi/fch.asl</span><br><span>index 2586dd4..b33a440 100644</span><br><span>--- a/src/southbridge/amd/pi/hudson/acpi/fch.asl</span><br><span>+++ b/src/southbridge/amd/pi/hudson/acpi/fch.asl</span><br><span>@@ -20,17 +20,13 @@</span><br><span> /* Operating System Capabilities Method */</span><br><span> Method(_OSC,4)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- // Create DWord-addressable fields from the Capabilities Buffer</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,0,CDW1)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,4,CDW2)</span><br><span style="color: hsl(0, 100%, 40%);">- CreateDWordField(Arg3,8,CDW3)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Check for proper PCI/PCIe UUID */</span><br><span> If(LEqual(Arg0,ToUUID("33DB4D5B-1FF7-401C-9657-7441C03DD766")))</span><br><span> {</span><br><span> /* Let OS control everything */</span><br><span> Return (Arg3)</span><br><span> } Else {</span><br><span style="color: hsl(120, 100%, 40%);">+ CreateDWordField(Arg3,0,CDW1)</span><br><span> Or(CDW1,4,CDW1) // Unrecognized UUID</span><br><span> Return(Arg3)</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28121">change 28121</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28121"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I5b38d4de3f9875c5b013a49eb5146bf5916b96a6 </div>
<div style="display:none"> Gerrit-Change-Number: 28121 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>