<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28191">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/sandybridge: Fill in DIMM serial number<br><br>Fill in SMBIOS type 17 DIMM serial number, read from SPD.<br><br>Fixes FWTS SMBIOS type 17 test.<br><br>Change-Id: Id6e818bfdf4af0fd34af56dc23df052a3f8c348d<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/device/dram/ddr3.c<br>M src/include/device/dram/ddr3.h<br>M src/northbridge/intel/sandybridge/raminit.c<br>3 files changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/28191/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c</span><br><span>index a084ca0..2fe9a62 100644</span><br><span>--- a/src/device/dram/ddr3.c</span><br><span>+++ b/src/device/dram/ddr3.c</span><br><span>@@ -398,6 +398,9 @@</span><br><span>     memcpy(dimm->part_number, &spd[128], 16);</span><br><span>     printram("  Part number        : %s\n", dimm->part_number);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  memcpy(&dimm->serial, &spd[122], 4);</span><br><span style="color: hsl(120, 100%, 40%);">+       printram("  Serial number      : 0x%x\n", dimm->serial);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      return ret;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/include/device/dram/ddr3.h b/src/include/device/dram/ddr3.h</span><br><span>index 9a24661..951d9c5 100644</span><br><span>--- a/src/include/device/dram/ddr3.h</span><br><span>+++ b/src/include/device/dram/ddr3.h</span><br><span>@@ -174,6 +174,8 @@</span><br><span>      u16 manufacturer_id;</span><br><span>         /* ASCII part number - NULL terminated */</span><br><span>    u8 part_number[17];</span><br><span style="color: hsl(120, 100%, 40%);">+   /* Serial number */</span><br><span style="color: hsl(120, 100%, 40%);">+   u32 serial;</span><br><span> } dimm_attr;</span><br><span> </span><br><span> enum ddr3_xmp_profile {</span><br><span>diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c</span><br><span>index 47474ee..c397fa5 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/raminit.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/raminit.c</span><br><span>@@ -114,6 +114,8 @@</span><br><span>                    dimm->mod_id = info->dimm[channel][slot].manufacturer_id;</span><br><span>                      dimm->mod_type = info->dimm[channel][slot].dimm_type;</span><br><span>                  dimm->bus_width = MEMORY_BUS_WIDTH_64; // non-ECC only</span><br><span style="color: hsl(120, 100%, 40%);">+                     memcpy(&dimm->serial, &info->dimm[channel][slot].serial,</span><br><span style="color: hsl(120, 100%, 40%);">+                               DIMM_INFO_SERIAL_SIZE);</span><br><span>                       mem_info->dimm_cnt++;</span><br><span>             }</span><br><span>    }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28191">change 28191</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28191"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id6e818bfdf4af0fd34af56dc23df052a3f8c348d </div>
<div style="display:none"> Gerrit-Change-Number: 28191 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>