<p>Alexander Couzens has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28195">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/pmh7: use read/write function in clear_bit/set_bit<br><br>Make the code simpler and improve readability.<br><br>Change-Id: Ifa9308c32e4646c122254931b55fb83541a10a3c<br>---<br>M src/ec/lenovo/pmh7/pmh7.c<br>1 file changed, 4 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/28195/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/lenovo/pmh7/pmh7.c b/src/ec/lenovo/pmh7/pmh7.c</span><br><span>index c975679..b160fd0 100644</span><br><span>--- a/src/ec/lenovo/pmh7/pmh7.c</span><br><span>+++ b/src/ec/lenovo/pmh7/pmh7.c</span><br><span>@@ -68,20 +68,16 @@</span><br><span> {</span><br><span>     char val;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   outb(reg, EC_LENOVO_PMH7_ADDR);</span><br><span style="color: hsl(0, 100%, 40%);">- val = inb(EC_LENOVO_PMH7_DATA);</span><br><span style="color: hsl(0, 100%, 40%);">- outb(reg, EC_LENOVO_PMH7_ADDR);</span><br><span style="color: hsl(0, 100%, 40%);">- outb(val | (1 << bit), EC_LENOVO_PMH7_DATA);</span><br><span style="color: hsl(120, 100%, 40%);">+    val = pmh7_register_read(reg);</span><br><span style="color: hsl(120, 100%, 40%);">+        pmh7_register_write(reg, val | (1 << bit));</span><br><span> }</span><br><span> </span><br><span> void pmh7_register_clear_bit(int reg, int bit)</span><br><span> {</span><br><span>    char val;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   outb(reg, EC_LENOVO_PMH7_ADDR);</span><br><span style="color: hsl(0, 100%, 40%);">- val = inb(EC_LENOVO_PMH7_DATA);</span><br><span style="color: hsl(0, 100%, 40%);">- outb(reg, EC_LENOVO_PMH7_ADDR);</span><br><span style="color: hsl(0, 100%, 40%);">- outb(val &= ~(1 << bit), EC_LENOVO_PMH7_DATA);</span><br><span style="color: hsl(120, 100%, 40%);">+      val = pmh7_register_read(reg);</span><br><span style="color: hsl(120, 100%, 40%);">+        pmh7_register_write(reg, val & ~(1 << bit));</span><br><span> }</span><br><span> </span><br><span> char pmh7_register_read(int reg)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28195">change 28195</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28195"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ifa9308c32e4646c122254931b55fb83541a10a3c </div>
<div style="display:none"> Gerrit-Change-Number: 28195 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexander Couzens <lynxis@fe80.eu> </div>