<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28198">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Makefile.inc: Fix dependency tracking of fmap{_config.h,.desc}<br><br>GNU make is too smart (or too stupid?) for empty recipes. In the case of<br>empty recipes, GNU make doesn't consider the target as updated even if<br>its prerequisites are. So if we told make to rebuild `build/romstage/<br>lib/cbfs.o` for instance, and the FMAP changed, it rerun the fmaptool<br>recipe (as a prerequisite) but only considered `cbfs.o` to be updated<br>by chance.<br><br>Just not leaving the recipes empty seems to help here. I seeemed to<br>remember that it wasn't that easy, but it fixes the issue for me...<br><br>Change-Id: Ic7ecb88cf7df7f2488defd47ea02255fc10a67e9<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M Makefile.inc<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/28198/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Makefile.inc b/Makefile.inc</span><br><span>index 7ce2360..4eec58b 100644</span><br><span>--- a/Makefile.inc</span><br><span>+++ b/Makefile.inc</span><br><span>@@ -950,7 +950,9 @@</span><br><span> </span><br><span> # generated at the same time as fmap.fmap</span><br><span> $(obj)/fmap_config.h: $(obj)/fmap.fmap</span><br><span style="color: hsl(120, 100%, 40%);">+       true</span><br><span> $(obj)/fmap.desc: $(obj)/fmap.fmap</span><br><span style="color: hsl(120, 100%, 40%);">+    true</span><br><span> </span><br><span> $(obj)/fmap.fmap: $(obj)/fmap.fmd $(FMAPTOOL)</span><br><span>    echo "    FMAP       $(FMAPTOOL) -h $(obj)/fmap_config.h $< $@"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28198">change 28198</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28198"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic7ecb88cf7df7f2488defd47ea02255fc10a67e9 </div>
<div style="display:none"> Gerrit-Change-Number: 28198 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>