<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28192">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/sandybridge/raminit: Fix DIMM type mapping<br><br>The DIMM type read from SPD needs to be converted to make sure SMBIOS fills<br>in the correct formfactor.<br><br>Tested on Lenovo T430: The Form Factor no longer reads as unknown.<br><br>Change-Id: Ia0211fa133f4ba9d60dfbd5f0dd45a43df68c030<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/northbridge/intel/sandybridge/raminit.c<br>1 file changed, 23 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/28192/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c</span><br><span>index c397fa5..6e408f1 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/raminit.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/raminit.c</span><br><span>@@ -112,7 +112,29 @@</span><br><span> memcpy(dimm->module_part_number,</span><br><span> info->dimm[channel][slot].part_number, 16);</span><br><span> dimm->mod_id = info->dimm[channel][slot].manufacturer_id;</span><br><span style="color: hsl(0, 100%, 40%);">- dimm->mod_type = info->dimm[channel][slot].dimm_type;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (info->dimm[channel][slot].dimm_type) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case SPD_DIMM_TYPE_SO_DIMM:</span><br><span style="color: hsl(120, 100%, 40%);">+ dimm->mod_type = SPD_SODIMM;</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case SPD_DIMM_TYPE_72B_SO_CDIMM:</span><br><span style="color: hsl(120, 100%, 40%);">+ dimm->mod_type = SPD_72B_SO_CDIMM;</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case SPD_DIMM_TYPE_72B_SO_RDIMM:</span><br><span style="color: hsl(120, 100%, 40%);">+ dimm->mod_type = SPD_72B_SO_RDIMM;</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case SPD_DIMM_TYPE_UDIMM:</span><br><span style="color: hsl(120, 100%, 40%);">+ dimm->mod_type = SPD_UDIMM;</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case SPD_DIMM_TYPE_RDIMM:</span><br><span style="color: hsl(120, 100%, 40%);">+ dimm->mod_type = SPD_RDIMM;</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case SPD_DIMM_TYPE_UNDEFINED:</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ dimm->mod_type = SPD_UNDEFINED;</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> dimm->bus_width = MEMORY_BUS_WIDTH_64; // non-ECC only</span><br><span> memcpy(&dimm->serial, &info->dimm[channel][slot].serial,</span><br><span> DIMM_INFO_SERIAL_SIZE);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28192">change 28192</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28192"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia0211fa133f4ba9d60dfbd5f0dd45a43df68c030 </div>
<div style="display:none"> Gerrit-Change-Number: 28192 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>