<p>Martin Roth <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/28117">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sandybridge/raminit_common.c: fix printram statement<br><br>Change-Id: Iddea8cc71dc1fb33d46b22dd19e39bf1c1257555<br>Signed-off-by: Iru Cai <mytbk920423@gmail.com><br>Reviewed-on: https://review.coreboot.org/28117<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Felix Held <felix-coreboot@felixheld.de><br>---<br>M src/northbridge/intel/sandybridge/raminit_common.c<br>1 file changed, 8 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>index d806066..a90b055 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>@@ -195,7 +195,7 @@</span><br><span> static void dram_odt_stretch(ramctr_timing *ctrl, int channel)</span><br><span> {</span><br><span>         struct cpuid_result cpures;</span><br><span style="color: hsl(0, 100%, 40%);">-     u32 cpu, stretch;</span><br><span style="color: hsl(120, 100%, 40%);">+     u32 addr, cpu, stretch;</span><br><span> </span><br><span>  stretch = ctrl->ref_card_offset[channel];</span><br><span>         /* ODT stretch: Delay ODT signal by stretch value.</span><br><span>@@ -205,14 +205,17 @@</span><br><span>   if (IS_SANDY_CPU(cpu) && IS_SANDY_CPU_C(cpu)) {</span><br><span>              if (stretch == 2)</span><br><span>                    stretch = 3;</span><br><span style="color: hsl(0, 100%, 40%);">-            MCHBAR32_AND_OR(0x401c + 0x400 * channel, 0xffffc3ff,</span><br><span style="color: hsl(120, 100%, 40%);">+         addr = 0x401c + 0x400 * channel;</span><br><span style="color: hsl(120, 100%, 40%);">+              MCHBAR32_AND_OR(addr, 0xffffc3ff,</span><br><span>                    (stretch << 12) | (stretch << 10));</span><br><span style="color: hsl(0, 100%, 40%);">-         printram("OTHP Workaround [%x] = %x\n", addr, reg);</span><br><span style="color: hsl(120, 100%, 40%);">+         printk(RAM_DEBUG, "OTHP Workaround [%x] = %x\n", addr,</span><br><span style="color: hsl(120, 100%, 40%);">+                      MCHBAR32(addr));</span><br><span>     } else {</span><br><span>             // OTHP</span><br><span style="color: hsl(0, 100%, 40%);">-         MCHBAR32_AND_OR(0x400c + 0x400 * channel, 0xfff0ffff,</span><br><span style="color: hsl(120, 100%, 40%);">+         addr = 0x400c + 0x400 * channel;</span><br><span style="color: hsl(120, 100%, 40%);">+              MCHBAR32_AND_OR(addr, 0xfff0ffff,</span><br><span>                    (stretch << 16) | (stretch << 18));</span><br><span style="color: hsl(0, 100%, 40%);">-         printram("OTHP [%x] = %x\n", addr, reg);</span><br><span style="color: hsl(120, 100%, 40%);">+            printk(RAM_DEBUG, "OTHP [%x] = %x\n", addr, MCHBAR32(addr));</span><br><span>       }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28117">change 28117</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28117"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iddea8cc71dc1fb33d46b22dd19e39bf1c1257555 </div>
<div style="display:none"> Gerrit-Change-Number: 28117 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Iru Cai <mytbk920423@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>