<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28193">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ACPI: Get rid of FADT model field<br><br>ACPI spec 2.0 recommends to set it to zero, while one is still allowed.<br>Remove the mixed occurences and always set it to zero.<br><br>Fixes FWTS FADT test.<br><br>Change-Id: I74e83e3c8c0fa80d830565e5bc487d21fef35e6f<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/mainboard/aopen/dxplplusu/fadt.c<br>M src/mainboard/emulation/qemu-q35/acpi_tables.c<br>M src/mainboard/google/auron/fadt.c<br>M src/mainboard/google/beltino/fadt.c<br>M src/mainboard/google/cyan/fadt.c<br>M src/mainboard/google/jecht/fadt.c<br>M src/mainboard/google/rambi/fadt.c<br>M src/mainboard/google/slippy/fadt.c<br>M src/mainboard/intel/baskingridge/fadt.c<br>M src/mainboard/intel/harcuvar/fadt.c<br>M src/mainboard/intel/strago/fadt.c<br>M src/mainboard/intel/wtm2/fadt.c<br>M src/mainboard/lenovo/t400/fadt.c<br>M src/mainboard/lenovo/x200/fadt.c<br>M src/mainboard/purism/librem_bdw/fadt.c<br>M src/mainboard/roda/rk9/fadt.c<br>M src/mainboard/scaleway/tagada/fadt.c<br>M src/soc/amd/stoneyridge/acpi.c<br>M src/soc/intel/fsp_baytrail/acpi.c<br>M src/soc/intel/fsp_broadwell_de/acpi.c<br>M src/southbridge/amd/agesa/hudson/fadt.c<br>M src/southbridge/amd/cimx/sb800/fadt.c<br>M src/southbridge/amd/pi/hudson/fadt.c<br>M src/southbridge/intel/bd82x6x/lpc.c<br>M src/southbridge/intel/fsp_bd82x6x/lpc.c<br>M src/southbridge/intel/fsp_i89xx/lpc.c<br>M src/southbridge/intel/fsp_rangeley/acpi.c<br>M src/southbridge/intel/i82801gx/lpc.c<br>M src/southbridge/intel/i82801jx/lpc.c<br>M src/southbridge/intel/ibexpeak/lpc.c<br>30 files changed, 3 insertions(+), 34 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/28193/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/aopen/dxplplusu/fadt.c b/src/mainboard/aopen/dxplplusu/fadt.c</span><br><span>index 418d547..262b790 100644</span><br><span>--- a/src/mainboard/aopen/dxplplusu/fadt.c</span><br><span>+++ b/src/mainboard/aopen/dxplplusu/fadt.c</span><br><span>@@ -45,7 +45,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = 0; /* PM_MOBILE; */</span><br><span> </span><br><span> fadt->sci_int = 0x9;</span><br><span>diff --git a/src/mainboard/emulation/qemu-q35/acpi_tables.c b/src/mainboard/emulation/qemu-q35/acpi_tables.c</span><br><span>index 83d25d7..09cfb65 100644</span><br><span>--- a/src/mainboard/emulation/qemu-q35/acpi_tables.c</span><br><span>+++ b/src/mainboard/emulation/qemu-q35/acpi_tables.c</span><br><span>@@ -57,7 +57,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 0x00;</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> fadt->sci_int = 0x9;</span><br><span> fadt->smi_cmd = 0;</span><br><span>diff --git a/src/mainboard/google/auron/fadt.c b/src/mainboard/google/auron/fadt.c</span><br><span>index dea67d0..a9c307f 100644</span><br><span>--- a/src/mainboard/google/auron/fadt.c</span><br><span>+++ b/src/mainboard/google/auron/fadt.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> </span><br><span> fadt->x_firmware_ctl_l = (unsigned long)facs;</span><br><span>diff --git a/src/mainboard/google/beltino/fadt.c b/src/mainboard/google/beltino/fadt.c</span><br><span>index 486a343..a065565 100644</span><br><span>--- a/src/mainboard/google/beltino/fadt.c</span><br><span>+++ b/src/mainboard/google/beltino/fadt.c</span><br><span>@@ -35,7 +35,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> </span><br><span> fadt->sci_int = 0x9;</span><br><span>diff --git a/src/mainboard/google/cyan/fadt.c b/src/mainboard/google/cyan/fadt.c</span><br><span>index d62c28d..62f1c31 100644</span><br><span>--- a/src/mainboard/google/cyan/fadt.c</span><br><span>+++ b/src/mainboard/google/cyan/fadt.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> </span><br><span> fadt->x_firmware_ctl_l = (unsigned long)facs;</span><br><span>diff --git a/src/mainboard/google/jecht/fadt.c b/src/mainboard/google/jecht/fadt.c</span><br><span>index dea67d0..a9c307f 100644</span><br><span>--- a/src/mainboard/google/jecht/fadt.c</span><br><span>+++ b/src/mainboard/google/jecht/fadt.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> </span><br><span> fadt->x_firmware_ctl_l = (unsigned long)facs;</span><br><span>diff --git a/src/mainboard/google/rambi/fadt.c b/src/mainboard/google/rambi/fadt.c</span><br><span>index b0fe9d6..a0e1381 100644</span><br><span>--- a/src/mainboard/google/rambi/fadt.c</span><br><span>+++ b/src/mainboard/google/rambi/fadt.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> </span><br><span> fadt->x_firmware_ctl_l = (unsigned long)facs;</span><br><span>diff --git a/src/mainboard/google/slippy/fadt.c b/src/mainboard/google/slippy/fadt.c</span><br><span>index fe86f56..7220b86 100644</span><br><span>--- a/src/mainboard/google/slippy/fadt.c</span><br><span>+++ b/src/mainboard/google/slippy/fadt.c</span><br><span>@@ -35,7 +35,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> </span><br><span> fadt->sci_int = 0x9;</span><br><span>diff --git a/src/mainboard/intel/baskingridge/fadt.c b/src/mainboard/intel/baskingridge/fadt.c</span><br><span>index e32e9f2..63d8de1 100644</span><br><span>--- a/src/mainboard/intel/baskingridge/fadt.c</span><br><span>+++ b/src/mainboard/intel/baskingridge/fadt.c</span><br><span>@@ -35,7 +35,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = PM_DESKTOP;</span><br><span> </span><br><span> fadt->sci_int = 0x9;</span><br><span>diff --git a/src/mainboard/intel/harcuvar/fadt.c b/src/mainboard/intel/harcuvar/fadt.c</span><br><span>index 9f41f64..1e1e71b 100644</span><br><span>--- a/src/mainboard/intel/harcuvar/fadt.c</span><br><span>+++ b/src/mainboard/intel/harcuvar/fadt.c</span><br><span>@@ -36,7 +36,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long)facs;</span><br><span> fadt->dsdt = (unsigned long)dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER;</span><br><span> </span><br><span> fadt->x_firmware_ctl_l = (unsigned long)facs;</span><br><span>diff --git a/src/mainboard/intel/strago/fadt.c b/src/mainboard/intel/strago/fadt.c</span><br><span>index af222b5..c62f6fd 100644</span><br><span>--- a/src/mainboard/intel/strago/fadt.c</span><br><span>+++ b/src/mainboard/intel/strago/fadt.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> </span><br><span> fadt->x_firmware_ctl_l = (unsigned long)facs;</span><br><span>diff --git a/src/mainboard/intel/wtm2/fadt.c b/src/mainboard/intel/wtm2/fadt.c</span><br><span>index d474fc4..f9d0e08 100644</span><br><span>--- a/src/mainboard/intel/wtm2/fadt.c</span><br><span>+++ b/src/mainboard/intel/wtm2/fadt.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> </span><br><span> fadt->x_firmware_ctl_l = (unsigned long)facs;</span><br><span>diff --git a/src/mainboard/lenovo/t400/fadt.c b/src/mainboard/lenovo/t400/fadt.c</span><br><span>index fe988d6..2989a40 100644</span><br><span>--- a/src/mainboard/lenovo/t400/fadt.c</span><br><span>+++ b/src/mainboard/lenovo/t400/fadt.c</span><br><span>@@ -35,7 +35,7 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 0x00;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> fadt->sci_int = 0x9;</span><br><span> fadt->smi_cmd = APM_CNT;</span><br><span>diff --git a/src/mainboard/lenovo/x200/fadt.c b/src/mainboard/lenovo/x200/fadt.c</span><br><span>index fe988d6..2989a40 100644</span><br><span>--- a/src/mainboard/lenovo/x200/fadt.c</span><br><span>+++ b/src/mainboard/lenovo/x200/fadt.c</span><br><span>@@ -35,7 +35,7 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 0x00;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> fadt->sci_int = 0x9;</span><br><span> fadt->smi_cmd = APM_CNT;</span><br><span>diff --git a/src/mainboard/purism/librem_bdw/fadt.c b/src/mainboard/purism/librem_bdw/fadt.c</span><br><span>index 9cbcd3f..6503b1d 100644</span><br><span>--- a/src/mainboard/purism/librem_bdw/fadt.c</span><br><span>+++ b/src/mainboard/purism/librem_bdw/fadt.c</span><br><span>@@ -31,7 +31,7 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (u32)facs;</span><br><span> fadt->dsdt = (u32)dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> </span><br><span> fadt->x_firmware_ctl_l = (u32)facs;</span><br><span>diff --git a/src/mainboard/roda/rk9/fadt.c b/src/mainboard/roda/rk9/fadt.c</span><br><span>index fe988d6..1684d27 100644</span><br><span>--- a/src/mainboard/roda/rk9/fadt.c</span><br><span>+++ b/src/mainboard/roda/rk9/fadt.c</span><br><span>@@ -35,7 +35,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 0x00;</span><br><span> fadt->preferred_pm_profile = PM_MOBILE;</span><br><span> fadt->sci_int = 0x9;</span><br><span> fadt->smi_cmd = APM_CNT;</span><br><span>diff --git a/src/mainboard/scaleway/tagada/fadt.c b/src/mainboard/scaleway/tagada/fadt.c</span><br><span>index 9f41f64..1e1e71b 100644</span><br><span>--- a/src/mainboard/scaleway/tagada/fadt.c</span><br><span>+++ b/src/mainboard/scaleway/tagada/fadt.c</span><br><span>@@ -36,7 +36,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (unsigned long)facs;</span><br><span> fadt->dsdt = (unsigned long)dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER;</span><br><span> </span><br><span> fadt->x_firmware_ctl_l = (unsigned long)facs;</span><br><span>diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c</span><br><span>index 5f9e792..c0d9113 100644</span><br><span>--- a/src/soc/amd/stoneyridge/acpi.c</span><br><span>+++ b/src/soc/amd/stoneyridge/acpi.c</span><br><span>@@ -85,7 +85,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (u32) facs;</span><br><span> fadt->dsdt = (u32) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 0; /* reserved, should be 0 ACPI 3.0 */</span><br><span> fadt->preferred_pm_profile = FADT_PM_PROFILE;</span><br><span> fadt->sci_int = 9; /* IRQ 09 - ACPI SCI */</span><br><span> </span><br><span>diff --git a/src/soc/intel/fsp_baytrail/acpi.c b/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>index 7ce1b35..9631a78 100644</span><br><span>--- a/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>+++ b/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>@@ -201,7 +201,6 @@</span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 0; /* reserved, should be 0 ACPI 3.0 */</span><br><span> fadt->preferred_pm_profile = config->fadt_pm_profile; /* unknown is default */</span><br><span> </span><br><span> /* System Management */</span><br><span>diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c</span><br><span>index 38b4d47..875050b 100644</span><br><span>--- a/src/soc/intel/fsp_broadwell_de/acpi.c</span><br><span>+++ b/src/soc/intel/fsp_broadwell_de/acpi.c</span><br><span>@@ -177,7 +177,6 @@</span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 0; /* reserved, should be 0 ACPI 3.0 */</span><br><span> fadt->preferred_pm_profile = 0;</span><br><span> fadt->sci_int = acpi_sci_irq();</span><br><span> </span><br><span>diff --git a/src/southbridge/amd/agesa/hudson/fadt.c b/src/southbridge/amd/agesa/hudson/fadt.c</span><br><span>index c1d9b72..5aeb0f9 100644</span><br><span>--- a/src/southbridge/amd/agesa/hudson/fadt.c</span><br><span>+++ b/src/southbridge/amd/agesa/hudson/fadt.c</span><br><span>@@ -65,7 +65,6 @@</span><br><span> else</span><br><span> fadt->dsdt = (uintptr_t)dsdt;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 0; /* reserved, should be 0 ACPI 3.0 */</span><br><span> fadt->preferred_pm_profile = FADT_PM_PROFILE;</span><br><span> fadt->sci_int = 9; /* HUDSON - IRQ 09 - ACPI SCI */</span><br><span> </span><br><span>diff --git a/src/southbridge/amd/cimx/sb800/fadt.c b/src/southbridge/amd/cimx/sb800/fadt.c</span><br><span>index ad47ad7..1313a53 100644</span><br><span>--- a/src/southbridge/amd/cimx/sb800/fadt.c</span><br><span>+++ b/src/southbridge/amd/cimx/sb800/fadt.c</span><br><span>@@ -69,7 +69,6 @@</span><br><span> else</span><br><span> fadt->dsdt = (uintptr_t)dsdt;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 0; /* reserved, should be 0 ACPI 3.0 */</span><br><span> fadt->preferred_pm_profile = FADT_PM_PROFILE;</span><br><span> fadt->sci_int = 9; /* HUDSON 1 - IRQ 09 - ACPI SCI */</span><br><span> fadt->smi_cmd = 0; /* disable system management mode */</span><br><span>diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c</span><br><span>index 84c6a1d..133470e 100644</span><br><span>--- a/src/southbridge/amd/pi/hudson/fadt.c</span><br><span>+++ b/src/southbridge/amd/pi/hudson/fadt.c</span><br><span>@@ -57,7 +57,6 @@</span><br><span> </span><br><span> fadt->firmware_ctrl = (u32) facs;</span><br><span> fadt->dsdt = (u32) dsdt;</span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 0; /* reserved, should be 0 ACPI 3.0 */</span><br><span> fadt->preferred_pm_profile = FADT_PM_PROFILE;</span><br><span> fadt->sci_int = 9; /* HUDSON - IRQ 09 - ACPI SCI */</span><br><span> </span><br><span>diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c</span><br><span>index d9e72b4..5cd70ff 100644</span><br><span>--- a/src/southbridge/intel/bd82x6x/lpc.c</span><br><span>+++ b/src/southbridge/intel/bd82x6x/lpc.c</span><br><span>@@ -759,8 +759,6 @@</span><br><span> u16 pmbase = pci_read_config16(dev, 0x40) & 0xfffe;</span><br><span> int c2_latency;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> fadt->sci_int = 0x9;</span><br><span> fadt->smi_cmd = APM_CNT;</span><br><span> fadt->acpi_enable = APM_CNT_ACPI_ENABLE;</span><br><span>diff --git a/src/southbridge/intel/fsp_bd82x6x/lpc.c b/src/southbridge/intel/fsp_bd82x6x/lpc.c</span><br><span>index 431587d..a24f4db 100644</span><br><span>--- a/src/southbridge/intel/fsp_bd82x6x/lpc.c</span><br><span>+++ b/src/southbridge/intel/fsp_bd82x6x/lpc.c</span><br><span>@@ -617,8 +617,6 @@</span><br><span> u16 pmbase = pci_read_config16(dev, 0x40) & 0xfffe;</span><br><span> int c2_latency;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> fadt->sci_int = 0x9;</span><br><span> fadt->smi_cmd = APM_CNT;</span><br><span> fadt->acpi_enable = APM_CNT_ACPI_ENABLE;</span><br><span>diff --git a/src/southbridge/intel/fsp_i89xx/lpc.c b/src/southbridge/intel/fsp_i89xx/lpc.c</span><br><span>index f584f36..b17af61 100644</span><br><span>--- a/src/southbridge/intel/fsp_i89xx/lpc.c</span><br><span>+++ b/src/southbridge/intel/fsp_i89xx/lpc.c</span><br><span>@@ -529,8 +529,6 @@</span><br><span> u16 pmbase = pci_read_config16(dev, 0x40) & 0xfffe;</span><br><span> int c2_latency;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> fadt->sci_int = 0x9;</span><br><span> fadt->smi_cmd = APM_CNT;</span><br><span> fadt->acpi_enable = APM_CNT_ACPI_ENABLE;</span><br><span>diff --git a/src/southbridge/intel/fsp_rangeley/acpi.c b/src/southbridge/intel/fsp_rangeley/acpi.c</span><br><span>index 45f0558..c224d22 100644</span><br><span>--- a/src/southbridge/intel/fsp_rangeley/acpi.c</span><br><span>+++ b/src/southbridge/intel/fsp_rangeley/acpi.c</span><br><span>@@ -58,7 +58,6 @@</span><br><span> fadt->firmware_ctrl = (unsigned long) facs;</span><br><span> fadt->dsdt = (unsigned long) dsdt;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 0; /* reserved, should be 0 ACPI 3.0 */</span><br><span> fadt->preferred_pm_profile = config->fadt_pm_profile; /* unknown is default */</span><br><span> </span><br><span> /* System Management */</span><br><span>diff --git a/src/southbridge/intel/i82801gx/lpc.c b/src/southbridge/intel/i82801gx/lpc.c</span><br><span>index ac83ec9..842868a 100644</span><br><span>--- a/src/southbridge/intel/i82801gx/lpc.c</span><br><span>+++ b/src/southbridge/intel/i82801gx/lpc.c</span><br><span>@@ -577,7 +577,6 @@</span><br><span> fadt->mon_alrm = 0x00;</span><br><span> fadt->century = 0x32;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->sci_int = 0x9;</span><br><span> fadt->smi_cmd = APM_CNT;</span><br><span> fadt->acpi_enable = APM_CNT_ACPI_ENABLE;</span><br><span>diff --git a/src/southbridge/intel/i82801jx/lpc.c b/src/southbridge/intel/i82801jx/lpc.c</span><br><span>index cd5e307..8d691a0 100644</span><br><span>--- a/src/southbridge/intel/i82801jx/lpc.c</span><br><span>+++ b/src/southbridge/intel/i82801jx/lpc.c</span><br><span>@@ -590,7 +590,6 @@</span><br><span> fadt->mon_alrm = 0x00;</span><br><span> fadt->century = 0x32;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span> fadt->sci_int = 0x9;</span><br><span> fadt->smi_cmd = APM_CNT;</span><br><span> fadt->acpi_enable = APM_CNT_ACPI_ENABLE;</span><br><span>diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c</span><br><span>index b09951f..ca7858b 100644</span><br><span>--- a/src/southbridge/intel/ibexpeak/lpc.c</span><br><span>+++ b/src/southbridge/intel/ibexpeak/lpc.c</span><br><span>@@ -652,8 +652,6 @@</span><br><span> u16 pmbase = pci_read_config16(dev, 0x40) & 0xfffe;</span><br><span> int c2_latency;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- fadt->model = 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> fadt->sci_int = 0x9;</span><br><span> fadt->smi_cmd = APM_CNT;</span><br><span> fadt->acpi_enable = APM_CNT_ACPI_ENABLE;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28193">change 28193</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28193"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I74e83e3c8c0fa80d830565e5bc487d21fef35e6f </div>
<div style="display:none"> Gerrit-Change-Number: 28193 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>