<p style="white-space: pre-wrap; word-wrap: break-word;">This fix is fine ofcourse, but the proper fix would be to replace all references to printram with printk(RAM_DEBUG, ...) or printk(RAM_SPEW, ...) in which case the code still gets compile tested.</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +2</span></p><p><a href="https://review.coreboot.org/28117">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28117/1/src/northbridge/intel/sandybridge/raminit_common.c">File src/northbridge/intel/sandybridge/raminit_common.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28117/1/src/northbridge/intel/sandybridge/raminit_common.c@210">Patch Set #1, Line 210:</a> <code style="font-family:monospace,monospace">printram(</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You avoid these problems with printk(RAM_DEBUG/RAM_SPEW, ...) instead of using preprocessor dependent printram.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28117">change 28117</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28117"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iddea8cc71dc1fb33d46b22dd19e39bf1c1257555 </div>
<div style="display:none"> Gerrit-Change-Number: 28117 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Iru Cai <mytbk920423@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 16 Aug 2018 08:56:13 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>