<p>Marc Jones has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28124">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">x86/acpigen: Fix ACPI _ROM method<br><br>Fix the following Error:<br>FAILED [LOW] AMLAsmASL_MSG_SERIALIZED_REQUIRED: Test 1, Assembler remark in line<br>142<br>Line | AML source<br>--------------------------------------------------------------------------------<br>00139|<br>00140|     Scope (\_SB.PCI0.IGFX)<br>00141|     {<br>00142|         Method (_ROM, 2, NotSerialized)  // _ROM: Read-Only Memory<br>     |                   ^<br>     | Remark 2120: Control Method should be made Serialized    (due to creation of named objects within)<br>00143|         {<br>00144|             OperationRegion (ROMS, SystemMemory, 0xCD520000, 0xFE00)<br>00145|             Field (ROMS, AnyAcc, NoLock, Preserve)<br>================================================================================<br><br>ADVICE: (for Remark #2120, ASL_MSG_SERIALIZED_REQUIRED): A named object is<br>created inside a non-serialized method - this method should be serialized. It is<br>possible that one thread enters the method and blocks and then a second thread<br>also executes the method, ending up in two attempts to create the object and<br>causing a failure.<br><br>Use the acpigen_write_method_serialized() to correct the error.<br><br>BUG=b:112476331<br>TEST=Run FWTS.<br><br>Change-Id: I145c3c3103efb4a02b4e02dd177f4bf50a2c7b3e<br>Signed-off-by: Marc Jones <marcj303@gmail.com><br>---<br>M src/arch/x86/acpigen.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/28124/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c</span><br><span>index a614efb..c842cca 100644</span><br><span>--- a/src/arch/x86/acpigen.c</span><br><span>+++ b/src/arch/x86/acpigen.c</span><br><span>@@ -1405,7 +1405,7 @@</span><br><span>         ASSERT(length)</span><br><span> </span><br><span>   /* Method (_ROM, 2, NotSerialized) */</span><br><span style="color: hsl(0, 100%, 40%);">-   acpigen_write_method("_ROM", 2);</span><br><span style="color: hsl(120, 100%, 40%);">+    acpigen_write_method_serialized("_ROM", 2);</span><br><span> </span><br><span>    /* OperationRegion("ROMS", SYSTEMMEMORY, current, length) */</span><br><span>       struct opregion opreg = OPREGION("ROMS", SYSTEMMEMORY,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28124">change 28124</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28124"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I145c3c3103efb4a02b4e02dd177f4bf50a2c7b3e </div>
<div style="display:none"> Gerrit-Change-Number: 28124 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>