<p><a href="https://review.coreboot.org/22604">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/22604/20/src/cpu/intel/speedstep/acpi.c">File src/cpu/intel/speedstep/acpi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22604/20/src/cpu/intel/speedstep/acpi.c@92">Patch Set #20, Line 92:</a> <code style="font-family:monospace,monospace">    else</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">else is not generally useful after a break or return</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/22604/20/src/cpu/intel/speedstep/speedstep.c">File src/cpu/intel/speedstep/speedstep.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22604/20/src/cpu/intel/speedstep/speedstep.c@45">Patch Set #20, Line 45:</a> <code style="font-family:monospace,monospace">              if (((rdmsr(MSR_EXTENDED_CONFIG).lo >> 27) & 3) == 3) {/*supported and</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22604/20/src/cpu/intel/speedstep/speedstep.c@46">Patch Set #20, Line 46:</a> <code style="font-family:monospace,monospace">                                                                        enabled bits */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22604/20/src/cpu/intel/speedstep/speedstep.c@48">Patch Set #20, Line 48:</a> <code style="font-family:monospace,monospace">                       params->slfm = SPEEDSTEP_STATE_FROM_MSR(msr.lo, state_mask);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22604/20/src/cpu/intel/speedstep/speedstep.c@77">Patch Set #20, Line 77:</a> <code style="font-family:monospace,monospace">                                !(rdmsr(IA32_MISC_ENABLES).hi & (1 << (38 - 32)))) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22604/20/src/cpu/intel/speedstep/speedstep.c@79">Patch Set #20, Line 79:</a> <code style="font-family:monospace,monospace">                 params->turbo = SPEEDSTEP_STATE_FROM_MSR(msr.hi, state_mask);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22604">change 22604</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22604"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a </div>
<div style="display:none"> Gerrit-Change-Number: 22604 </div>
<div style="display:none"> Gerrit-PatchSet: 20 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 15 Aug 2018 08:34:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>