<p>Raul Rangel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28100">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libpayload/x86/exception: Add ability to handle user defined interrupts<br><br>I need to setup the APIC timer to fire interrupts. I would like to reuse<br>the existing interrupt table. So I extended it to support user defined<br>interrupts. I just added all 255 vectors so there wouldn't need to be<br>any additional build time configuration.<br><br>BUG=b:109749762<br>TEST=Wrote an interrupt handler and fired an APIC timer interrupt and<br>verified that vector 32 was returned.<br><br>Change-Id: Id9c2583c7c3d9be4a06a25e546e64399f2b0620c<br>Signed-off-by: Raul E Rangel <rrangel@chromium.org><br>---<br>M payloads/libpayload/arch/x86/exception.c<br>M payloads/libpayload/arch/x86/exception_asm.S<br>2 files changed, 34 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/28100/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/payloads/libpayload/arch/x86/exception.c b/payloads/libpayload/arch/x86/exception.c</span><br><span>index b562660..c9ab6bf 100644</span><br><span>--- a/payloads/libpayload/arch/x86/exception.c</span><br><span>+++ b/payloads/libpayload/arch/x86/exception.c</span><br><span>@@ -161,7 +161,15 @@</span><br><span> void exception_dispatch(void)</span><br><span> {</span><br><span>        u32 vec = exception_state->vector;</span><br><span style="color: hsl(0, 100%, 40%);">-   die_if(vec >= EXC_COUNT || !names[vec], "Bad exception vector %u", vec);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+       /* Handle user defined vectors */</span><br><span style="color: hsl(120, 100%, 40%);">+     if (vec >= 32 && vec <= 255) {</span><br><span style="color: hsl(120, 100%, 40%);">+          die_if(!hook || !hook(vec),</span><br><span style="color: hsl(120, 100%, 40%);">+                  "Hook required to handle user defined vector %u\n", vec);</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   die_if(vec >= EXC_COUNT || !names[vec], "Bad exception vector %u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+            vec);</span><br><span> </span><br><span>     if (hook && hook(vec))</span><br><span>               return;</span><br><span>diff --git a/payloads/libpayload/arch/x86/exception_asm.S b/payloads/libpayload/arch/x86/exception_asm.S</span><br><span>index a8f9a1d..5bbe69e 100644</span><br><span>--- a/payloads/libpayload/arch/x86/exception_asm.S</span><br><span>+++ b/payloads/libpayload/arch/x86/exception_asm.S</span><br><span>@@ -68,6 +68,14 @@</span><br><span>    jmp     exception_common</span><br><span>     .endm</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     .altmacro</span><br><span style="color: hsl(120, 100%, 40%);">+     .macro  user_defined_stubs from, to</span><br><span style="color: hsl(120, 100%, 40%);">+   stub    \from</span><br><span style="color: hsl(120, 100%, 40%);">+ .if     \to-\from</span><br><span style="color: hsl(120, 100%, 40%);">+     user_defined_stubs      %(from+1),\to</span><br><span style="color: hsl(120, 100%, 40%);">+ .endif</span><br><span style="color: hsl(120, 100%, 40%);">+        .endm</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      stub 0</span><br><span>       stub 1</span><br><span>       stub 2</span><br><span>@@ -100,6 +108,11 @@</span><br><span>        stub 29</span><br><span>      stub_err 30</span><br><span>  stub 31</span><br><span style="color: hsl(120, 100%, 40%);">+       /* Split the macro so we avoid a stack overflow. */</span><br><span style="color: hsl(120, 100%, 40%);">+   user_defined_stubs 32, 63</span><br><span style="color: hsl(120, 100%, 40%);">+     user_defined_stubs 64, 127</span><br><span style="color: hsl(120, 100%, 40%);">+    user_defined_stubs 128, 191</span><br><span style="color: hsl(120, 100%, 40%);">+   user_defined_stubs 192, 255</span><br><span> </span><br><span> exception_common:</span><br><span>         /*</span><br><span>@@ -215,6 +228,14 @@</span><br><span>    .long \target</span><br><span>        .endm</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     .altmacro</span><br><span style="color: hsl(120, 100%, 40%);">+     .macro  user_defined_gates from, to</span><br><span style="color: hsl(120, 100%, 40%);">+   interrupt_gate  exception_stub_\from</span><br><span style="color: hsl(120, 100%, 40%);">+  .if     \to-\from</span><br><span style="color: hsl(120, 100%, 40%);">+     user_defined_gates      %(from+1),\to</span><br><span style="color: hsl(120, 100%, 40%);">+ .endif</span><br><span style="color: hsl(120, 100%, 40%);">+        .endm</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      .align 8</span><br><span>     .global idt</span><br><span> idt:</span><br><span>@@ -250,6 +271,10 @@</span><br><span>   interrupt_gate exception_stub_29</span><br><span>     interrupt_gate exception_stub_30</span><br><span>     interrupt_gate exception_stub_31</span><br><span style="color: hsl(120, 100%, 40%);">+      user_defined_gates 32, 63</span><br><span style="color: hsl(120, 100%, 40%);">+     user_defined_gates 64, 127</span><br><span style="color: hsl(120, 100%, 40%);">+    user_defined_gates 128, 191</span><br><span style="color: hsl(120, 100%, 40%);">+   user_defined_gates 192, 255</span><br><span> idt_end:</span><br><span> </span><br><span> /* IDT pointer for use with lidt */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28100">change 28100</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28100"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id9c2583c7c3d9be4a06a25e546e64399f2b0620c </div>
<div style="display:none"> Gerrit-Change-Number: 28100 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Raul Rangel <rrangel@chromium.org> </div>