<p>Angel Pons has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28099">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/superiotool: Add Winbond W83667HG register dump<br><br>This SuperIO is supported by coreboot and used in two Asus boards. However,<br>superiotool was lacking a register dump for this chip. Add the corresponding<br>data form the datasheet into superiotool.<br><br>The SuperIO's datasheet was obtained by requesting it to Nuvoton.<br><br>Change-Id: Ie51dc492c761d9c3d4b6100017bb730b1ae6d1e0<br>Signed-off-by: Angel Pons <th3fanbus@gmail.com><br>---<br>M util/superiotool/winbond.c<br>1 file changed, 69 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/28099/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/superiotool/winbond.c b/util/superiotool/winbond.c</span><br><span>index fce860d..571a2e0 100644</span><br><span>--- a/util/superiotool/winbond.c</span><br><span>+++ b/util/superiotool/winbond.c</span><br><span>@@ -296,7 +296,75 @@</span><br><span>                      {0x00,0x02,0xe8,0x03,0x00,EOT}},</span><br><span>             {EOT}}},</span><br><span>     {0xa51, "W83667HG", {</span><br><span style="color: hsl(0, 100%, 40%);">-         /* See also: http://lists.lm-sensors.org/pipermail/lm-sensors/2008-July/023683.html */</span><br><span style="color: hsl(120, 100%, 40%);">+                {NOLDN, NULL,</span><br><span style="color: hsl(120, 100%, 40%);">+                 {0x02,0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27,0x28,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                     {0x00,0xb3,NANA,0xff,0x00,MISC,0x00,MISC,0xff,0x20,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0x00,0x00,0x7f,0x0a,0x08,0x00,MISC,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+            {0x0, "Floppy",</span><br><span style="color: hsl(120, 100%, 40%);">+                     {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,0xf2,0xf4,0xf5,</span><br><span style="color: hsl(120, 100%, 40%);">+                    EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                        {0x01,0x03,0xf0,0x06,0x02,0x8e,0x00,0xff,0x00,0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+                    EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+               {0x1, "Parallel port",</span><br><span style="color: hsl(120, 100%, 40%);">+                      {0x30,0x60,0x61,0x70,0x74,0xf0,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                  {0x01,0x03,0x78,0x07,0x04,0x3f,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+         {0x2, "COM1",</span><br><span style="color: hsl(120, 100%, 40%);">+                       {0x30,0x60,0x61,0x70,0xf0,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                       {0x01,0x03,0xf8,0x04,0x00,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+              {0x3, "COM2",</span><br><span style="color: hsl(120, 100%, 40%);">+                       {0x30,0x60,0x61,0x70,0xf0,0xf1,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                  {0x01,0x02,0xf8,0x03,0x00,0x00,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+         {0x5, "Keyboard",</span><br><span style="color: hsl(120, 100%, 40%);">+                   {0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                        {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x83,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+               {0x6, "Serial peripheral interface",</span><br><span style="color: hsl(120, 100%, 40%);">+                        {0x30,0x62,0x63,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                 {0x00,0x00,0x00,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+                {0x7, "GPIO 6, GPIO 7, GPIO 8, GPIO 9",</span><br><span style="color: hsl(120, 100%, 40%);">+                     {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0xe9,0xea,0xeb,0xec,0xed,0xee,0xf4,0xf5,0xf6,0xf7,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0xf8,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                   {0x18,0xff,0x00,0x00,0x00,0xef,0x00,0x00,0x00,0xff,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0x00,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+          {0x8, "WDTO#, GPIO 1",</span><br><span style="color: hsl(120, 100%, 40%);">+                      {0x30,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,0xf7,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                   {0x00,0xff,0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+          {0x9, "GPIO 2, GPIO 3, GPIO 4, GPIO 5",</span><br><span style="color: hsl(120, 100%, 40%);">+                     {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0xe9,0xea,0xeb,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0xf7,0xfe,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                      {0x05,0xff,0x00,0x00,0x00,0xff,0x00,0x00,0x00,0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0x00,0x00,0x00,0xff,0x00,0x00,0x00,0xff,0x00,0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0x00,0x00,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+             {0xa, "ACPI",</span><br><span style="color: hsl(120, 100%, 40%);">+                       {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8,0xe9,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0xf2,0xf3,0xf4,0xf6,0xf7,0xfe,0xff,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                     {0x01,0x00,0xff,0x00,0x00,0x02,0x1c,0x00,RSVD,0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0x7c,0x00,0x00,0x00,0x00,0x00,0x30,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+            {0xb, "Hardware monitor, SB-TSI",</span><br><span style="color: hsl(120, 100%, 40%);">+                   {0x30,0x60,0x61,0x70,0xe0,0xe1,0xe2,0xe3,0xe4,0xf0,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0xf5,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                   {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xC1,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0x10,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+          {0xc, "PECI",</span><br><span style="color: hsl(120, 100%, 40%);">+                       {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe8,0xe9,0xea,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0xec,0xee,0xef,0xf1,0xf2,0xf3,0xfe,0xff,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                        {0x00,0x48,0x48,0x48,0x48,0x00,0x00,0x00,RSVD,0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0x00,0x01,0x5a,0x48,0x50,0x10,0x80,0x01,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+               {0xd, "VID",</span><br><span style="color: hsl(120, 100%, 40%);">+                        {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8,0xec,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0xed,0xee,0xef,0xf3,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                    {0x00,0x00,NANA,NANA,0x07,RSVD,RSVD,RSVD,RSVD,0x01,</span><br><span style="color: hsl(120, 100%, 40%);">+                    RSVD,0x88,0x00,0x04,EOT}},</span><br><span style="color: hsl(120, 100%, 40%);">+           {0xf, "GPIO Push-Pull or Open-Drain selection",</span><br><span style="color: hsl(120, 100%, 40%);">+                     {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8,0xe9,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,0xf7,0xf8,0xf9,</span><br><span style="color: hsl(120, 100%, 40%);">+                    0xfa,0xfb,0xfc,0xfd,0xfe,0xff,EOT},</span><br><span style="color: hsl(120, 100%, 40%);">+                  {0xff,0xff,0xfd,0xff,0xf7,0xcb,0x3f,0xff,0xff,0x00,</span><br><span style="color: hsl(120, 100%, 40%);">+                    NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,</span><br><span style="color: hsl(120, 100%, 40%);">+                    NANA,NANA,NANA,NANA,NANA,NANA,EOT}},</span><br><span>                {EOT}}},</span><br><span>     {0xb07, "W83627DHG-P/-PT", {</span><br><span>               {NOLDN, NULL,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28099">change 28099</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28099"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie51dc492c761d9c3d4b6100017bb730b1ae6d1e0 </div>
<div style="display:none"> Gerrit-Change-Number: 28099 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> </div>